llvm-project

mirrors/llvm-project

Fork 0

mirror of https://github.com/llvm/llvm-project.git synced 2025-04-26 08:36:07 +00:00

Commit Graph

Author	SHA1	Message	Date
Nick Desaulniers	3e02069afe	[libc][pthread] fix -Wmissing-field-initializers (#126314 ) Fixes: llvm-project/libc/test/integration/src/pthread/pthread_rwlock_test.cpp:59:29: warning: missing field '__preference' initializer [-Wmissing-field-initializers] 59 \| pthread_rwlock_t rwlock = PTHREAD_RWLOCK_INITIALIZER; \| ^ Also, add a test that demonstrates the same issue for PTHREAD_MUTEX_INITIALIZER, and fix that, too. PTHREAD_ONCE_INIT does not have this issue and does have test coverage.	2025-02-12 14:28:29 -08:00
Nick Desaulniers	8a25398615	[libc] move pthread macros to dedicated header (#119286 ) so that docgen can find our definitions. Also eliminate the enums. POSIX is careful to call these "symbolic constants" rather than specifically whether they are preprocessor macro defines or not. Enums are useful to expressing mutual exclusion when the enum values are in distinct enums which can improve type safety. Our enum values weren't using that pattern though; they were all in one big anonymous enum. Link: https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/pthread.h.html Fixes: #88997	2024-12-10 09:00:06 -08:00

Author

SHA1

Message

Date

Nick Desaulniers

3e02069afe

[libc][pthread] fix -Wmissing-field-initializers (#126314 )

Fixes:


llvm-project/libc/test/integration/src/pthread/pthread_rwlock_test.cpp:59:29:
    warning: missing field '__preference' initializer
    [-Wmissing-field-initializers]
       59 |   pthread_rwlock_t rwlock = PTHREAD_RWLOCK_INITIALIZER;
          |                             ^

Also, add a test that demonstrates the same issue for
PTHREAD_MUTEX_INITIALIZER, and fix that, too.

PTHREAD_ONCE_INIT does not have this issue and does have test coverage.

2025-02-12 14:28:29 -08:00

Nick Desaulniers

8a25398615

[libc] move pthread macros to dedicated header (#119286 )

so that docgen can find our definitions.

Also eliminate the enums. POSIX is careful to call these "symbolic constants"
rather than specifically whether they are preprocessor macro defines or not.
Enums are useful to expressing mutual exclusion when the enum values are in
distinct enums which can improve type safety. Our enum values weren't using
that pattern though; they were all in one big anonymous enum.

Link:
https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/pthread.h.html
Fixes: #88997

2024-12-10 09:00:06 -08:00

2 Commits