mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-18 14:46:39 +00:00
9a26d2c6d3
We started seeing a lot of timeouts that align with the change in lit to execute gtests in shards. The logic there assumes tests are single-threaded, which is the case for most of the LLVM, hence they pick #shards ~ #cores (by slightly overshooting). There are enough unittests in clangd that rely on multi-threading, they can create arbitrarily many threads but we limit amount of meaningful work to ~4 thread per process. This change ensures that we're accounting for that paralelism when executing clangd tests and not overloading test executors. In theory the change overestimates the requirements, not all tests are multi-threaded, but it doesn't seem to be resulting in any regressions on my local runs. Fixes https://github.com/llvm/llvm-project/issues/64964. Fixes https://github.com/clangd/clangd/issues/1712.
34 lines
1.3 KiB
Python
34 lines
1.3 KiB
Python
import lit.formats
|
|
import lit.util
|
|
|
|
config.name = "Clangd Unit Tests"
|
|
config.test_format = lit.formats.GoogleTest(".", "Tests")
|
|
config.test_source_root = config.clangd_binary_dir + "/unittests"
|
|
config.test_exec_root = config.clangd_binary_dir + "/unittests"
|
|
|
|
# Point the dynamic loader at dynamic libraries in 'lib'.
|
|
# FIXME: it seems every project has a copy of this logic. Move it somewhere.
|
|
import platform
|
|
|
|
# Clangd unittests uses ~4 threads per test. So make sure we don't over commit.
|
|
core_count = lit.util.usable_core_count()
|
|
# FIXME: Split unittests into groups that use threads, and groups that do not,
|
|
# and only limit multi-threaded tests.
|
|
lit_config.parallelism_groups["clangd"] = max(1, core_count // 4)
|
|
config.parallelism_group = "clangd"
|
|
|
|
if platform.system() == "Darwin":
|
|
shlibpath_var = "DYLD_LIBRARY_PATH"
|
|
elif platform.system() == "Windows":
|
|
shlibpath_var = "PATH"
|
|
else:
|
|
shlibpath_var = "LD_LIBRARY_PATH"
|
|
config.environment[shlibpath_var] = os.path.pathsep.join(
|
|
("@SHLIBDIR@", "@LLVM_LIBS_DIR@", config.environment.get(shlibpath_var, ""))
|
|
)
|
|
|
|
# It is not realistically possible to account for all options that could
|
|
# possibly be present in system and user configuration files, so disable
|
|
# default configs for the test runs.
|
|
config.environment["CLANG_NO_DEFAULT_CONFIG"] = "1"
|