mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-17 01:36:38 +00:00
8138d85f63
A clang user pointed out that messages for the static analyzer undefined assignment checker use the term ‘garbage’, which might have a negative connotation to some users. This change updates the messages to use the term ‘uninitialized’. This is the usual reason why a value is undefined in the static analyzer and describes the logical error that a programmer should take action to fix. Out-of-bounds reads can also produce undefined values in the static analyzer. The right long-term design is to have to the array bounds checker cover out-of-bounds reads, so we do not cover that case in the updated messages. The recent improvements to the array bounds checker make it a candidate to add to the core set of checkers. rdar://133418644
76 lines
1.7 KiB
C++
76 lines
1.7 KiB
C++
// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-output=text -verify %s
|
|
|
|
namespace implicit_constructor {
|
|
struct S {
|
|
public:
|
|
S() {}
|
|
S(const S &) {}
|
|
};
|
|
|
|
// Warning is in a weird position because the body of the constructor is
|
|
// missing. Specify which field is being assigned.
|
|
class C { // expected-warning{{Value assigned to field 'y' in implicit constructor is uninitialized}}
|
|
// expected-note@-1{{Value assigned to field 'y' in implicit constructor is uninitialized}}
|
|
int x, y;
|
|
S s;
|
|
|
|
public:
|
|
C(): x(0) {}
|
|
};
|
|
|
|
void test() {
|
|
C c1;
|
|
C c2(c1); // expected-note{{Calling implicit copy constructor for 'C'}}
|
|
}
|
|
} // end namespace implicit_constructor
|
|
|
|
|
|
namespace explicit_constructor {
|
|
class C {
|
|
int x, y;
|
|
|
|
public:
|
|
C(): x(0) {}
|
|
// It is not necessary to specify which field is being assigned to.
|
|
C(const C &c):
|
|
x(c.x),
|
|
y(c.y) // expected-warning{{Assigned value is uninitialized}}
|
|
// expected-note@-1{{Assigned value is uninitialized}}
|
|
{}
|
|
};
|
|
|
|
void test() {
|
|
C c1;
|
|
C c2(c1); // expected-note{{Calling copy constructor for 'C'}}
|
|
}
|
|
} // end namespace explicit_constructor
|
|
|
|
|
|
namespace base_class_constructor {
|
|
struct S {
|
|
public:
|
|
S() {}
|
|
S(const S &) {}
|
|
};
|
|
|
|
class C { // expected-warning{{Value assigned to field 'y' in implicit constructor is uninitialized}}
|
|
// expected-note@-1{{Value assigned to field 'y' in implicit constructor is uninitialized}}
|
|
int x, y;
|
|
S s;
|
|
|
|
public:
|
|
C(): x(0) {}
|
|
};
|
|
|
|
class D: public C {
|
|
public:
|
|
D(): C() {}
|
|
};
|
|
|
|
void test() {
|
|
D d1;
|
|
D d2(d1); // expected-note {{Calling implicit copy constructor for 'D'}}
|
|
// expected-note@-1{{Calling implicit copy constructor for 'C'}}
|
|
}
|
|
} // end namespace base_class_constructor
|