mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-16 22:26:37 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
89 lines
3.7 KiB
C
89 lines
3.7 KiB
C
// RUN: %clang_analyze_cc1 %s -analyzer-checker=core.NullDereference,core.DivideZero -fblocks -analyzer-output=text -analyzer-config suppress-null-return-paths=false -verify -analyzer-config eagerly-assume=false %s
|
|
// RUN: %clang_analyze_cc1 -analyzer-config eagerly-assume=false %s -analyzer-checker=core.NullDereference,core.DivideZero -fblocks -analyzer-output=plist -analyzer-config suppress-null-return-paths=false -o %t
|
|
// RUN: %normalize_plist <%t | diff -ub %S/Inputs/expected-plists/inline-plist.c.plist -
|
|
|
|
void mmm(int y) {
|
|
if (y != 0)
|
|
y++;
|
|
}
|
|
|
|
int foo(int x, int y) {
|
|
mmm(y);
|
|
if (x != 0) {
|
|
// expected-note@-1 {{Assuming 'x' is equal to 0}}
|
|
// expected-note@-2 {{Taking false branch}}
|
|
x++;
|
|
}
|
|
return 5/x; // expected-warning{{Division by zero}} expected-note{{Division by zero}}
|
|
}
|
|
|
|
// Test a bug triggering only when inlined.
|
|
void has_bug(int *p) {
|
|
*p = 0xDEADBEEF; // expected-warning{{Dereference of null pointer (loaded from variable 'p')}} expected-note{{Dereference of null pointer (loaded from variable 'p')}}
|
|
}
|
|
|
|
void test_has_bug(void) {
|
|
has_bug(0);
|
|
// expected-note@-1 {{Passing null pointer value via 1st parameter 'p'}}
|
|
// expected-note@-2 {{Calling 'has_bug'}}
|
|
}
|
|
|
|
void triggers_bug(int *p) {
|
|
*p = 0xDEADBEEF; // expected-warning{{Dereference of null pointer (loaded from variable 'p')}} expected-note{{Dereference of null pointer (loaded from variable 'p')}}
|
|
}
|
|
|
|
// This function triggers a bug by calling triggers_bug(). The diagnostics
|
|
// should show when p is assumed to be null.
|
|
void bar(int *p) {
|
|
if (!!p) {
|
|
// expected-note@-1 {{Assuming 'p' is null}}
|
|
// expected-note@-2 {{Taking false branch}}
|
|
return;
|
|
}
|
|
|
|
if (p == 0) {
|
|
// expected-note@-1 {{'p' is equal to null}}
|
|
// expected-note@-2 {{Taking true branch}}
|
|
triggers_bug(p);
|
|
// expected-note@-1 {{Passing null pointer value via 1st parameter 'p'}}
|
|
// expected-note@-2 {{Calling 'triggers_bug'}}
|
|
}
|
|
}
|
|
|
|
// ========================================================================== //
|
|
// Test inlining of blocks.
|
|
// ========================================================================== //
|
|
|
|
void test_block__capture_null(void) {
|
|
int *p = 0; // expected-note{{'p' initialized to a null pointer value}}
|
|
^(void){ // expected-note {{Calling anonymous block}}
|
|
*p = 1; // expected-warning{{Dereference of null pointer (loaded from variable 'p')}} expected-note{{Dereference of null pointer (loaded from variable 'p')}}
|
|
}();
|
|
|
|
}
|
|
|
|
void test_block_ret(void) {
|
|
int *p = ^int*(void){ // expected-note {{Calling anonymous block}} expected-note{{Returning to caller}} expected-note {{'p' initialized to a null pointer value}}
|
|
int *q = 0; // expected-note {{'q' initialized to a null pointer value}}
|
|
return q; // expected-note {{Returning null pointer (loaded from 'q')}}
|
|
}();
|
|
*p = 1; // expected-warning{{Dereference of null pointer (loaded from variable 'p')}} expected-note{{Dereference of null pointer (loaded from variable 'p')}}
|
|
}
|
|
|
|
void test_block_blockvar(void) {
|
|
__block int *p;
|
|
^(void){ // expected-note{{Calling anonymous block}} expected-note{{Returning to caller}}
|
|
p = 0; // expected-note{{Null pointer value stored to 'p'}}
|
|
}();
|
|
*p = 1; // expected-warning{{Dereference of null pointer (loaded from variable 'p')}} expected-note{{Dereference of null pointer (loaded from variable 'p')}}
|
|
}
|
|
|
|
void test_block_arg(void) {
|
|
int *p;
|
|
^(int **q){ // expected-note{{Calling anonymous block}} expected-note{{Returning to caller}}
|
|
*q = 0; // expected-note{{Null pointer value stored to 'p'}}
|
|
}(&p);
|
|
*p = 1; // expected-warning{{Dereference of null pointer (loaded from variable 'p')}} expected-note{{Dereference of null pointer (loaded from variable 'p')}}
|
|
}
|
|
|