mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-16 17:26:35 +00:00

Fixes #116372 From this PR #83585, CSA starts to model overload operator member function with explicit this as `SimpleFunctionCall` rather than `CXXMemberOperatorCall` (derived from `CXXInstanceCall`), so `CXXInstanceCall` only represents a non-static C++ member function call `with implicit this`. For this checker, it models `operator=` for STL containers, which always uses implicit this, so the situation using explicit this can be skipped directly.
231 lines
6.1 KiB
C++
231 lines
6.1 KiB
C++
// RUN: %clang_analyze_cc1 -std=c++11 -analyzer-checker=core,cplusplus,alpha.cplusplus.InvalidatedIterator -analyzer-config aggressive-binary-operation-simplification=true -analyzer-config c++-container-inlining=false %s -verify
|
|
// RUN: %clang_analyze_cc1 -std=c++11 -analyzer-checker=core,cplusplus,alpha.cplusplus.InvalidatedIterator -analyzer-config aggressive-binary-operation-simplification=true -analyzer-config c++-container-inlining=true -DINLINE=1 %s -verify
|
|
// RUN: %clang_analyze_cc1 -std=c++23 -analyzer-checker=core,cplusplus,alpha.cplusplus.InvalidatedIterator -analyzer-config aggressive-binary-operation-simplification=true -analyzer-config c++-container-inlining=true -DINLINE=1 %s -verify
|
|
|
|
#include "Inputs/system-header-simulator-cxx.h"
|
|
|
|
void clang_analyzer_warnIfReached();
|
|
|
|
void normal_dereference(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
*i; // no-warning
|
|
}
|
|
|
|
void invalidated_dereference(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
V.erase(i);
|
|
*i; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void normal_prefix_increment(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
++i; // no-warning
|
|
}
|
|
|
|
void invalidated_prefix_increment(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
V.erase(i);
|
|
++i; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void normal_prefix_decrement(std::vector<int> &V) {
|
|
auto i = ++V.cbegin();
|
|
--i; // no-warning
|
|
}
|
|
|
|
void invalidated_prefix_decrement(std::vector<int> &V) {
|
|
auto i = ++V.cbegin();
|
|
V.erase(i);
|
|
--i; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void normal_postfix_increment(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
i++; // no-warning
|
|
}
|
|
|
|
void invalidated_postfix_increment(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
V.erase(i);
|
|
i++; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void normal_postfix_decrement(std::vector<int> &V) {
|
|
auto i = ++V.cbegin();
|
|
i--; // no-warning
|
|
}
|
|
|
|
void invalidated_postfix_decrement(std::vector<int> &V) {
|
|
auto i = ++V.cbegin();
|
|
V.erase(i);
|
|
i--; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void normal_increment_by_2(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
i += 2; // no-warning
|
|
}
|
|
|
|
void invalidated_increment_by_2(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
V.erase(i);
|
|
i += 2; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void normal_increment_by_2_copy(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
auto j = i + 2; // no-warning
|
|
}
|
|
|
|
void invalidated_increment_by_2_copy(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
V.erase(i);
|
|
auto j = i + 2; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void normal_decrement_by_2(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
i -= 2; // no-warning
|
|
}
|
|
|
|
void invalidated_decrement_by_2(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
V.erase(i);
|
|
i -= 2; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void normal_decrement_by_2_copy(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
auto j = i - 2; // no-warning
|
|
}
|
|
|
|
void invalidated_decrement_by_2_copy(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
V.erase(i);
|
|
auto j = i - 2; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void normal_subscript(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
i[1]; // no-warning
|
|
}
|
|
|
|
void invalidated_subscript(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
V.erase(i);
|
|
i[1]; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void assignment(std::vector<int> &V) {
|
|
auto i = V.cbegin();
|
|
V.erase(i);
|
|
auto j = V.cbegin(); // no-warning
|
|
}
|
|
|
|
template<typename T>
|
|
struct cont_with_ptr_iterator {
|
|
T *begin() const;
|
|
T *end() const;
|
|
T &operator[](size_t);
|
|
void push_back(const T&);
|
|
T* erase(T*);
|
|
};
|
|
|
|
void invalidated_access_via_end_iterator_after_push_back() {
|
|
cont_with_ptr_iterator<int> C;
|
|
C.push_back(1);
|
|
auto i = C.end();
|
|
C.push_back(2);
|
|
auto j = i[-1]; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void invalidated_dereference_end_ptr_iterator(cont_with_ptr_iterator<int> &C) {
|
|
auto i = C.begin();
|
|
C.erase(i);
|
|
(void) *i; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void invalidated_prefix_increment_end_ptr_iterator(
|
|
cont_with_ptr_iterator<int> &C) {
|
|
auto i = C.begin();
|
|
C.erase(i);
|
|
++i; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void invalidated_prefix_decrement_end_ptr_iterator(
|
|
cont_with_ptr_iterator<int> &C) {
|
|
auto i = C.begin() + 1;
|
|
C.erase(i);
|
|
--i; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void invalidated_postfix_increment_end_ptr_iterator(
|
|
cont_with_ptr_iterator<int> &C) {
|
|
auto i = C.begin();
|
|
C.erase(i);
|
|
i++; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void invalidated_postfix_decrement_end_ptr_iterator(
|
|
cont_with_ptr_iterator<int> &C) {
|
|
auto i = C.begin() + 1;
|
|
C.erase(i);
|
|
i--; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void invalidated_increment_by_2_end_ptr_iterator(
|
|
cont_with_ptr_iterator<int> &C) {
|
|
auto i = C.begin();
|
|
C.erase(i);
|
|
i += 2; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void invalidated_increment_by_2_copy_end_ptr_iterator(
|
|
cont_with_ptr_iterator<int> &C) {
|
|
auto i = C.begin();
|
|
C.erase(i);
|
|
auto j = i + 2; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void invalidated_decrement_by_2_end_ptr_iterator(
|
|
cont_with_ptr_iterator<int> &C) {
|
|
auto i = C.begin();
|
|
C.erase(i);
|
|
i -= 2; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void invalidated_decrement_by_2_copy_end_ptr_iterator(
|
|
cont_with_ptr_iterator<int> &C) {
|
|
auto i = C.begin();
|
|
C.erase(i);
|
|
auto j = i - 2; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
void invalidated_subscript_end_ptr_iterator(cont_with_ptr_iterator<int> &C) {
|
|
auto i = C.begin();
|
|
C.erase(i);
|
|
(void) i[1]; // expected-warning{{Invalidated iterator accessed}}
|
|
}
|
|
|
|
#if __cplusplus >= 202302L
|
|
namespace GH116372 {
|
|
class ExplicitThis {
|
|
int f = 0;
|
|
public:
|
|
ExplicitThis();
|
|
ExplicitThis(ExplicitThis& other);
|
|
|
|
ExplicitThis& operator=(this ExplicitThis& self, ExplicitThis const& other) { // no crash
|
|
self.f = other.f;
|
|
return self;
|
|
}
|
|
|
|
~ExplicitThis();
|
|
};
|
|
|
|
void func(ExplicitThis& obj1) {
|
|
obj1 = obj1;
|
|
}
|
|
}
|
|
#endif
|