mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-18 12:56:50 +00:00
ffe7950ebc
I'm trying to remove unused options from the `Analyses.def` file, then merge the rest of the useful options into the `AnalyzerOptions.def`. Then make sure one can set these by an `-analyzer-config XXX=YYY` style flag. Then surface the `-analyzer-config` to the `clang` frontend; After all of this, we can pursue the tablegen approach described https://discourse.llvm.org/t/rfc-tablegen-clang-static-analyzer-engine-options-for-better-documentation/61488 In this patch, I'm proposing flag deprecations. We should support deprecated analyzer flags for exactly one release. In this case I'm planning to drop this flag in `clang-16`. In the clang frontend, now we won't pass this option to the cc1 frontend, rather emit a warning diagnostic reminding the users about this deprecated flag, which will be turned into error in clang-16. Unfortunately, I had to remove all the tests referring to this flag, causing a mass change. I've also added a test for checking this warning. I've seen that `scan-build` also uses this flag, but I think we should remove that part only after we turn this into a hard error. Reviewed By: martong Differential Revision: https://reviews.llvm.org/D126215
41 lines
1.3 KiB
Objective-C
41 lines
1.3 KiB
Objective-C
// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -verify -Wno-objc-root-class %s
|
|
|
|
extern void clang_analyzer_warnIfReached(void);
|
|
void clang_analyzer_eval(int);
|
|
|
|
@interface SomeClass
|
|
-(id)someMethodWithReturn;
|
|
-(void)someMethod;
|
|
@end
|
|
|
|
void consistencyOfReturnWithNilReceiver(SomeClass *o) {
|
|
id result = [o someMethodWithReturn];
|
|
if (result) {
|
|
if (!o) {
|
|
// It is impossible for both o to be nil and result to be non-nil,
|
|
// so this should not be reached.
|
|
clang_analyzer_warnIfReached(); // no-warning
|
|
}
|
|
}
|
|
}
|
|
|
|
void maybeNilReceiverIsNotNilAfterMessage(SomeClass *o) {
|
|
[o someMethod];
|
|
|
|
// We intentionally drop the nil flow (losing coverage) after a method
|
|
// call when the receiver may be nil in order to avoid inconsistencies of
|
|
// the kind tested for in consistencyOfReturnWithNilReceiver().
|
|
clang_analyzer_eval(o != 0); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void nilReceiverIsStillNilAfterMessage(SomeClass *o) {
|
|
if (o == 0) {
|
|
id result = [o someMethodWithReturn];
|
|
|
|
// Both the receiver and the result should be nil after a message
|
|
// sent to a nil receiver returning a value of type id.
|
|
clang_analyzer_eval(o == 0); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(result == 0); // expected-warning{{TRUE}}
|
|
}
|
|
}
|