mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-16 12:06:36 +00:00
ffe7950ebc
I'm trying to remove unused options from the `Analyses.def` file, then merge the rest of the useful options into the `AnalyzerOptions.def`. Then make sure one can set these by an `-analyzer-config XXX=YYY` style flag. Then surface the `-analyzer-config` to the `clang` frontend; After all of this, we can pursue the tablegen approach described https://discourse.llvm.org/t/rfc-tablegen-clang-static-analyzer-engine-options-for-better-documentation/61488 In this patch, I'm proposing flag deprecations. We should support deprecated analyzer flags for exactly one release. In this case I'm planning to drop this flag in `clang-16`. In the clang frontend, now we won't pass this option to the cc1 frontend, rather emit a warning diagnostic reminding the users about this deprecated flag, which will be turned into error in clang-16. Unfortunately, I had to remove all the tests referring to this flag, causing a mass change. I've also added a test for checking this warning. I've seen that `scan-build` also uses this flag, but I think we should remove that part only after we turn this into a hard error. Reviewed By: martong Differential Revision: https://reviews.llvm.org/D126215
85 lines
2.3 KiB
Objective-C
85 lines
2.3 KiB
Objective-C
// RUN: %clang_analyze_cc1 -analyzer-checker=core,osx.cocoa.RetainCount,alpha.core -analyzer-config ipa=none -verify %s
|
|
|
|
typedef const struct __CFString * CFStringRef;
|
|
typedef const struct __CFAllocator * CFAllocatorRef;
|
|
typedef const struct __CFURL * CFURLRef;
|
|
extern CFURLRef CFURLCreateWithString(CFAllocatorRef allocator, CFStringRef URLString, CFURLRef baseURL);
|
|
typedef signed char BOOL;
|
|
@protocol NSObject - (BOOL)isEqual:(id)object; @end
|
|
@interface NSObject <NSObject> {} @end
|
|
@class NSArray, NSString, NSURL;
|
|
|
|
@interface NamingTest : NSObject {}
|
|
-(NSObject*)copyPhoto;
|
|
-(NSObject*)mutableCopyPhoto;
|
|
-(NSObject*)mutable;
|
|
-(NSObject*)mutableCopying;
|
|
-(NSObject*)photocopy; // read as "photocopy"
|
|
-(NSObject*)photoCopy; // read as "photo Copy"
|
|
-(NSObject*)__blebPRCopy; // read as "bleb PRCopy"
|
|
-(NSObject*)__blebPRcopy; // read as "bleb P Rcopy"
|
|
-(NSObject*)new_theprefixdoescount; // read as "new theprefixdoescount"
|
|
-(NSObject*)newestAwesomeStuff; // read as "newest awesome stuff"
|
|
|
|
@end
|
|
|
|
@interface MyClass : NSObject
|
|
{
|
|
id myObject;
|
|
}
|
|
- (NSURL *)myMethod:(NSString *)inString;
|
|
- (NSURL *)getMethod:(NSString*)inString;
|
|
- (NSURL *)getMethod2:(NSString*)inString;
|
|
- (void)addObject:(id) __attribute__((ns_consumed)) X;
|
|
- (void)addObject2:(id) X;
|
|
@end
|
|
|
|
@implementation MyClass
|
|
|
|
- (NSURL *)myMethod:(NSString *)inString
|
|
{
|
|
NSURL *url = (NSURL *)CFURLCreateWithString(0, (CFStringRef)inString, 0); // expected-warning{{leak}}
|
|
return url;
|
|
}
|
|
|
|
- (NSURL *)getMethod:(NSString *)inString
|
|
{
|
|
NSURL *url = (NSURL *)CFURLCreateWithString(0, (CFStringRef)inString, 0);
|
|
[self addObject:url];
|
|
return url; // no-warning
|
|
}
|
|
|
|
- (NSURL *)getMethod2:(NSString *)inString
|
|
{
|
|
NSURL *url = (NSURL *)CFURLCreateWithString(0, (CFStringRef)inString, 0); // expected-warning{{leak}}
|
|
[self addObject2:url];
|
|
return url;
|
|
}
|
|
|
|
void testNames(NamingTest* x) {
|
|
[x copyPhoto]; // expected-warning{{leak}}
|
|
[x mutableCopyPhoto]; // expected-warning{{leak}}
|
|
[x mutable]; // no-warning
|
|
[x mutableCopying]; // no-warning
|
|
[x photocopy]; // no-warning
|
|
[x photoCopy]; // no-warning
|
|
[x __blebPRCopy]; // no-warning
|
|
[x __blebPRcopy]; // no-warning
|
|
[x new_theprefixdoescount]; // expected-warning{{leak}}
|
|
[x newestAwesomeStuff]; // no-warning
|
|
}
|
|
|
|
|
|
- (void)addObject:(id)X
|
|
{
|
|
myObject = X;
|
|
}
|
|
|
|
- (void)addObject2:(id)X
|
|
{
|
|
myObject = X;
|
|
}
|
|
|
|
@end
|
|
|