mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-18 01:36:44 +00:00
5d7fa481cf
In `RegionStore::getBinding` we call `evalCast` unconditionally to align the stored value's type to the one that is being queried. However, the stored type might be the same, so we may end up having redundant `SymbolCasts` emitted. The solution is to check whether the `to` and `from` type are the same in `makeNonLoc`. Note, we can't just do type equivalence check at the beginning of `evalCast` because when `evalCast` is called from `getBinding` then the original type (`OriginalTy`) is not set, so one operand is missing for the comparison. In `evalCastSubKind(nonloc::SymbolVal)` when the original type is not set, we get the `from` type via `SymbolVal::getType()`. Differential Revision: https://reviews.llvm.org/D128068
25 lines
846 B
C++
25 lines
846 B
C++
// RUN: %clang_analyze_cc1 -x c++ -analyzer-checker=debug.ExprInspection \
|
|
// RUN: -analyzer-config support-symbolic-integer-casts=false \
|
|
// RUN: -verify %s
|
|
|
|
// RUN: %clang_analyze_cc1 -x c++ -analyzer-checker=debug.ExprInspection \
|
|
// RUN: -analyzer-config support-symbolic-integer-casts=true \
|
|
// RUN: -verify %s
|
|
|
|
template <typename T>
|
|
void clang_analyzer_dump(T);
|
|
|
|
void test_no_redundant_floating_point_cast(int n) {
|
|
|
|
double D = n / 30;
|
|
clang_analyzer_dump(D); // expected-warning{{(double) ((reg_$0<int n>) / 30)}}
|
|
|
|
// There are two cast operations evaluated above:
|
|
// 1. (n / 30) is cast to a double during the store of `D`.
|
|
// 2. Then in the next line, in RegionStore::getBinding during the load of `D`.
|
|
//
|
|
// We should not see in the dump of the SVal any redundant casts like
|
|
// (double) ((double) $n / 30)
|
|
|
|
}
|