mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-16 12:06:36 +00:00

A clang user pointed out that messages for the static analyzer undefined assignment checker use the term ‘garbage’, which might have a negative connotation to some users. This change updates the messages to use the term ‘uninitialized’. This is the usual reason why a value is undefined in the static analyzer and describes the logical error that a programmer should take action to fix. Out-of-bounds reads can also produce undefined values in the static analyzer. The right long-term design is to have to the array bounds checker cover out-of-bounds reads, so we do not cover that case in the updated messages. The recent improvements to the array bounds checker make it a candidate to add to the core set of checkers. rdar://133418644
49 lines
1.0 KiB
C
49 lines
1.0 KiB
C
// RUN: %clang_analyze_cc1 -verify %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=unix \
|
|
// RUN: -analyzer-checker=core.uninitialized \
|
|
// RUN: -analyzer-config unix.DynamicMemoryModeling:Optimistic=true
|
|
|
|
typedef __typeof(sizeof(int)) size_t;
|
|
void *malloc(size_t);
|
|
void free(void *);
|
|
|
|
char stackBased1 (void) {
|
|
char buf[2];
|
|
buf[0] = 'a';
|
|
return buf[1]; // expected-warning{{Undefined}}
|
|
}
|
|
|
|
char stackBased2 (void) {
|
|
char buf[2];
|
|
buf[1] = 'a';
|
|
return buf[0]; // expected-warning{{Undefined}}
|
|
}
|
|
|
|
// Exercise the conditional visitor.
|
|
char stackBased3 (int *x) {
|
|
char buf[2];
|
|
int *y;
|
|
buf[0] = 'a';
|
|
if (!(y = x)) {
|
|
return buf[1]; // expected-warning{{Undefined}}
|
|
}
|
|
return buf[0];
|
|
}
|
|
|
|
char heapBased1 (void) {
|
|
char *buf = malloc(2);
|
|
buf[0] = 'a';
|
|
char result = buf[1]; // expected-warning{{uninitialized}}
|
|
free(buf);
|
|
return result;
|
|
}
|
|
|
|
char heapBased2 (void) {
|
|
char *buf = malloc(2);
|
|
buf[1] = 'a';
|
|
char result = buf[0]; // expected-warning{{uninitialized}}
|
|
free(buf);
|
|
return result;
|
|
}
|