mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-16 22:26:37 +00:00
017675fff1
The attribute is now allowed on an assortment of declarations, to suppress warnings related to declarations themselves, or all warnings in the lexical scope of the declaration. I don't necessarily see a reason to have a list at all, but it does look as if some of those more niche items aren't properly supported by the compiler itself so let's maintain a short safe list for now. The initial implementation raised a question whether the attribute should apply to lexical declaration context vs. "actual" declaration context. I'm using "lexical" here because it results in less warnings suppressed, which is the conservative behavior: we can always expand it later if we think this is wrong, without breaking any existing code. I also think that this is the correct behavior that we will probably never want to change, given that the user typically desires to keep the suppressions as localized as possible.
138 lines
3.2 KiB
Objective-C
138 lines
3.2 KiB
Objective-C
// RUN: %clang_analyze_cc1 -fblocks -analyzer-checker=osx.cocoa.UnusedIvars -verify -Wno-objc-root-class %s
|
|
|
|
//===--- BEGIN: Delta-debugging reduced headers. --------------------------===//
|
|
|
|
@protocol NSObject
|
|
- (id)retain;
|
|
- (oneway void)release;
|
|
@end
|
|
@interface NSObject <NSObject> {}
|
|
- (id)init;
|
|
+ (id)alloc;
|
|
@end
|
|
|
|
//===--- END: Delta-debugging reduced headers. ----------------------------===//
|
|
|
|
// This test case tests the basic functionality of the unused ivar test.
|
|
@interface TestA {
|
|
@private
|
|
int x; // expected-warning {{Instance variable 'x' in class 'TestA' is never used}}
|
|
}
|
|
@end
|
|
@implementation TestA @end
|
|
|
|
// This test case tests whether the unused ivar check handles blocks that
|
|
// reference an instance variable.
|
|
@interface TestB : NSObject {
|
|
@private
|
|
id _ivar; // no-warning
|
|
}
|
|
@property (readwrite,retain) id ivar;
|
|
@end
|
|
|
|
@implementation TestB
|
|
- (id)ivar {
|
|
__attribute__((__blocks__(byref))) id value = ((void*)0);
|
|
void (^b)(void) = ^{ value = _ivar; };
|
|
b();
|
|
return value;
|
|
}
|
|
|
|
- (void)setIvar:(id)newValue {
|
|
void (^b)(void) = ^{ [_ivar release]; _ivar = [newValue retain]; };
|
|
b();
|
|
}
|
|
@end
|
|
|
|
// Confirm that the checker respects [[clang::suppress]].
|
|
@interface TestC {
|
|
@private
|
|
[[clang::suppress]] int x; // no-warning
|
|
}
|
|
@end
|
|
@implementation TestC @end
|
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Detect that ivar is in use, if used in category in the same file as the
|
|
// implementation.
|
|
//===----------------------------------------------------------------------===//
|
|
@protocol Protocol6260004
|
|
- (id) getId;
|
|
@end
|
|
|
|
@interface RDar6260004 {
|
|
@private
|
|
id x; // no-warning
|
|
}
|
|
@end
|
|
@implementation RDar6260004 @end
|
|
@implementation RDar6260004 (Protocol6260004)
|
|
- (id) getId {
|
|
return x;
|
|
}
|
|
@end
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// ivars referenced by lexically nested functions should not be flagged as
|
|
// unused
|
|
//===----------------------------------------------------------------------===//
|
|
@interface RDar7254495 {
|
|
@private
|
|
int x; // no-warning
|
|
}
|
|
@end
|
|
|
|
@implementation RDar7254495
|
|
int radar_7254495(RDar7254495 *a) {
|
|
return a->x;
|
|
}
|
|
@end
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Consult attribute((unused)) to silence warnings about unused instance
|
|
// variables.
|
|
//===----------------------------------------------------------------------===//
|
|
@interface RDar7353683 {
|
|
@private
|
|
id x __attribute__((unused));
|
|
}
|
|
@end
|
|
|
|
@implementation RDar7353683
|
|
@end
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Unused bitfield ivars trigger cause weird diagnostic:
|
|
// "Instance variable '' in class..."
|
|
//===----------------------------------------------------------------------===//
|
|
@interface RDar8481311 {
|
|
@private
|
|
unsigned bitfield:1; // expected-warning {{Instance variable 'bitfield' in class 'RDar8481311' is never used}}
|
|
}
|
|
@end
|
|
|
|
@implementation RDar8481311
|
|
@end
|
|
|
|
@class NSString;
|
|
@interface Radar11059352_1 {
|
|
@private
|
|
NSString *_pathString;
|
|
}
|
|
@property (readonly, strong) NSString *pathString;
|
|
@end
|
|
|
|
@interface Radar11059352 {
|
|
@private
|
|
Radar11059352_1 *_workspacePath;
|
|
}
|
|
@end
|
|
|
|
@implementation Radar11059352
|
|
|
|
- (void)useWorkspace {
|
|
NSString *workspacePathString = _workspacePath.pathString;
|
|
}
|
|
@end
|