mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-17 02:26:38 +00:00
ffe7950ebc
I'm trying to remove unused options from the `Analyses.def` file, then merge the rest of the useful options into the `AnalyzerOptions.def`. Then make sure one can set these by an `-analyzer-config XXX=YYY` style flag. Then surface the `-analyzer-config` to the `clang` frontend; After all of this, we can pursue the tablegen approach described https://discourse.llvm.org/t/rfc-tablegen-clang-static-analyzer-engine-options-for-better-documentation/61488 In this patch, I'm proposing flag deprecations. We should support deprecated analyzer flags for exactly one release. In this case I'm planning to drop this flag in `clang-16`. In the clang frontend, now we won't pass this option to the cc1 frontend, rather emit a warning diagnostic reminding the users about this deprecated flag, which will be turned into error in clang-16. Unfortunately, I had to remove all the tests referring to this flag, causing a mass change. I've also added a test for checking this warning. I've seen that `scan-build` also uses this flag, but I think we should remove that part only after we turn this into a hard error. Reviewed By: martong Differential Revision: https://reviews.llvm.org/D126215
50 lines
1.7 KiB
C
50 lines
1.7 KiB
C
// RUN: %clang_analyze_cc1 -triple x86_64-pc-linux-gnu -analyzer-checker=core,valist.Uninitialized,valist.CopyToSelf -analyzer-output=text -verify %s
|
|
|
|
#include "Inputs/system-header-simulator-for-valist.h"
|
|
|
|
// This is called in call_inlined_uses_arg(),
|
|
// and the warning is generated during the analysis of call_inlined_uses_arg().
|
|
void inlined_uses_arg(va_list arg) {
|
|
(void)va_arg(arg, int); // expected-warning{{va_arg() is called on an uninitialized va_list}}
|
|
// expected-note@-1{{va_arg() is called on an uninitialized va_list}}
|
|
}
|
|
|
|
void call_inlined_uses_arg(int fst, ...) {
|
|
va_list va;
|
|
inlined_uses_arg(va); // expected-note{{Calling 'inlined_uses_arg'}}
|
|
}
|
|
|
|
void f6(va_list *fst, ...) {
|
|
va_start(*fst, fst);
|
|
(void)va_arg(*fst, int);
|
|
va_end(*fst);
|
|
}
|
|
|
|
int va_list_get_int(va_list *va) {
|
|
return va_arg(*va, int); // no-warning
|
|
}
|
|
|
|
struct MyVaList {
|
|
va_list l;
|
|
};
|
|
int va_list_get_int2(struct MyVaList *va) {
|
|
return va_arg(va->l, int); // no-warning
|
|
}
|
|
|
|
void call_vprintf_bad(int isstring, ...) {
|
|
va_list va;
|
|
vprintf(isstring ? "%s" : "%d", va); // expected-warning{{Function 'vprintf' is called with an uninitialized va_list argument}}
|
|
// expected-note@-1{{Function 'vprintf' is called with an uninitialized va_list argument}}
|
|
// expected-note@-2{{Assuming 'isstring' is 0}}
|
|
// expected-note@-3{{'?' condition is false}}
|
|
}
|
|
|
|
void call_vsprintf_bad(char *buffer, ...) {
|
|
va_list va;
|
|
va_start(va, buffer); // expected-note{{Initialized va_list}}
|
|
va_end(va); // expected-note{{Ended va_list}}
|
|
vsprintf(buffer, "%s %d %d %lf %03d", va); // expected-warning{{Function 'vsprintf' is called with an uninitialized va_list argument}}
|
|
// expected-note@-1{{Function 'vsprintf' is called with an uninitialized va_list argument}}
|
|
}
|
|
|