mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-18 14:16:44 +00:00

This reverts commit 52aeacfbf5ce5f949efe0eae029e56db171ea1f7. There isn't full agreement on a path forward yet, but there is agreement that this shouldn't land as-is. See discussion on https://reviews.llvm.org/D105338 Also reverts unreviewed "[clang] Improve `-Wnull-dereference` diag to be more in-line with reality" This reverts commit f4877c78c0fc98be47b926439bbfe33d5e1d1b6d. And all the related changes to tests: This reverts commit 9a0152799f8e4a59e0483728c9f11c8a7805616f. This reverts commit 3f7c9cc27422f7302cf5a683eeb3978e6cb84270. This reverts commit 329f8197ef59f9bd23328b52d623ba768b51dbb2. This reverts commit aa9f58cc2c48ca6cfc853a2467cd775dc7622746. This reverts commit 2df37d5ddd38091aafbb7d338660e58836f4ac80. This reverts commit a72a44181264fd83e05be958c2712cbd4560aba7.
189 lines
5.5 KiB
C
189 lines
5.5 KiB
C
// RUN: %clang_analyze_cc1 -triple hexagon-unknown-linux -verify %s \
|
|
// RUN: -analyzer-checker=core,valist.Uninitialized,valist.CopyToSelf \
|
|
// RUN: -analyzer-disable-checker=core.CallAndMessage \
|
|
// RUN: -analyzer-output=text
|
|
//
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-pc-linux-gnu -verify %s \
|
|
// RUN: -analyzer-checker=core,valist.Uninitialized,valist.CopyToSelf \
|
|
// RUN: -analyzer-disable-checker=core.CallAndMessage \
|
|
// RUN: -analyzer-output=text
|
|
//
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-pc-linux-gnu %s \
|
|
// RUN: -analyzer-checker=core,valist.Uninitialized
|
|
|
|
#include "Inputs/system-header-simulator-for-valist.h"
|
|
|
|
void f1(int fst, ...) {
|
|
va_list va;
|
|
(void)va_arg(va, int); // expected-warning{{va_arg() is called on an uninitialized va_list}}
|
|
// expected-note@-1{{va_arg() is called on an uninitialized va_list}}
|
|
}
|
|
|
|
int f2(int fst, ...) {
|
|
va_list va;
|
|
va_start(va, fst); // expected-note{{Initialized va_list}}
|
|
va_end(va); // expected-note{{Ended va_list}}
|
|
return va_arg(va, int); // expected-warning{{va_arg() is called on an uninitialized va_list}}
|
|
// expected-note@-1{{va_arg() is called on an uninitialized va_list}}
|
|
}
|
|
|
|
void f3(int fst, ...) {
|
|
va_list va, va2;
|
|
va_start(va, fst);
|
|
va_copy(va2, va);
|
|
va_end(va);
|
|
(void)va_arg(va2, int);
|
|
va_end(va2);
|
|
} //no-warning
|
|
|
|
void f4(int cond, ...) {
|
|
va_list va;
|
|
if (cond) { // expected-note{{Assuming 'cond' is 0}}
|
|
// expected-note@-1{{Taking false branch}}
|
|
va_start(va, cond);
|
|
(void)va_arg(va,int);
|
|
}
|
|
va_end(va); //expected-warning{{va_end() is called on an uninitialized va_list}}
|
|
// expected-note@-1{{va_end() is called on an uninitialized va_list}}
|
|
}
|
|
|
|
void f5(va_list fst, ...) {
|
|
va_start(fst, fst);
|
|
(void)va_arg(fst, int);
|
|
va_end(fst);
|
|
} // no-warning
|
|
|
|
void f7(int *fst, ...) {
|
|
va_list x;
|
|
va_list *y = &x;
|
|
va_start(*y,fst);
|
|
(void)va_arg(x, int);
|
|
va_end(x);
|
|
} // no-warning
|
|
|
|
void f8(int *fst, ...) {
|
|
va_list x;
|
|
va_list *y = &x;
|
|
va_start(*y,fst); // expected-note{{Initialized va_list}}
|
|
va_end(x); // expected-note{{Ended va_list}}
|
|
(void)va_arg(*y, int); //expected-warning{{va_arg() is called on an uninitialized va_list}}
|
|
// expected-note@-1{{va_arg() is called on an uninitialized va_list}}
|
|
}
|
|
|
|
// This only contains problems which are handled by varargs.Unterminated.
|
|
void reinit(int *fst, ...) {
|
|
va_list va;
|
|
va_start(va, fst);
|
|
va_start(va, fst);
|
|
(void)va_arg(va, int);
|
|
} // no-warning
|
|
|
|
void reinitOk(int *fst, ...) {
|
|
va_list va;
|
|
va_start(va, fst);
|
|
(void)va_arg(va, int);
|
|
va_end(va);
|
|
va_start(va, fst);
|
|
(void)va_arg(va, int);
|
|
va_end(va);
|
|
} // no-warning
|
|
|
|
void reinit3(int *fst, ...) {
|
|
va_list va;
|
|
va_start(va, fst); // expected-note{{Initialized va_list}}
|
|
(void)va_arg(va, int);
|
|
va_end(va); // expected-note{{Ended va_list}}
|
|
va_start(va, fst); // expected-note{{Initialized va_list}}
|
|
(void)va_arg(va, int);
|
|
va_end(va); // expected-note{{Ended va_list}}
|
|
(void)va_arg(va, int); //expected-warning{{va_arg() is called on an uninitialized va_list}}
|
|
// expected-note@-1{{va_arg() is called on an uninitialized va_list}}
|
|
}
|
|
|
|
void copyself(int fst, ...) {
|
|
va_list va;
|
|
va_start(va, fst); // expected-note{{Initialized va_list}}
|
|
va_copy(va, va); // expected-warning{{va_list 'va' is copied onto itself}}
|
|
// expected-note@-1{{va_list 'va' is copied onto itself}}
|
|
va_end(va);
|
|
}
|
|
|
|
void copyselfUninit(int fst, ...) {
|
|
va_list va;
|
|
va_copy(va, va); // expected-warning{{va_list 'va' is copied onto itself}}
|
|
// expected-note@-1{{va_list 'va' is copied onto itself}}
|
|
}
|
|
|
|
void copyOverwrite(int fst, ...) {
|
|
va_list va, va2;
|
|
va_start(va, fst); // expected-note{{Initialized va_list}}
|
|
va_copy(va, va2); // expected-warning{{Initialized va_list 'va' is overwritten by an uninitialized one}}
|
|
// expected-note@-1{{Initialized va_list 'va' is overwritten by an uninitialized one}}
|
|
}
|
|
|
|
void copyUnint(int fst, ...) {
|
|
va_list va, va2;
|
|
va_copy(va, va2); // expected-warning{{Uninitialized va_list is copied}}
|
|
// expected-note@-1{{Uninitialized va_list is copied}}
|
|
}
|
|
|
|
void g1(int fst, ...) {
|
|
va_list va;
|
|
va_end(va); // expected-warning{{va_end() is called on an uninitialized va_list}}
|
|
// expected-note@-1{{va_end() is called on an uninitialized va_list}}
|
|
}
|
|
|
|
void g2(int fst, ...) {
|
|
va_list va;
|
|
va_start(va, fst); // expected-note{{Initialized va_list}}
|
|
va_end(va); // expected-note{{Ended va_list}}
|
|
va_end(va); // expected-warning{{va_end() is called on an uninitialized va_list}}
|
|
// expected-note@-1{{va_end() is called on an uninitialized va_list}}
|
|
}
|
|
|
|
void is_sink(int fst, ...) {
|
|
va_list va;
|
|
va_end(va); // expected-warning{{va_end() is called on an uninitialized va_list}}
|
|
// expected-note@-1{{va_end() is called on an uninitialized va_list}}
|
|
*((volatile int *)0) = 1;
|
|
}
|
|
|
|
// NOTE: this is invalid, as the man page of va_end requires that "Each invocation of va_start()
|
|
// must be matched by a corresponding invocation of va_end() in the same function."
|
|
void ends_arg(va_list arg) {
|
|
va_end(arg);
|
|
} //no-warning
|
|
|
|
void uses_arg(va_list arg) {
|
|
(void)va_arg(arg, int);
|
|
} //no-warning
|
|
|
|
void call_vprintf_ok(int isstring, ...) {
|
|
va_list va;
|
|
va_start(va, isstring);
|
|
vprintf(isstring ? "%s" : "%d", va);
|
|
va_end(va);
|
|
} //no-warning
|
|
|
|
void call_some_other_func(int n, ...) {
|
|
va_list va;
|
|
some_library_function(n, va);
|
|
} //no-warning
|
|
|
|
void inlined_uses_arg_good(va_list arg) {
|
|
(void)va_arg(arg, int);
|
|
}
|
|
|
|
void call_inlined_uses_arg_good(int fst, ...) {
|
|
va_list va;
|
|
va_start(va, fst);
|
|
inlined_uses_arg_good(va);
|
|
va_end(va);
|
|
}
|
|
|
|
void va_copy_test(va_list arg) {
|
|
va_list dst;
|
|
va_copy(dst, arg);
|
|
va_end(dst);
|
|
}
|