mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-04-23 23:46:05 +00:00
Code Issues Projects Releases Wiki Activity
llvm-project/clang/test/CodeGenObjC/arc-precise-lifetime.m
Aaron Ballman 0f1c1be196 [clang] Remove rdar links; NFC 
We have a new policy in place making links to private resources
something we try to avoid in source and test files. Normally, we'd
organically switch to the new policy rather than make a sweeping change
across a project. However, Clang is in a somewhat special circumstance
currently: recently, I've had several new contributors run into rdar
links around test code which their patch was changing the behavior of.
This turns out to be a surprisingly bad experience, especially for
newer folks, for a handful of reasons: not understanding what the link
is and feeling intimidated by it, wondering whether their changes are
actually breaking something important to a downstream in some way,
having to hunt down strangers not involved with the patch to impose on
them for help, accidental pressure from asking for potentially private
IP to be made public, etc. Because folks run into these links entirely
by chance (through fixing bugs or working on new features), there's not
really a set of problematic links to focus on -- all of the links have
basically the same potential for causing these problems. As a result,
this is an omnibus patch to remove all such links.

This was not a mechanical change; it was done by manually searching for
rdar, radar, radr, and other variants to find all the various
problematic links. From there, I tried to retain or reword the
surrounding comments so that we would lose as little context as
possible. However, because most links were just a plain link with no
supporting context, the majority of the changes are simple removals.

Differential Review: https://reviews.llvm.org/D158071
2023-08-28 12:13:42 -04:00

260 lines
12 KiB
Objective-C
Raw Permalink Blame History

// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -emit-llvm -fblocks -fobjc-arc -fobjc-runtime-has-weak -O2 -disable-llvm-passes -o - %s | FileCheck %s
#define PRECISE_LIFETIME __attribute__((objc_precise_lifetime))
id test0_helper(void) __attribute__((ns_returns_retained));
void test0(void) {
PRECISE_LIFETIME id x = test0_helper();
x = 0;
// CHECK: [[X:%.*]] = alloca ptr
// CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 8, ptr [[X]])
// CHECK-NEXT: [[CALL:%.*]] = call ptr @test0_helper()
// CHECK-NEXT: store ptr [[CALL]], ptr [[X]]
// CHECK-NEXT: [[T1:%.*]] = load ptr, ptr [[X]]
// CHECK-NEXT: store ptr null, ptr [[X]]
// CHECK-NEXT: call void @llvm.objc.release(ptr [[T1]]) [[NUW:#[0-9]+]]
// CHECK-NOT: clang.imprecise_release
// CHECK-NEXT: [[T1:%.*]] = load ptr, ptr [[X]]
// CHECK-NEXT: call void @llvm.objc.release(ptr [[T1]]) [[NUW:#[0-9]+]]
// CHECK-NOT: clang.imprecise_release
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[X]])
// CHECK-NEXT: ret void
}
// precise lifetime should suppress extension
// should work for calls via property syntax, too
@interface Test1
- (char*) interior __attribute__((objc_returns_inner_pointer));
// Should we allow this on properties? Yes!
@property (nonatomic, readonly) char * PropertyReturnsInnerPointer __attribute__((objc_returns_inner_pointer));
@end
extern Test1 *test1_helper(void);
// CHECK-LABEL: define{{.*}} void @test1a_message()
void test1a_message(void) {
// CHECK: [[PTR:%.*]] = alloca ptr, align 8
// CHECK: [[C:%.*]] = alloca ptr, align 8
// CHECK: call void @llvm.lifetime.start.p0(i64 8, ptr [[PTR]])
// CHECK: [[T0:%.*]] = call ptr @test1_helper() [ "clang.arc.attachedcall"(ptr @llvm.objc.retainAutoreleasedReturnValue) ]
// CHECK-NEXT: call void (...) @llvm.objc.clang.arc.noop.use(ptr [[T0]])
// CHECK-NEXT: store ptr [[T0]]
// CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 8, ptr [[C]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: [[T2:%.*]] = call ptr @llvm.objc.retainAutorelease(ptr [[T0]])
// CHECK-NEXT: [[T4:%.*]] = load ptr, ptr @OBJC_SELECTOR_REFERENCES_
// CHECK-NEXT: [[T6:%.*]] = call ptr
// CHECK-NEXT: store ptr [[T6]], ptr
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[C]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: call void @llvm.objc.release(ptr [[T0]]) [[NUW]], !clang.imprecise_release
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[PTR]])
// CHECK-NEXT: ret void
Test1 *ptr = test1_helper();
char *c = [(ptr) interior];
}
// CHECK-LABEL: define{{.*}} void @test1a_property()
void test1a_property(void) {
// CHECK: [[PTR:%.*]] = alloca ptr, align 8
// CHECK: [[C:%.*]] = alloca ptr, align 8
// CHECK: call void @llvm.lifetime.start.p0(i64 8, ptr [[PTR]])
// CHECK: [[T0:%.*]] = call ptr @test1_helper() [ "clang.arc.attachedcall"(ptr @llvm.objc.retainAutoreleasedReturnValue) ]
// CHECK-NEXT: call void (...) @llvm.objc.clang.arc.noop.use(ptr [[T0]])
// CHECK-NEXT: store ptr [[T0]]
// CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 8, ptr [[C]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: [[T2:%.*]] = call ptr @llvm.objc.retainAutorelease(ptr [[T0]])
// CHECK-NEXT: [[T4:%.*]] = load ptr, ptr @OBJC_SELECTOR_REFERENCES_
// CHECK-NEXT: [[T6:%.*]] = call ptr
// CHECK-NEXT: store ptr [[T6]], ptr
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[C]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: call void @llvm.objc.release(ptr [[T0]]) [[NUW]], !clang.imprecise_release
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[PTR]])
// CHECK-NEXT: ret void
Test1 *ptr = test1_helper();
char *c = ptr.interior;
}
// CHECK-LABEL: define{{.*}} void @test1b_message()
void test1b_message(void) {
// CHECK: [[PTR:%.*]] = alloca ptr, align 8
// CHECK: [[C:%.*]] = alloca ptr, align 8
// CHECK: call void @llvm.lifetime.start.p0(i64 8, ptr [[PTR]])
// CHECK: [[T0:%.*]] = call ptr @test1_helper() [ "clang.arc.attachedcall"(ptr @llvm.objc.retainAutoreleasedReturnValue) ]
// CHECK-NEXT: call void (...) @llvm.objc.clang.arc.noop.use(ptr [[T0]])
// CHECK-NEXT: store ptr [[T0]]
// CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 8, ptr [[C]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: [[T1:%.*]] = load ptr, ptr @OBJC_SELECTOR_REFERENCES_
// CHECK-NEXT: [[T3:%.*]] = call ptr
// CHECK-NEXT: store ptr [[T3]], ptr
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[C]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: call void @llvm.objc.release(ptr [[T0]]) [[NUW]]
// CHECK-NOT: clang.imprecise_release
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[PTR]])
// CHECK-NEXT: ret void
PRECISE_LIFETIME Test1 *ptr = test1_helper();
char *c = [ptr interior];
}
// CHECK-LABEL: define{{.*}} void @test1b_property()
void test1b_property(void) {
// CHECK: [[PTR:%.*]] = alloca ptr, align 8
// CHECK: [[C:%.*]] = alloca ptr, align 8
// CHECK: call void @llvm.lifetime.start.p0(i64 8, ptr [[PTR]])
// CHECK: [[T0:%.*]] = call ptr @test1_helper() [ "clang.arc.attachedcall"(ptr @llvm.objc.retainAutoreleasedReturnValue) ]
// CHECK-NEXT: call void (...) @llvm.objc.clang.arc.noop.use(ptr [[T0]])
// CHECK-NEXT: store ptr [[T0]]
// CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 8, ptr [[C]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: [[T1:%.*]] = load ptr, ptr @OBJC_SELECTOR_REFERENCES_
// CHECK-NEXT: [[T3:%.*]] = call ptr
// CHECK-NEXT: store ptr [[T3]], ptr
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[C]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: call void @llvm.objc.release(ptr [[T0]]) [[NUW]]
// CHECK-NOT: clang.imprecise_release
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[PTR]])
// CHECK-NEXT: ret void
PRECISE_LIFETIME Test1 *ptr = test1_helper();
char *c = ptr.interior;
}
// CHECK-LABEL: define{{.*}} void @test1c_message()
void test1c_message(void) {
// CHECK: [[PTR:%.*]] = alloca ptr, align 8
// CHECK: [[PC:%.*]] = alloca ptr, align 8
// CHECK: call void @llvm.lifetime.start.p0(i64 8, ptr [[PTR]])
// CHECK: [[T0:%.*]] = call ptr @test1_helper() [ "clang.arc.attachedcall"(ptr @llvm.objc.retainAutoreleasedReturnValue) ]
// CHECK-NEXT: call void (...) @llvm.objc.clang.arc.noop.use(ptr [[T0]])
// CHECK-NEXT: store ptr [[T0]]
// CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 8, ptr [[PC]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: [[T2:%.*]] = call ptr @llvm.objc.retainAutorelease(ptr [[T0]])
// CHECK-NEXT: [[T4:%.*]] = load ptr, ptr @OBJC_SELECTOR_REFERENCES_
// CHECK-NEXT: [[T6:%.*]] = call ptr
// CHECK-NEXT: store ptr [[T6]], ptr
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[PC]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: call void @llvm.objc.release(ptr [[T0]]) [[NUW]], !clang.imprecise_release
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[PTR]])
// CHECK-NEXT: ret void
Test1 *ptr = test1_helper();
char *pc = [ptr PropertyReturnsInnerPointer];
}
// CHECK-LABEL: define{{.*}} void @test1c_property()
void test1c_property(void) {
// CHECK: [[PTR:%.*]] = alloca ptr, align 8
// CHECK: [[PC:%.*]] = alloca ptr, align 8
// CHECK: call void @llvm.lifetime.start.p0(i64 8, ptr [[PTR]])
// CHECK: [[T0:%.*]] = call ptr @test1_helper() [ "clang.arc.attachedcall"(ptr @llvm.objc.retainAutoreleasedReturnValue) ]
// CHECK-NEXT: call void (...) @llvm.objc.clang.arc.noop.use(ptr [[T0]])
// CHECK-NEXT: store ptr [[T0]]
// CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 8, ptr [[PC]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: [[T2:%.*]] = call ptr @llvm.objc.retainAutorelease(ptr [[T0]])
// CHECK-NEXT: [[T4:%.*]] = load ptr, ptr @OBJC_SELECTOR_REFERENCES_
// CHECK-NEXT: [[T6:%.*]] = call ptr
// CHECK-NEXT: store ptr [[T6]], ptr
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[PC]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: call void @llvm.objc.release(ptr [[T0]]) [[NUW]], !clang.imprecise_release
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[PTR]])
// CHECK-NEXT: ret void
Test1 *ptr = test1_helper();
char *pc = ptr.PropertyReturnsInnerPointer;
}
// CHECK-LABEL: define{{.*}} void @test1d_message()
void test1d_message(void) {
// CHECK: [[PTR:%.*]] = alloca ptr, align 8
// CHECK: [[PC:%.*]] = alloca ptr, align 8
// CHECK: call void @llvm.lifetime.start.p0(i64 8, ptr [[PTR]])
// CHECK: [[T0:%.*]] = call ptr @test1_helper() [ "clang.arc.attachedcall"(ptr @llvm.objc.retainAutoreleasedReturnValue) ]
// CHECK-NEXT: call void (...) @llvm.objc.clang.arc.noop.use(ptr [[T0]])
// CHECK-NEXT: store ptr [[T0]]
// CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 8, ptr [[PC]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: [[SEL:%.*]] = load ptr, ptr @OBJC_SELECTOR_REFERENCES_
// CHECK-NEXT: [[CALL1:%.*]] = call ptr @objc_msgSend(ptr noundef [[T0]], ptr noundef [[SEL]])
// CHECK-NEXT: store ptr [[CALL1]], ptr
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[PC]])
// CHECK-NEXT: [[NINE:%.*]] = load ptr, ptr
// CHECK-NEXT: call void @llvm.objc.release(ptr [[NINE]])
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[PTR]])
// CHECK-NEXT: ret void
PRECISE_LIFETIME Test1 *ptr = test1_helper();
char *pc = [ptr PropertyReturnsInnerPointer];
}
// CHECK-LABEL: define{{.*}} void @test1d_property()
void test1d_property(void) {
// CHECK: [[PTR:%.*]] = alloca ptr, align 8
// CHECK: [[PC:%.*]] = alloca ptr, align 8
// CHECK: call void @llvm.lifetime.start.p0(i64 8, ptr [[PTR]])
// CHECK: [[T0:%.*]] = call ptr @test1_helper() [ "clang.arc.attachedcall"(ptr @llvm.objc.retainAutoreleasedReturnValue) ]
// CHECK-NEXT: call void (...) @llvm.objc.clang.arc.noop.use(ptr [[T0]])
// CHECK-NEXT: store ptr [[T0]]
// CHECK-NEXT: call void @llvm.lifetime.start.p0(i64 8, ptr [[PC]])
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr
// CHECK-NEXT: [[SEL:%.*]] = load ptr, ptr @OBJC_SELECTOR_REFERENCES_
// CHECK-NEXT: [[CALL1:%.*]] = call ptr @objc_msgSend(ptr noundef [[T0]], ptr noundef [[SEL]])
// CHECK-NEXT: store ptr [[CALL1]], ptr
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[PC]])
// CHECK-NEXT: [[NINE:%.*]] = load ptr, ptr
// CHECK-NEXT: call void @llvm.objc.release(ptr [[NINE]])
// CHECK-NEXT: call void @llvm.lifetime.end.p0(i64 8, ptr [[PTR]])
// CHECK-NEXT: ret void
PRECISE_LIFETIME Test1 *ptr = test1_helper();
char *pc = ptr.PropertyReturnsInnerPointer;
}
@interface Test2 {
@public
id ivar;
}
@end
// CHECK-LABEL: define{{.*}} void @test2(
void test2(Test2 *x) {
x->ivar = 0;
// CHECK: [[X:%.*]] = alloca ptr
// CHECK-NEXT: [[T1:%.*]] = call ptr @llvm.objc.retain(ptr {{%.*}}) [[NUW]]
// CHECK-NEXT: store ptr [[T1]], ptr [[X]],
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr [[X]],
// CHECK-NEXT: [[OFFSET:%.*]] = load i64, ptr @"OBJC_IVAR_$_Test2.ivar"
// CHECK-NEXT: [[T2:%.*]] = getelementptr inbounds i8, ptr [[T0]], i64 [[OFFSET]]
// CHECK-NEXT: [[T4:%.*]] = load ptr, ptr [[T2]],
// CHECK-NEXT: store ptr null, ptr [[T2]],
// CHECK-NEXT: call void @llvm.objc.release(ptr [[T4]]) [[NUW]]
// CHECK-NOT: imprecise
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr [[X]]
// CHECK-NEXT: call void @llvm.objc.release(ptr [[T0]]) [[NUW]], !clang.imprecise_release
// CHECK-NEXT: ret void
}
// CHECK-LABEL: define{{.*}} void @test3(ptr
void test3(PRECISE_LIFETIME id x) {
// CHECK: [[X:%.*]] = alloca ptr,
// CHECK-NEXT: [[T0:%.*]] = call ptr @llvm.objc.retain(ptr {{%.*}}) [[NUW]]
// CHECK-NEXT: store ptr [[T0]], ptr [[X]],
// CHECK-NEXT: [[T0:%.*]] = load ptr, ptr [[X]]
// CHECK-NEXT: call void @llvm.objc.release(ptr [[T0]]) [[NUW]]
// CHECK-NOT: imprecise_release
// CHECK-NEXT: ret void
}
// CHECK: attributes [[NUW]] = { nounwind }
Reference in New Issue View Git Blame Copy Permalink