mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 11:56:08 +00:00

Instead of diagnosing non-literal types in C++23, allow them and later diagnose them differently, e.g. because they have a non-constexpr constructor, destructor, etc. For this test: ```c++ struct NonLiteral { NonLiteral() {} }; constexpr int foo() { NonLiteral L; return 1; } // static_assert(foo() == 1); ``` The current diagnostics with c++20/c++23 are: ```console ~/code/llvm-project/build » clang -c array.cpp -std=c++20 array.cpp:91:14: error: variable of non-literal type 'NonLiteral' cannot be defined in a constexpr function before C++23 91 | NonLiteral L; | ^ array.cpp:87:8: note: 'NonLiteral' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors 87 | struct NonLiteral { | ^ 1 error generated. ------------------------------------------------------------ ~/code/llvm-project/build » clang -c array.cpp -std=c++23 (no output) ``` With the `static_assert` enabled, compiling with `-std=c++23` prints: ```console array.cpp:95:15: error: static assertion expression is not an integral constant expression 95 | static_assert(foo() == 1); | ^~~~~~~~~~ array.cpp:91:14: note: non-literal type 'NonLiteral' cannot be used in a constant expression 91 | NonLiteral L; | ^ array.cpp:95:15: note: in call to 'foo()' 95 | static_assert(foo() == 1); | ^~~~~ 1 error generated. ``` As mentioned in #60311, this is confusing. The output with c++20 suggests that using c++23 will make the problem go away, but it's diagnosed the same when running the function. With this commit, the output instead diagnoses _why_ the non-literal type can't be used: ```console array.cpp:95:15: error: static assertion expression is not an integral constant expression 95 | static_assert(foo() == 1); | ^~~~~~~~~~ array.cpp:91:14: note: non-constexpr constructor 'NonLiteral' cannot be used in a constant expression 91 | NonLiteral L; | ^ array.cpp:95:15: note: in call to 'foo()' 95 | static_assert(foo() == 1); | ^~~~~ array.cpp:88:3: note: declared here 88 | NonLiteral() {} | ^ 1 error generated. ``` Fixes #60311
257 lines
11 KiB
C++
257 lines
11 KiB
C++
// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify=expected,cxx2a %s -fcxx-exceptions -triple=x86_64-linux-gnu -Wno-c++23-extensions
|
|
// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify=expected,cxx23 %s -fcxx-exceptions -triple=x86_64-linux-gnu -Wpre-c++23-compat
|
|
|
|
struct NonLiteral { // cxx2a-note {{'NonLiteral' is not literal}} \
|
|
// cxx23-note 2{{'NonLiteral' is not literal}}
|
|
NonLiteral() {} // cxx23-note 2{{declared here}}
|
|
};
|
|
|
|
struct Constexpr{};
|
|
|
|
#if __cplusplus > 202002L
|
|
|
|
constexpr int f(int n) { // cxx2a-error {{constexpr function never produces a constant expression}}
|
|
static const int m = n; // cxx2a-note {{control flows through the definition of a static variable}} \
|
|
// cxx23-warning {{definition of a static variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
return m;
|
|
}
|
|
constexpr int g(int n) { // cxx2a-error {{constexpr function never produces a constant expression}}
|
|
thread_local const int m = n; // cxx2a-note {{control flows through the definition of a thread_local variable}} \
|
|
// cxx23-warning {{definition of a thread_local variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
return m;
|
|
}
|
|
|
|
constexpr int c_thread_local(int n) { // cxx2a-error {{constexpr function never produces a constant expression}}
|
|
static _Thread_local int m = 0; // cxx2a-note {{control flows through the definition of a thread_local variable}} \
|
|
// cxx23-warning {{definition of a static variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
return m;
|
|
}
|
|
|
|
constexpr int gnu_thread_local(int n) { // cxx2a-error {{constexpr function never produces a constant expression}}
|
|
static __thread int m = 0; // cxx2a-note {{control flows through the definition of a thread_local variable}} \
|
|
// cxx23-warning {{definition of a static variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
return m;
|
|
}
|
|
|
|
constexpr int h(int n) { // cxx2a-error {{constexpr function never produces a constant expression}}
|
|
static const int m = n; // cxx2a-note {{control flows through the definition of a static variable}} \
|
|
// cxx23-warning {{definition of a static variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
return &m - &m;
|
|
}
|
|
constexpr int i(int n) { // cxx2a-error {{constexpr function never produces a constant expression}}
|
|
thread_local const int m = n; // cxx2a-note {{control flows through the definition of a thread_local variable}} \
|
|
// cxx23-warning {{definition of a thread_local variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
return &m - &m;
|
|
}
|
|
|
|
constexpr int j(int n) {
|
|
if (!n)
|
|
return 0;
|
|
static const int m = n; // cxx23-warning {{definition of a static variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
return m;
|
|
}
|
|
constexpr int j0 = j(0);
|
|
|
|
constexpr int k(int n) {
|
|
if (!n)
|
|
return 0;
|
|
thread_local const int m = n; // cxx23-warning {{definition of a thread_local variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
|
|
return m;
|
|
}
|
|
constexpr int k0 = k(0);
|
|
|
|
constexpr int j_evaluated(int n) {
|
|
if (!n)
|
|
return 0;
|
|
static const int m = n; // expected-note {{control flows through the definition of a static variable}} \
|
|
// cxx23-warning {{definition of a static variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
return m;
|
|
}
|
|
|
|
constexpr int je = j_evaluated(1); // expected-error {{constexpr variable 'je' must be initialized by a constant expression}} \
|
|
// expected-note {{in call}}
|
|
|
|
constexpr int k_evaluated(int n) {
|
|
if (!n)
|
|
return 0;
|
|
thread_local const int m = n; // expected-note {{control flows through the definition of a thread_local variable}} \
|
|
// cxx23-warning {{definition of a thread_local variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
|
|
return m;
|
|
}
|
|
|
|
constexpr int ke = k_evaluated(1); // expected-error {{constexpr variable 'ke' must be initialized by a constant expression}} \
|
|
// expected-note {{in call}}
|
|
|
|
constexpr int static_constexpr() {
|
|
static constexpr int m = 42; // cxx23-warning {{definition of a static variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
static constexpr Constexpr foo; // cxx23-warning {{definition of a static variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
return m;
|
|
}
|
|
|
|
constexpr int thread_local_constexpr() {
|
|
thread_local constexpr int m = 42; // cxx23-warning {{definition of a thread_local variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
thread_local constexpr Constexpr foo; // cxx23-warning {{definition of a thread_local variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
return m;
|
|
}
|
|
|
|
constexpr int non_literal(bool b) {
|
|
if (!b)
|
|
return 0;
|
|
NonLiteral n; // cxx23-warning {{definition of a variable of non-literal type in a constexpr function is incompatible with C++ standards before C++23}}
|
|
}
|
|
|
|
constexpr int non_literal_1 = non_literal(false);
|
|
|
|
namespace eval_goto {
|
|
|
|
constexpr int f(int x) {
|
|
if (x) {
|
|
return 0;
|
|
} else {
|
|
goto test; // expected-note {{subexpression not valid in a constant expression}} \
|
|
// cxx23-warning {{use of this statement in a constexpr function is incompatible with C++ standards before C++23}}
|
|
}
|
|
test:
|
|
return 0;
|
|
}
|
|
|
|
int a = f(0);
|
|
constexpr int b = f(0); // expected-error {{must be initialized by a constant expression}} \
|
|
// expected-note {{in call to 'f(0)'}}
|
|
constexpr int c = f(1);
|
|
|
|
constexpr int label() {
|
|
|
|
test: // cxx23-warning {{use of this statement in a constexpr function is incompatible with C++ standards before C++23}}
|
|
return 0;
|
|
}
|
|
|
|
constexpr int d = label();
|
|
|
|
} // namespace eval_goto
|
|
|
|
#endif
|
|
|
|
// Test that explicitly constexpr lambdas behave correctly,
|
|
// This is to be contrasted with the test for implicitly constexpr lambdas below.
|
|
int test_in_lambdas() {
|
|
auto a = []() constexpr {
|
|
static const int m = 32; // cxx23-warning {{definition of a static variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
return m;
|
|
};
|
|
|
|
auto b = [](int n) constexpr {
|
|
if (!n)
|
|
return 0;
|
|
static const int m = n; // cxx23-warning {{definition of a static variable in a constexpr function is incompatible with C++ standards before C++23}}
|
|
return m;
|
|
}
|
|
(1);
|
|
|
|
auto c = [](int n) constexpr {
|
|
if (!n)
|
|
return 0;
|
|
else
|
|
goto test; // expected-note {{subexpression not valid in a constant expression}} \
|
|
// cxx23-warning {{use of this statement in a constexpr function is incompatible with C++ standards before C++23}}
|
|
test:
|
|
return 1;
|
|
};
|
|
c(0);
|
|
constexpr auto c_error = c(1); // expected-error {{constexpr variable 'c_error' must be initialized by a constant expression}} \
|
|
// expected-note {{in call to}}
|
|
|
|
auto non_literal = [](bool b) constexpr {
|
|
if (!b)
|
|
NonLiteral n; // cxx2a-error {{variable of non-literal type 'NonLiteral' cannot be defined in a constexpr function before C++23}} \
|
|
// cxx23-warning {{definition of a variable of non-literal type in a constexpr function is incompatible with C++ standards before C++23}} \
|
|
// cxx23-note {{non-constexpr constructor 'NonLiteral' cannot be used in a constant expression}}
|
|
return 0;
|
|
};
|
|
|
|
#if __cplusplus > 202002L
|
|
constexpr auto non_literal_ko = non_literal(false); // cxx23-error {{constexpr variable 'non_literal_ko' must be initialized by a constant expression}} \
|
|
// cxx23-note {{in call}}
|
|
|
|
constexpr auto non_literal_ok = non_literal(true);
|
|
#endif
|
|
}
|
|
|
|
// Test whether lambdas are correctly treated as implicitly constexpr under the
|
|
// relaxed C++23 rules (and similarly as not implicitly constexpr under the
|
|
// C++20 rules).
|
|
int test_lambdas_implicitly_constexpr() {
|
|
|
|
auto b = [](int n) { // cxx2a-note 2{{declared here}}
|
|
if (!n)
|
|
return 0;
|
|
static const int m = n; // cxx23-note {{control flows through the definition of a static variable}}
|
|
return m;
|
|
};
|
|
|
|
auto b1 = b(1);
|
|
constexpr auto b2 = b(0); // cxx2a-error {{must be initialized by a constant expression}} \
|
|
// cxx2a-note {{non-constexpr function}}
|
|
|
|
constexpr auto b3 = b(1); // expected-error{{constexpr variable 'b3' must be initialized by a constant expression}} \
|
|
// cxx2a-note {{non-constexpr function}} \
|
|
// cxx23-note {{in call}}
|
|
|
|
auto c = [](int n) { // cxx2a-note 2{{declared here}}
|
|
if (!n)
|
|
return 0;
|
|
else
|
|
goto test; // cxx23-note {{subexpression not valid in a constant expression}}
|
|
test:
|
|
return 1;
|
|
};
|
|
c(0);
|
|
constexpr auto c_ok = c(0); // cxx2a-error {{must be initialized by a constant expression}} \
|
|
// cxx2a-note {{non-constexpr function}}
|
|
|
|
constexpr auto c_error = c(1); // expected-error {{constexpr variable 'c_error' must be initialized by a constant expression}} \
|
|
// cxx2a-note {{non-constexpr function}} \
|
|
// cxx23-note {{in call to}}
|
|
|
|
auto non_literal = [](bool b) { // cxx2a-note 2{{declared here}}
|
|
if (b)
|
|
NonLiteral n; // cxx23-note {{non-constexpr constructor 'NonLiteral' cannot be used in a constant expression}}
|
|
return 0;
|
|
};
|
|
|
|
constexpr auto non_literal_ko = non_literal(true); // expected-error {{constexpr variable 'non_literal_ko' must be initialized by a constant expression}} \
|
|
// cxx2a-note {{non-constexpr function}} \
|
|
// cxx23-note {{in call}}
|
|
|
|
constexpr auto non_literal_ok = non_literal(false); // cxx2a-error {{must be initialized by a constant expression}} \
|
|
// cxx2a-note {{non-constexpr function}}
|
|
}
|
|
|
|
template <typename T>
|
|
constexpr auto dependent_var_def_lambda() {
|
|
return [](bool b) { // cxx2a-note {{declared here}}
|
|
if (!b)
|
|
T t;
|
|
return 0;
|
|
};
|
|
}
|
|
|
|
constexpr auto non_literal_valid_in_cxx23 = dependent_var_def_lambda<NonLiteral>()(true); // \
|
|
// cxx2a-error {{constexpr variable 'non_literal_valid_in_cxx23' must be initialized by a constant expression}} \
|
|
// cxx2a-note {{non-constexpr function}}
|
|
|
|
|
|
constexpr double evaluate_static_constexpr() {
|
|
struct Constexpr{
|
|
constexpr double f() const {
|
|
return 42;
|
|
}
|
|
};
|
|
thread_local constexpr Constexpr t; // cxx23-warning {{before C++23}}
|
|
static constexpr Constexpr s; // cxx23-warning {{before C++23}}
|
|
return t.f() + s.f();
|
|
}
|
|
static_assert(evaluate_static_constexpr() == 84);
|