mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-18 09:06:43 +00:00

We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
124 lines
2.6 KiB
C++
124 lines
2.6 KiB
C++
// RUN: %clang_cc1 -std=c++11 -verify %s -Wno-deprecated-builtins
|
|
|
|
namespace rdar12240916 {
|
|
|
|
struct S2 {
|
|
S2(const S2&);
|
|
S2();
|
|
};
|
|
|
|
struct S { // expected-note {{not complete}}
|
|
S x; // expected-error {{incomplete type}}
|
|
S2 y;
|
|
};
|
|
|
|
S foo() {
|
|
S s;
|
|
return s;
|
|
}
|
|
|
|
struct S3; // expected-note {{forward declaration}}
|
|
|
|
struct S4 {
|
|
S3 x; // expected-error {{incomplete type}}
|
|
S2 y;
|
|
};
|
|
|
|
struct S3 {
|
|
S4 x;
|
|
S2 y;
|
|
};
|
|
|
|
S4 foo2() {
|
|
S4 s;
|
|
return s;
|
|
}
|
|
|
|
}
|
|
|
|
namespace rdar12542261 {
|
|
|
|
template <class _Tp>
|
|
struct check_complete
|
|
{
|
|
static_assert(sizeof(_Tp) > 0, "Type must be complete.");
|
|
};
|
|
|
|
|
|
template<class _Rp>
|
|
class function // expected-note 2 {{candidate}}
|
|
{
|
|
public:
|
|
template<class _Fp>
|
|
function(_Fp, typename check_complete<_Fp>::type* = 0); // expected-note {{candidate}}
|
|
};
|
|
|
|
void foobar()
|
|
{
|
|
auto LeftCanvas = new Canvas(); // expected-error {{unknown type name}}
|
|
function<void()> m_OnChange = [&, LeftCanvas]() { }; // expected-error {{no viable conversion}}
|
|
}
|
|
|
|
}
|
|
|
|
namespace b6981007 {
|
|
struct S {}; // expected-note 3{{candidate}}
|
|
void f() {
|
|
S s(1, 2, 3); // expected-error {{no matching}}
|
|
for (auto x : s) {
|
|
// We used to attempt to evaluate the initializer of this variable,
|
|
// and crash because it has an undeduced type.
|
|
const int &n(x);
|
|
constexpr int k = sizeof(x);
|
|
}
|
|
}
|
|
}
|
|
|
|
namespace incorrect_auto_type_deduction_for_typo {
|
|
struct S {
|
|
template <typename T> S(T t) {
|
|
(void)sizeof(t);
|
|
(void)new auto(t);
|
|
}
|
|
};
|
|
|
|
void Foo(S);
|
|
|
|
void test(int some_number) { // expected-note {{'some_number' declared here}}
|
|
auto x = sum_number; // expected-error {{use of undeclared identifier 'sum_number'; did you mean 'some_number'?}}
|
|
auto lambda = [x] {};
|
|
Foo(lambda);
|
|
}
|
|
}
|
|
|
|
namespace pr29091 {
|
|
struct X{ X(const X &x); };
|
|
struct Y: X { using X::X; };
|
|
bool foo() { return __has_nothrow_constructor(Y); }
|
|
bool bar() { return __has_nothrow_copy(Y); }
|
|
|
|
struct A { template <typename T> A(); };
|
|
struct B : A { using A::A; };
|
|
bool baz() { return __has_nothrow_constructor(B); }
|
|
bool qux() { return __has_nothrow_copy(B); }
|
|
}
|
|
|
|
namespace undeduced_field {
|
|
template<class T>
|
|
struct Foo {
|
|
typedef T type;
|
|
};
|
|
|
|
struct Bar {
|
|
Bar();
|
|
// The missing expression makes A undeduced.
|
|
static constexpr auto A = ; // expected-error {{expected expression}}
|
|
// expected-error@-1 {{declaration of variable 'A' with deduced type 'const auto' requires an initializer}}
|
|
|
|
Foo<decltype(A)>::type B; // The type of B is also undeduced (wrapped in Elaborated).
|
|
};
|
|
|
|
// This used to crash when trying to get the layout of B.
|
|
Bar x;
|
|
}
|