mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-17 05:36:41 +00:00

We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
122 lines
5.4 KiB
Objective-C
122 lines
5.4 KiB
Objective-C
// RUN: %clang_cc1 -triple x86_64-apple-darwin11 -fsyntax-only -fobjc-arc -fblocks -fobjc-runtime-has-weak -Wexplicit-ownership-type -verify -Wno-objc-root-class %s
|
|
// RUN: %clang_cc1 -x objective-c++ -triple x86_64-apple-darwin11 -fsyntax-only -fobjc-arc -fblocks -fobjc-runtime-has-weak -Wexplicit-ownership-type -verify -Wno-objc-root-class %s
|
|
|
|
typedef const struct __CFString * CFStringRef;
|
|
@class NSString;
|
|
|
|
NSString *CFBridgingRelease(void);
|
|
|
|
typedef NSString * PNSString;
|
|
|
|
typedef __autoreleasing NSString * AUTORELEASEPNSString;
|
|
|
|
@interface I @end
|
|
|
|
@implementation I
|
|
- (CFStringRef)myString
|
|
{
|
|
CFStringRef myString =
|
|
(__bridge CFStringRef) (__strong NSString *)CFBridgingRelease(); // expected-error {{explicit ownership qualifier on cast result has no effect}}
|
|
|
|
myString =
|
|
(__bridge CFStringRef) (__autoreleasing PNSString) CFBridgingRelease(); // expected-error {{explicit ownership qualifier on cast result has no effect}}
|
|
myString =
|
|
(__bridge CFStringRef) (AUTORELEASEPNSString) CFBridgingRelease(); // OK
|
|
myString =
|
|
(__bridge CFStringRef) (typeof(__strong NSString *)) CFBridgingRelease(); // expected-error {{explicit ownership qualifier on cast result has no effect}}
|
|
return myString;
|
|
}
|
|
|
|
- (void)decodeValueOfObjCType:(const char *)type at:(void *)addr {
|
|
__autoreleasing id *stuff = (__autoreleasing id *)addr;
|
|
}
|
|
@end
|
|
|
|
__strong I *__strong test1; // expected-error {{the type 'I *__strong' is already explicitly ownership-qualified}}
|
|
__strong I *(__strong test2); // expected-error {{the type 'I *__strong' is already explicitly ownership-qualified}}
|
|
__strong I *(__strong (test3)); // expected-error {{the type 'I *__strong' is already explicitly ownership-qualified}}
|
|
__unsafe_unretained __typeof__(test3) test4;
|
|
typedef __strong I *strong_I;
|
|
__unsafe_unretained strong_I test5;
|
|
|
|
typedef void (^T) (void);
|
|
@interface NSObject @end
|
|
@protocol P;
|
|
@interface Radar10907090 @end
|
|
|
|
@implementation Radar10907090
|
|
- (void) MMM : (NSObject*) arg0 : (NSObject<P>**)arg : (id) arg1 : (id<P>*) arg2 {} // expected-warning {{method parameter of type 'NSObject<P> *__autoreleasing *' with no explicit ownership}} \
|
|
// expected-warning {{method parameter of type '__autoreleasing id<P> *' with no explicit ownership}}
|
|
- (void) MM : (NSObject*) arg0 : (__strong NSObject**)arg : (id) arg1 : (__strong id*) arg2 {}
|
|
- (void) M : (NSObject**)arg0 : (id*)arg {} // expected-warning {{method parameter of type 'NSObject *__autoreleasing *' with no explicit ownership}} \
|
|
// expected-warning {{method parameter of type '__autoreleasing id *' with no explicit ownership}}
|
|
- (void) N : (__strong NSObject***) arg0 : (__strong NSObject<P>***)arg : (float**) arg1 : (double) arg2 {}
|
|
- (void) BLOCK : (T*) arg0 : (T)arg : (__strong T*) arg1 {} // expected-warning-re {{method parameter of type '__autoreleasing T *' (aka 'void (^__autoreleasing *)({{(void)?}})') with no explicit ownership}}
|
|
@end
|
|
|
|
@class NSMutableDictionary, NSError;
|
|
@interface Radar12280826
|
|
- (void)createInferiorTransportAndSetEnvironment:(NSMutableDictionary*)environment error:(__autoreleasing NSError**)error;
|
|
@end
|
|
|
|
@implementation Radar12280826
|
|
- (void)createInferiorTransportAndSetEnvironment:(NSMutableDictionary*)environment error:(__autoreleasing NSError**)error {}
|
|
@end
|
|
|
|
typedef __strong id strong_id;
|
|
typedef NSObject *NSObject_ptr;
|
|
typedef __strong NSObject *strong_NSObject_ptr;
|
|
|
|
// Warn
|
|
__strong id f1(void); // expected-warning{{ARC __strong lifetime qualifier on return type is ignored}}
|
|
NSObject __unsafe_unretained *f2(int); // expected-warning{{ARC __unsafe_unretained lifetime qualifier on return type is ignored}}
|
|
__autoreleasing NSObject *f3(void); // expected-warning{{ARC __autoreleasing lifetime qualifier on return type is ignored}}
|
|
NSObject * __strong f4(void); // expected-warning{{ARC __strong lifetime qualifier on return type is ignored}}
|
|
NSObject_ptr __strong f5(void); // expected-warning{{ARC __strong lifetime qualifier on return type is ignored}}
|
|
|
|
typedef __strong id (*fptr)(int); // expected-warning{{ARC __strong lifetime qualifier on return type is ignored}}
|
|
|
|
// Don't warn
|
|
strong_id f6(void);
|
|
strong_NSObject_ptr f7(void);
|
|
typedef __strong id (^block_ptr)(int);
|
|
|
|
void test8_a(void) {
|
|
__weak id *(^myBlock)(void);
|
|
__weak id *var = myBlock();
|
|
(void) (__strong id *) &myBlock;
|
|
(void) (__weak id *) &myBlock; // expected-error {{cast}}
|
|
}
|
|
void test8_b(void) {
|
|
__weak id (^myBlock)(void);
|
|
(void) (__weak id *) &myBlock;
|
|
(void) (__strong id *) &myBlock; // expected-error {{cast}}
|
|
}
|
|
void test8_c(void) {
|
|
__weak id (^*(^myBlock)(void))(void);
|
|
(void) (__weak id*) myBlock();
|
|
(void) (__strong id*) myBlock(); // expected-error {{cast}}
|
|
(void) (__weak id*) &myBlock; // expected-error {{cast}}
|
|
(void) (__strong id*) &myBlock;
|
|
}
|
|
|
|
@class Test9;
|
|
void test9_a(void) {
|
|
__weak Test9 **(^myBlock)(void);
|
|
__weak Test9 **var = myBlock();
|
|
(void) (__strong Test9 **) &myBlock;
|
|
(void) (__weak Test9 **) &myBlock; // expected-error {{cast}}
|
|
}
|
|
void test9_b(void) {
|
|
__weak Test9 *(^myBlock)(void);
|
|
(void) (__weak Test9**) &myBlock;
|
|
(void) (__strong Test9**) &myBlock; // expected-error {{cast}}
|
|
}
|
|
void test9_c(void) {
|
|
__weak Test9 *(^*(^myBlock)(void))(void);
|
|
(void) (__weak Test9 **) myBlock();
|
|
(void) (__strong Test9 **) myBlock(); // expected-error {{cast}}
|
|
(void) (__weak Test9 **) &myBlock; // expected-error {{cast}}
|
|
(void) (__strong Test9 **) &myBlock;
|
|
}
|