mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-16 20:06:37 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
92 lines
3.4 KiB
Objective-C
92 lines
3.4 KiB
Objective-C
// RUN: %clang_cc1 -triple x86_64-apple-darwin11 -fobjc-runtime-has-weak -fsyntax-only -fobjc-arc -verify -Wno-objc-root-class %s
|
|
// RUN: %clang_cc1 -triple x86_64-apple-darwin11 -fobjc-runtime-has-weak -fsyntax-only -fobjc-weak -verify -Wno-objc-root-class %s
|
|
|
|
__attribute__((objc_arc_weak_reference_unavailable))
|
|
@interface NSOptOut1072 // expected-note {{class is declared here}}
|
|
@end
|
|
|
|
@interface sub : NSOptOut1072 @end // expected-note 2 {{class is declared here}}
|
|
|
|
int main(void) {
|
|
__weak sub *w2; // expected-error {{class is incompatible with __weak references}}
|
|
|
|
__weak NSOptOut1072 *ns1; // expected-error {{class is incompatible with __weak references}}
|
|
|
|
id obj;
|
|
|
|
ns1 = (__weak sub *)obj; // expected-error {{assignment of a weak-unavailable object to a __weak object}} \
|
|
// expected-error {{class is incompatible with __weak references}} \
|
|
// expected-error {{explicit ownership qualifier on cast result has no effect}}
|
|
}
|
|
|
|
__attribute__((objc_arc_weak_reference_unavailable))
|
|
@interface NOWEAK
|
|
+ (id) new;
|
|
@end
|
|
|
|
NOWEAK * Test1(void) {
|
|
NOWEAK * strong1 = [NOWEAK new];
|
|
__weak id weak1;
|
|
weak1 = strong1; // expected-error {{assignment of a weak-unavailable object to a __weak object}}
|
|
|
|
__weak id weak2 = strong1; // expected-error {{assignment of a weak-unavailable object to a __weak object}}
|
|
return (__weak id)strong1; // expected-error {{cast of weak-unavailable object of type 'NOWEAK *' to a __weak object of type '__weak id'}} \
|
|
// expected-error {{explicit ownership qualifier on cast result has no effect}}
|
|
}
|
|
|
|
@protocol P @end
|
|
@protocol P1 @end
|
|
|
|
NOWEAK<P, P1> * Test2(void) {
|
|
NOWEAK<P, P1> * strong1 = 0;
|
|
__weak id<P> weak1;
|
|
weak1 = strong1; // expected-error {{assignment of a weak-unavailable object to a __weak object}}
|
|
|
|
__weak id<P> weak2 = strong1; // expected-error {{assignment of a weak-unavailable object to a __weak object}}
|
|
return (__weak id<P>)strong1; // expected-error {{cast of weak-unavailable object of type 'NOWEAK<P,P1> *' to a __weak object of type '__weak id<P>'}} \
|
|
// expected-error {{explicit ownership qualifier on cast result has no effect}}
|
|
}
|
|
|
|
__attribute__((objc_arc_weak_reference_unavailable))
|
|
@interface NSFont
|
|
@end
|
|
|
|
@interface I
|
|
{
|
|
}
|
|
@property (weak) NSFont *font; // expected-error {{synthesizing __weak instance variable of type 'NSFont *', which does not support weak references}}
|
|
@end
|
|
|
|
@implementation I // expected-note {{when implemented by class I}}
|
|
@synthesize font = _font;
|
|
@end
|
|
|
|
@protocol MyProtocol
|
|
@property (weak) NSFont *font; // expected-error {{synthesizing __weak instance variable of type 'NSFont *', which does not support weak references}}
|
|
@end
|
|
|
|
@interface I1 <MyProtocol>
|
|
@end
|
|
|
|
@implementation I1 // expected-note {{when implemented by class I1}}
|
|
@synthesize font = _font;
|
|
@end
|
|
|
|
@interface Super
|
|
@property (weak) NSFont *font; // expected-error {{synthesizing __weak instance variable of type 'NSFont *', which does not support weak references}}
|
|
@end
|
|
|
|
|
|
@interface I2 : Super
|
|
@end
|
|
|
|
@implementation I2 // expected-note {{when implemented by class I2}}
|
|
@synthesize font = _font;
|
|
@end
|
|
|
|
__attribute__((objc_arc_weak_reference_unavailable(1))) // expected-error {{'objc_arc_weak_reference_unavailable' attribute takes no arguments}}
|
|
@interface I3
|
|
@end
|
|
|
|
int I4 __attribute__((objc_arc_weak_reference_unavailable)); // expected-error {{'objc_arc_weak_reference_unavailable' attribute only applies to Objective-C interfaces}}
|