mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-16 17:16:42 +00:00

We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
307 lines
8.4 KiB
Objective-C
307 lines
8.4 KiB
Objective-C
// RUN: %clang_cc1 -fsyntax-only -triple x86_64-apple-darwin10.4 -verify -Wno-objc-root-class %s
|
|
// RUN: %clang_cc1 -x objective-c++ -fsyntax-only -triple x86_64-apple-darwin10.4 -verify -Wno-objc-root-class %s
|
|
|
|
@interface A {
|
|
int X __attribute__((deprecated)); // expected-note 2 {{'X' has been explicitly marked deprecated here}}
|
|
}
|
|
+ (void)F __attribute__((deprecated)); // expected-note 2 {{'F' has been explicitly marked deprecated here}}
|
|
- (void)f __attribute__((deprecated)); // expected-note 5 {{'f' has been explicitly marked deprecated here}}
|
|
@end
|
|
|
|
@implementation A
|
|
+ (void)F __attribute__((deprecated))
|
|
{
|
|
[self F]; // no warning, since the caller is also deprecated.
|
|
}
|
|
|
|
- (void)g
|
|
{
|
|
X++; // expected-warning{{'X' is deprecated}}
|
|
self->X++; // expected-warning{{'X' is deprecated}}
|
|
[self f]; // expected-warning{{'f' is deprecated}}
|
|
}
|
|
|
|
- (void)f
|
|
{
|
|
[self f]; // no warning, the caller is deprecated in its interface.
|
|
}
|
|
@end
|
|
|
|
@interface B: A
|
|
@end
|
|
|
|
@implementation B
|
|
+ (void)G
|
|
{
|
|
[super F]; // expected-warning{{'F' is deprecated}}
|
|
}
|
|
|
|
- (void)g
|
|
{
|
|
[super f]; // // expected-warning{{'f' is deprecated}}
|
|
}
|
|
@end
|
|
|
|
@protocol P
|
|
- (void)p __attribute__((deprecated)); // expected-note {{'p' has been explicitly marked deprecated here}}
|
|
@end
|
|
|
|
void t1(A *a)
|
|
{
|
|
[A F]; // expected-warning{{'F' is deprecated}}
|
|
[a f]; // expected-warning{{'f' is deprecated}}
|
|
}
|
|
|
|
void t2(id a)
|
|
{
|
|
[a f]; // expected-warning {{'f' is deprecated}}
|
|
}
|
|
|
|
void t3(A<P>* a)
|
|
{
|
|
[a f]; // expected-warning{{'f' is deprecated}}
|
|
[a p]; // expected-warning{{'p' is deprecated}}
|
|
}
|
|
|
|
void t4(Class c)
|
|
{
|
|
[c F];
|
|
}
|
|
|
|
|
|
|
|
@interface Bar
|
|
|
|
@property (assign, setter = MySetter:) int FooBar __attribute__ ((deprecated)); // expected-note 2 {{'FooBar' has been explicitly marked deprecated here}}
|
|
- (void) MySetter : (int) value;
|
|
@end
|
|
|
|
int t5(void) {
|
|
Bar *f;
|
|
f.FooBar = 1; // expected-warning {{'FooBar' is deprecated}}
|
|
return f.FooBar; // expected-warning {{'FooBar' is deprecated}}
|
|
}
|
|
|
|
|
|
__attribute ((deprecated)) // expected-note {{'DEPRECATED' has been explicitly marked deprecated here}}
|
|
@interface DEPRECATED {
|
|
@public int ivar;
|
|
DEPRECATED *ivar2; // no warning.
|
|
}
|
|
- (int) instancemethod;
|
|
- (DEPRECATED *) meth; // no warning.
|
|
@property int prop;
|
|
@end
|
|
|
|
@interface DEPRECATED (Category) // no warning.
|
|
- (DEPRECATED *) meth2; // no warning.
|
|
@end
|
|
|
|
@interface DEPRECATED (Category2) // no warning.
|
|
- (id)meth;
|
|
@end
|
|
|
|
__attribute__((deprecated))
|
|
void depr_function(void);
|
|
|
|
@implementation DEPRECATED (Category2) // no warning
|
|
- (id)meth {
|
|
depr_function(); // no warning.
|
|
return 0;
|
|
}
|
|
@end
|
|
|
|
@interface NS : DEPRECATED // expected-warning {{'DEPRECATED' is deprecated}}
|
|
@end
|
|
|
|
|
|
@interface Test2
|
|
@property int test2 __attribute__((deprecated)); // expected-note 2 {{property 'test2' is declared deprecated here}} expected-note 3 {{'test2' has been explicitly marked deprecated here}} \
|
|
// expected-note {{'setTest2:' has been explicitly marked deprecated here}}
|
|
@end
|
|
|
|
void test(Test2 *foo) {
|
|
int x;
|
|
x = foo.test2; // expected-warning {{'test2' is deprecated}}
|
|
x = [foo test2]; // expected-warning {{'test2' is deprecated}}
|
|
foo.test2 = x; // expected-warning {{'test2' is deprecated}}
|
|
[foo setTest2: x]; // expected-warning {{'setTest2:' is deprecated}}
|
|
}
|
|
|
|
__attribute__((deprecated))
|
|
@interface A(Blah) // no warning
|
|
- (A*)getA;
|
|
@end
|
|
|
|
@implementation A(Blah) // Don't warn by default
|
|
- (A*)getA {
|
|
return self;
|
|
}
|
|
@end
|
|
|
|
typedef struct {
|
|
int x;
|
|
} footype __attribute((deprecated)); // expected-note 2 {{'footype' has been explicitly marked deprecated here}}
|
|
|
|
@interface foo {
|
|
footype a; // expected-warning {{'footype' is deprecated}}
|
|
footype b __attribute((deprecated));
|
|
}
|
|
@property footype c; // expected-warning {{'footype' is deprecated}}
|
|
@property footype d __attribute((deprecated));
|
|
@end
|
|
|
|
@interface NewI
|
|
+(void)cmeth;
|
|
@end
|
|
|
|
typedef NewI DeprI __attribute__((deprecated("blah"))); // expected-note 4 {{'DeprI' has been explicitly marked deprecated here}}
|
|
|
|
@interface SI : DeprI // expected-warning {{'DeprI' is deprecated: blah}}
|
|
-(DeprI*)meth; // expected-warning {{'DeprI' is deprecated: blah}}
|
|
@end
|
|
|
|
@implementation SI
|
|
-(DeprI*)meth { // expected-warning {{'DeprI' is deprecated: blah}}
|
|
[DeprI cmeth]; // expected-warning {{'DeprI' is deprecated: blah}}
|
|
return 0;
|
|
}
|
|
@end
|
|
|
|
// - Using deprecated class name inside class should not warn about deprecation.
|
|
// - Implementations of deprecated classes should not result in deprecation warnings.
|
|
__attribute__((deprecated))
|
|
@interface DeprecatedClassA
|
|
@end
|
|
|
|
__attribute__((deprecated))
|
|
@interface DeprecatedClassB
|
|
// The self-reference return value should not be
|
|
// flagged as the use of a deprecated declaration.
|
|
+ (DeprecatedClassB *)sharedInstance; // no-warning
|
|
|
|
// Since this class is deprecated, returning a reference
|
|
// to another deprecated class is fine as they may
|
|
// have been deprecated together. From a user's
|
|
// perspective they are all deprecated.
|
|
+ (DeprecatedClassA *)somethingElse; // no-warning
|
|
@end
|
|
|
|
@implementation DeprecatedClassB
|
|
+ (DeprecatedClassB *)sharedInstance
|
|
{
|
|
// This self-reference should not
|
|
// be flagged as a use of a deprecated
|
|
// declaration.
|
|
static DeprecatedClassB *x; // no-warning
|
|
return x;
|
|
}
|
|
+ (DeprecatedClassA *)somethingElse {
|
|
// Since this class is deprecated, referencing
|
|
// another deprecated class is also OK.
|
|
static DeprecatedClassA *x; // no-warning
|
|
return x;
|
|
}
|
|
|
|
@end
|
|
|
|
@interface TestBase
|
|
@property (nonatomic, strong) id object __attribute__((deprecated("deprecated"))); // expected-note {{'object' has been explicitly marked deprecated here}} \
|
|
expected-note {{property 'object' is declared deprecated here}} \
|
|
expected-note {{'setObject:' has been explicitly marked deprecated here}} \
|
|
expected-note {{property declared here}}
|
|
@end
|
|
|
|
@interface TestDerived : TestBase
|
|
@property (nonatomic, strong) id object; //expected-warning {{auto property synthesis will not synthesize property 'object'; it will be implemented by its superclass}}
|
|
@end
|
|
|
|
@interface TestUse @end
|
|
|
|
@implementation TestBase @end
|
|
|
|
@implementation TestDerived @end // expected-note {{detected while default synthesizing properties in class implementation}}
|
|
|
|
@implementation TestUse
|
|
|
|
- (void) use
|
|
{
|
|
TestBase *base = (id)0;
|
|
TestDerived *derived = (id)0;
|
|
id object = (id)0;
|
|
|
|
base.object = object; // expected-warning {{'object' is deprecated: deprecated}}
|
|
derived.object = object;
|
|
|
|
[base setObject:object]; // expected-warning {{'setObject:' is deprecated: deprecated}}
|
|
[derived setObject:object];
|
|
}
|
|
|
|
@end
|
|
|
|
@interface NSString
|
|
- (const char *)cString __attribute__((availability(macosx,introduced=10.0 ,deprecated=10.4,message="" ))); // expected-note {{'cString' has been explicitly marked deprecated here}}
|
|
@end
|
|
|
|
id PID = 0;
|
|
const char * func(void) {
|
|
return [PID cString]; // expected-warning {{'cString' is deprecated: first deprecated in macOS 10.4}}
|
|
}
|
|
|
|
@interface NSObject
|
|
+ (instancetype)alloc;
|
|
- (instancetype)init;
|
|
@end
|
|
|
|
@interface NSLocale
|
|
- (instancetype)init __attribute__((unavailable));
|
|
@end
|
|
|
|
@interface PLBatteryProperties : NSObject
|
|
+ (id)properties;
|
|
@end
|
|
|
|
@implementation PLBatteryProperties
|
|
+ (id)properties {
|
|
return [[self alloc] init];
|
|
}
|
|
@end
|
|
|
|
@implementation UndeclaredImpl // expected-warning{{cannot find interface declaration}}
|
|
- (void)partiallyUnavailableMethod {}
|
|
@end
|
|
|
|
@interface InterfaceWithSameMethodAsUndeclaredImpl
|
|
- (void)partiallyUnavailableMethod __attribute__((unavailable));
|
|
@end
|
|
|
|
void f(id a) {
|
|
[a partiallyUnavailableMethod]; // no warning, `a` could be an UndeclaredImpl.
|
|
}
|
|
|
|
@interface InterfaceWithImplementation
|
|
- (void)anotherPartiallyUnavailableMethod;
|
|
@end
|
|
@implementation InterfaceWithImplementation
|
|
- (void)anotherPartiallyUnavailableMethod {}
|
|
@end
|
|
|
|
@interface InterfaceWithSameMethodAsInterfaceWithImplementation
|
|
- (void)anotherPartiallyUnavailableMethod __attribute__((unavailable));
|
|
@end
|
|
|
|
void g(id a) {
|
|
[a anotherPartiallyUnavailableMethod]; // no warning, `a` could be an InterfaceWithImplementation.
|
|
}
|
|
|
|
typedef struct {} S1 __attribute__((unavailable)); // expected-note2{{marked unavailable here}}
|
|
typedef struct {} S2 __attribute__((deprecated)); // expected-note2{{marked deprecated here}}
|
|
@interface ExtensionForMissingInterface() // expected-error{{cannot find interface declaration}}
|
|
- (void)method1:(S1) x; // expected-error{{is unavailable}}
|
|
- (void)method2:(S2) x; // expected-warning{{is deprecated}}
|
|
@end
|
|
@interface CategoryForMissingInterface(Cat) // expected-error{{cannot find interface declaration}}
|
|
- (void)method1:(S1) x; // expected-error{{is unavailable}}
|
|
- (void)method2:(S2) x; // expected-warning{{is deprecated}}
|
|
@end
|