mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-17 04:56:36 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
106 lines
3.3 KiB
Objective-C
106 lines
3.3 KiB
Objective-C
// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s
|
|
|
|
@interface MyClass1 @end
|
|
|
|
@protocol p1,p2,p3; // expected-note {{protocol 'p1' has no definition}} \
|
|
// expected-note {{protocol 'p2' has no definition}}
|
|
|
|
@interface MyClass1 (Category1) <p1> // expected-warning {{cannot find protocol definition for 'p1'}} expected-note {{previous definition is here}}
|
|
@end
|
|
|
|
@interface MyClass1 (Category1) // expected-warning {{duplicate definition of category 'Category1' on interface 'MyClass1'}}
|
|
@end
|
|
|
|
@interface MyClass1 (Category3)
|
|
@end
|
|
|
|
@interface MyClass1 (Category4) @end // expected-note {{previous definition is here}}
|
|
@interface MyClass1 (Category5) @end
|
|
@interface MyClass1 (Category6) @end
|
|
@interface MyClass1 (Category7) @end // expected-note {{previous definition is here}}
|
|
@interface MyClass1 (Category8) @end // expected-note {{previous definition is here}}
|
|
|
|
|
|
@interface MyClass1 (Category4) @end // expected-warning {{duplicate definition of category 'Category4' on interface 'MyClass1'}}
|
|
@interface MyClass1 (Category7) @end // expected-warning {{duplicate definition of category 'Category7' on interface 'MyClass1'}}
|
|
@interface MyClass1 (Category8) @end // expected-warning {{duplicate definition of category 'Category8' on interface 'MyClass1'}}
|
|
|
|
|
|
@protocol p3 @end
|
|
|
|
@interface MyClass1 (Category) <p2, p3> @end // expected-warning {{cannot find protocol definition for 'p2'}}
|
|
|
|
@interface UnknownClass (Category) @end // expected-error {{cannot find interface declaration for 'UnknownClass'}}
|
|
|
|
@class MyClass2; // expected-note{{forward declaration of class here}}
|
|
|
|
@interface MyClass2 (Category) @end // expected-error {{cannot define category for undefined class 'MyClass2'}}
|
|
|
|
@interface XCRemoteComputerManager
|
|
@end
|
|
|
|
@interface XCRemoteComputerManager()
|
|
@end
|
|
|
|
@interface XCRemoteComputerManager()
|
|
@end
|
|
|
|
@interface XCRemoteComputerManager(x) // expected-note {{previous definition is here}}
|
|
@end
|
|
|
|
@interface XCRemoteComputerManager(x) // expected-warning {{duplicate definition of category 'x' on interface 'XCRemoteComputerManager'}}
|
|
@end
|
|
|
|
@implementation XCRemoteComputerManager
|
|
@end
|
|
|
|
@implementation XCRemoteComputerManager(x) // expected-note {{previous definition is here}}
|
|
@end
|
|
|
|
@implementation XCRemoteComputerManager(x) // expected-error {{reimplementation of category 'x' for class 'XCRemoteComputerManager'}}
|
|
@end
|
|
|
|
@protocol MultipleCat_P
|
|
-(void) im0; // expected-note {{method 'im0' declared here}}
|
|
@end
|
|
|
|
@interface MultipleCat_I @end
|
|
|
|
@interface MultipleCat_I() @end
|
|
|
|
@interface MultipleCat_I() <MultipleCat_P> @end
|
|
|
|
@implementation MultipleCat_I // expected-warning {{method 'im0' in protocol 'MultipleCat_P' not implemented}}
|
|
@end
|
|
|
|
// Handle nameless categories with no name that refer to an undefined class.
|
|
@interface RDar7680391 () @end // expected-error{{cannot find interface declaration}}
|
|
|
|
// Handle @synthesize being used in conjunction with explicitly declared
|
|
// accessor.
|
|
@interface RDar8891119 {
|
|
id _name;
|
|
}
|
|
@end
|
|
@interface RDar8891119 ()
|
|
- (id)name;
|
|
@end
|
|
@interface RDar8891119 ()
|
|
@property (copy) id name;
|
|
@end
|
|
@implementation RDar8891119
|
|
@synthesize name = _name;
|
|
@end
|
|
|
|
@class I; // expected-note {{forward declaration}}
|
|
@implementation I(cat) // expected-error{{cannot find interface declaration}}
|
|
@end
|
|
|
|
@interface Unrelated
|
|
- foo;
|
|
@end
|
|
|
|
@interface Blah (Blarg) // expected-error{{cannot find interface declaration for 'Blah'}}
|
|
- foo;
|
|
@end
|