mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-17 05:56:36 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
54 lines
2.2 KiB
Objective-C
54 lines
2.2 KiB
Objective-C
// RUN: %clang_cc1 -Wcstring-format-directive -verify -fsyntax-only %s
|
|
|
|
typedef __builtin_va_list __darwin_va_list;
|
|
typedef __builtin_va_list va_list;
|
|
|
|
va_list argList;
|
|
|
|
typedef const struct __CFString * CFStringRef;
|
|
typedef struct __CFString * CFMutableStringRef;
|
|
typedef const struct __CFAllocator * CFAllocatorRef;
|
|
|
|
|
|
typedef const struct __CFDictionary * CFDictionaryRef;
|
|
|
|
CFStringRef CFSTR ( const char *cStr );
|
|
|
|
|
|
extern
|
|
CFStringRef CStringCreateWithFormat(CFAllocatorRef alloc, CFDictionaryRef formatOptions, const char* format, ...) __attribute__((format(os_trace, 3, 4)));
|
|
|
|
extern
|
|
CFStringRef CStringCreateWithFormatAndArguments(CFAllocatorRef alloc, CFDictionaryRef formatOptions, const char* format, va_list arguments) __attribute__((format(os_trace, 3, 0)));
|
|
|
|
extern
|
|
void CStringAppendFormat(CFMutableStringRef theString, CFDictionaryRef formatOptions, const char* format, ...) __attribute__((format(os_trace, 3, 4)));
|
|
|
|
extern
|
|
void CStringAppendFormatAndArguments(CFMutableStringRef theString, CFDictionaryRef formatOptions, const char* format, va_list arguments) __attribute__((format(os_trace, 3, 0)));
|
|
|
|
void Test1(va_list argList) {
|
|
CFAllocatorRef alloc;
|
|
CStringCreateWithFormatAndArguments (alloc, 0, "%s\n", argList);
|
|
CStringAppendFormatAndArguments ((CFMutableStringRef)@"AAAA", 0, "Hello %s there %d\n", argList);
|
|
CStringCreateWithFormatAndArguments (alloc, 0, "%c\n", argList);
|
|
CStringAppendFormatAndArguments ((CFMutableStringRef)@"AAAA", 0, "%d\n", argList);
|
|
}
|
|
|
|
extern void MyOSLog(const char* format, ...) __attribute__((format(os_trace, 1, 2)));
|
|
extern void MyFStringCreateWithFormat(const char *format, ...) __attribute__((format(os_trace, 1, 2)));
|
|
extern void XMyOSLog(int, const char* format, ...) __attribute__((format(os_trace, 2, 3)));
|
|
extern void os_trace(const char *format, ...) __attribute__((format(os_trace, 1, 2)));
|
|
|
|
void Test2(void) {
|
|
MyOSLog("%s\n", "Hello");
|
|
|
|
MyFStringCreateWithFormat("%s", "Hello");
|
|
XMyOSLog(4, "%s\n", "Hello");
|
|
|
|
os_trace("testing %@, %s, %d, %@, %m", CFSTR("object"), "string", 3, "it"); // expected-warning {{format specifies type 'id' but the argument has type 'char *'}}
|
|
|
|
os_trace("testing %@, %s, %d, %@, %m", CFSTR("object"), "string", 3, @"ok");
|
|
}
|
|
|