mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-17 10:46:37 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
56 lines
2.0 KiB
Objective-C
56 lines
2.0 KiB
Objective-C
// RUN: %clang_cc1 -triple x86_64-apple-darwin11 -fsyntax-only -fblocks -Wcast-qual -verify %s
|
|
|
|
typedef const void *CFTypeRef;
|
|
typedef const struct __CFString *CFStringRef;
|
|
@class NSString;
|
|
|
|
@interface NSString
|
|
@end
|
|
|
|
CFTypeRef CFCreateSomething(void);
|
|
CFStringRef CFCreateString(void);
|
|
CFTypeRef CFGetSomething(void);
|
|
CFStringRef CFGetString(void);
|
|
|
|
id CreateSomething(void);
|
|
NSString *CreateNSString(void);
|
|
|
|
void from_cf(void) {
|
|
id obj1 = (__bridge_transfer id)CFCreateSomething(); // expected-warning {{'__bridge_transfer' casts have no effect when not using ARC}}
|
|
id obj2 = (__bridge_transfer NSString*)CFCreateString(); // expected-warning {{'__bridge_transfer' casts have no effect when not using ARC}}
|
|
(__bridge int*)CFCreateSomething(); // expected-warning {{expression result unused}} expected-warning {{cast from 'const void *' to 'int *' drops const qualifier}}
|
|
id obj3 = (__bridge id)CFGetSomething();
|
|
id obj4 = (__bridge NSString*)CFGetString();
|
|
}
|
|
|
|
void to_cf(id obj) {
|
|
CFTypeRef cf1 = (__bridge_retained CFTypeRef)CreateSomething(); // expected-warning {{'__bridge_retained' casts have no effect when not using ARC}}
|
|
CFStringRef cf2 = (__bridge_retained CFStringRef)CreateNSString(); // expected-warning {{'__bridge_retained' casts have no effect when not using ARC}}
|
|
CFTypeRef cf3 = (__bridge CFTypeRef)CreateSomething();
|
|
CFStringRef cf4 = (__bridge CFStringRef)CreateNSString();
|
|
}
|
|
|
|
void fixits(void) {
|
|
id obj1 = (id)CFCreateSomething();
|
|
CFTypeRef cf1 = (CFTypeRef)CreateSomething();
|
|
}
|
|
|
|
#pragma clang diagnostic ignored "-Warc-bridge-casts-disallowed-in-nonarc"
|
|
|
|
void to_cf_ignored(id obj) {
|
|
CFTypeRef cf1 = (__bridge_retained CFTypeRef)CreateSomething(); // no-warning
|
|
CFTypeRef cf3 = (__bridge CFTypeRef)CreateSomething(); // no-warning
|
|
}
|
|
|
|
// Check that clang doesn't warn about dropping const from Objective-C object
|
|
// types.
|
|
void test_wcast_qual(void) {
|
|
CFStringRef c;
|
|
NSString *n0 = (NSString *)c;
|
|
NSString **n1 = (NSString **)&c;
|
|
const NSString *n2;
|
|
const NSString **n3;
|
|
void *p0 = (void *)n2;
|
|
void **p1 = (void **)n3;
|
|
}
|