mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-16 15:06:36 +00:00
7068aa9841
Clang has traditionally allowed C programs to implicitly convert integers to pointers and pointers to integers, despite it not being valid to do so except under special circumstances (like converting the integer 0, which is the null pointer constant, to a pointer). In C89, this would result in undefined behavior per 3.3.4, and in C99 this rule was strengthened to be a constraint violation instead. Constraint violations are most often handled as an error. This patch changes the warning to default to an error in all C modes (it is already an error in C++). This gives us better security posture by calling out potential programmer mistakes in code but still allows users who need this behavior to use -Wno-error=int-conversion to retain the warning behavior, or -Wno-int-conversion to silence the diagnostic entirely. Differential Revision: https://reviews.llvm.org/D129881
41 lines
853 B
Objective-C
41 lines
853 B
Objective-C
// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s
|
|
// pr5986
|
|
|
|
@interface Test {
|
|
int index;
|
|
}
|
|
- (int) index;
|
|
+ (int) ClassMethod;
|
|
@end
|
|
|
|
@implementation Test
|
|
- (int) index
|
|
{
|
|
return index;
|
|
}
|
|
+ (int) ClassMethod
|
|
{
|
|
return index; // expected-error {{instance variable 'index' accessed in class method}}
|
|
}
|
|
@end
|
|
|
|
@interface Test1 {
|
|
}
|
|
- (int) InstMethod;
|
|
+ (int) ClassMethod;
|
|
@end
|
|
|
|
@implementation Test1
|
|
- (int) InstMethod
|
|
{
|
|
return index; // expected-error {{call to undeclared library function 'index'}} \
|
|
// expected-note {{include the header <strings.h> or explicitly provide a declaration for 'index'}} \
|
|
// expected-error {{incompatible pointer to integer conversion returning}}
|
|
}
|
|
+ (int) ClassMethod
|
|
{
|
|
return index; // expected-error {{incompatible pointer to integer conversion returning}}
|
|
}
|
|
@end
|
|
|