mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-17 19:46:41 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
66 lines
2.0 KiB
Objective-C
66 lines
2.0 KiB
Objective-C
// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s
|
|
|
|
typedef struct CGColor * __attribute__ ((NSObject)) CGColorRef;
|
|
typedef struct CGColor * __attribute__((NSObject(12))) Illegal; // expected-error {{'NSObject' attribute takes no arguments}}
|
|
|
|
static int count;
|
|
static CGColorRef tmp = 0;
|
|
|
|
typedef struct S1 __attribute__ ((NSObject)) CGColorRef1; // expected-error {{'NSObject' attribute is for pointer types only}}
|
|
typedef void * __attribute__ ((NSObject)) CGColorRef2; // no-warning
|
|
typedef void * CFTypeRef;
|
|
|
|
@interface HandTested {
|
|
@public
|
|
CGColorRef x;
|
|
}
|
|
|
|
@property(copy) CGColorRef x;
|
|
typedef struct CGColor * __attribute__((NSObject)) CGColorRefNoNSObject; // no-warning
|
|
@property (nonatomic, retain) CGColorRefNoNSObject color;
|
|
@property (strong) __attribute__((NSObject)) CFTypeRef myObj; // no-warning
|
|
@property (strong, nullable) CGColorRefNoNSObject color2; // no-warning
|
|
@end
|
|
|
|
void setProperty(id self, id value) {
|
|
((HandTested *)self)->x = value;
|
|
}
|
|
|
|
id getProperty(id self) {
|
|
return (id)((HandTested *)self)->x;
|
|
}
|
|
|
|
@implementation HandTested
|
|
@synthesize x=x;
|
|
@synthesize myObj;
|
|
@dynamic color;
|
|
@end
|
|
|
|
int main(int argc, char *argv[]) {
|
|
HandTested *to;
|
|
to.x = tmp; // setter
|
|
if (tmp != to.x)
|
|
to.x = tmp;
|
|
return 0;
|
|
}
|
|
|
|
@interface I
|
|
{
|
|
__attribute__((NSObject)) void * color; // expected-warning {{'NSObject' attribute may be put on a typedef only; attribute is ignored}}
|
|
}
|
|
@property (nonatomic, retain) __attribute__((NSObject)) CGColorRefNoNSObject color; // // no-warning
|
|
@end
|
|
void test_10453342(void) {
|
|
char* __attribute__((NSObject)) string2 = 0; // expected-warning {{'NSObject' attribute may be put on a typedef only; attribute is ignored}}
|
|
}
|
|
|
|
@interface A { int i; }
|
|
@property(retain) __attribute__((NSObject)) int i; // expected-error {{'NSObject' attribute is for pointer types only}} \
|
|
// expected-error {{property with 'retain (or strong)' attribute must be of object type}}
|
|
@end
|
|
|
|
@implementation A
|
|
@synthesize i;
|
|
@end
|
|
|