mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-18 12:46:51 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
121 lines
2.5 KiB
Objective-C
121 lines
2.5 KiB
Objective-C
// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s
|
|
|
|
typedef signed char BOOL;
|
|
@protocol NSObject - (BOOL)isEqual:(id)object; @end
|
|
|
|
@interface NSObject <NSObject> {} @end
|
|
|
|
@interface _NSServicesInContextMenu : NSObject {
|
|
id _requestor;
|
|
NSObject *_appleEventDescriptor;
|
|
}
|
|
|
|
@property (retain, nonatomic) id requestor;
|
|
@property (retain, nonatomic) id appleEventDescriptor;
|
|
|
|
@end
|
|
|
|
@implementation _NSServicesInContextMenu
|
|
|
|
@synthesize requestor = _requestor, appleEventDescriptor = _appleEventDescriptor;
|
|
|
|
@end
|
|
|
|
@class NSString;
|
|
|
|
@protocol MyProtocol
|
|
- (NSString *)stringValue;
|
|
@end
|
|
|
|
@interface MyClass : NSObject {
|
|
id _myIvar;
|
|
}
|
|
@property (readwrite, retain) id<MyProtocol> myIvar;
|
|
@end
|
|
|
|
@implementation MyClass
|
|
@synthesize myIvar = _myIvar;
|
|
@end
|
|
|
|
|
|
@interface BadPropClass
|
|
{
|
|
int _awesome;
|
|
}
|
|
|
|
@property (readonly) int; // expected-warning {{declaration does not declare anything}}
|
|
@property (readonly) ; // expected-error {{type name requires a specifier or qualifier}}
|
|
@property (readonly) int : 4; // expected-error {{property requires fields to be named}}
|
|
|
|
|
|
// test parser recovery
|
|
@property ( // expected-note {{to match this '('}}
|
|
readonly getter=isAwesome) // expected-error {{expected ')'}}
|
|
|
|
int _awesome;
|
|
@property (readonlyx) // expected-error {{unknown property attribute 'readonlyx'}}
|
|
int _awesome2;
|
|
|
|
@property ( // expected-note {{to match this '('}}
|
|
+) // expected-error {{expected ')'}}
|
|
|
|
int _awesome3;
|
|
|
|
@end
|
|
|
|
@protocol PVImageViewProtocol
|
|
@property int inEyeDropperMode;
|
|
@end
|
|
|
|
@interface Cls
|
|
@property int inEyeDropperMode;
|
|
@end
|
|
|
|
@interface PVAdjustColor @end
|
|
|
|
@implementation PVAdjustColor
|
|
|
|
- xx {
|
|
id <PVImageViewProtocol> view;
|
|
Cls *c;
|
|
|
|
c.inEyeDropperMode = 1;
|
|
view.inEyeDropperMode = 1;
|
|
}
|
|
@end
|
|
|
|
@interface MyStyleIntf
|
|
{
|
|
int _myStyle;
|
|
}
|
|
|
|
@property(readonly) int myStyle;
|
|
|
|
- (float)setMyStyle:(int)style;
|
|
@end
|
|
|
|
@class MDAInstance; // expected-note {{forward declaration of class here}}
|
|
|
|
@interface MDATestDocument
|
|
@property(retain) MDAInstance *instance;
|
|
@end
|
|
|
|
id f0(MDATestDocument *d) {
|
|
return d.instance.path; // expected-error {{property 'path' cannot be found in forward class object 'MDAInstance'}}
|
|
}
|
|
|
|
@interface UIView @end
|
|
|
|
@interface FRFakeBannerView : UIView
|
|
@end
|
|
|
|
@interface FRAdCollectionViewCell
|
|
@property (nonatomic, weak, readonly) UIView *bannerView;
|
|
@end
|
|
|
|
@interface FRAdCollectionViewCell ()
|
|
|
|
@property (nonatomic, weak, readwrite) FRFakeBannerView *bannerView;
|
|
|
|
@end
|