mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-24 15:46:05 +00:00

Binutils generated sections seem to be padded to a multiple of 16 bytes, but the aux section definition contains the original, unpadded section length. The size check used for IMAGE_COMDAT_SELECT_SAME_SIZE previously only checked the size of the section itself. When checking the currently processed object file against the previously chosen comdat section, we easily have access to the aux section definition of the currently processed section, but we have to iterate over the symbols of the previously selected object file to find the section definition of the previously picked section. (We don't want to inflate SectionChunk to carry more data, for something that is only needed in corner cases.) Only do this when the mingw flag is set. This fixes statically linking clang-built C++ object files against libstdc++ built with GCC, if the object files contain e.g. typeinfo. Differential Revision: https://reviews.llvm.org/D86659
16 lines
642 B
Plaintext
16 lines
642 B
Plaintext
# RUN: yaml2obj %p/Inputs/comdat-llvm.yaml > %t.llvm.o
|
|
# RUN: yaml2obj %p/Inputs/comdat-binutils.yaml > %t.binutils.o
|
|
# RUN: lld-link -lldmingw -noentry -dll %t.llvm.o %t.binutils.o -out:%t.dll
|
|
# RUN: lld-link -lldmingw -noentry -dll %t.binutils.o %t.llvm.o -out:%t.dll
|
|
# RUN: not lld-link -noentry -dll %t.llvm.o %t.binutils.o -out:%t.dll
|
|
# RUN: not lld-link -noentry -dll %t.binutils.o %t.llvm.o -out:%t.dll
|
|
|
|
# The test object files have been generated by assembling the following
|
|
# snippet using binutils and llvm.
|
|
|
|
# .section .rdata$mysymbol, "dr"
|
|
# .linkonce same_size
|
|
# .globl mysymbol
|
|
#mysymbol:
|
|
# .byte 42
|