mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-27 20:46:05 +00:00
fee3cccc6c
This adds a check for exported inline functions, that there is a definition in the definition domain (which, in practice, can only be the module purview but before any PMF starts) since the PMF definition domain cannot contain exports. This is: [dcl.inline]/7 If an inline function or variable that is attached to a named module is declared in a definition domain, it shall be defined in that domain. The patch also amends diagnostic output by excluding the PMF sub-module from the set considered as sources of missing decls. There is no point in telling the user that the import of a PMF object is missing - since such objects are never reachable to an importer. We still show the definition (as unreachable), to help point out this. Differential Revision: https://reviews.llvm.org/D128328
50 lines
1.3 KiB
C++
50 lines
1.3 KiB
C++
// Tests that the definition in private module fragment is not reachable to its users.
|
|
//
|
|
// RUN: rm -rf %t
|
|
// RUN: mkdir -p %t
|
|
// RUN: split-file %s %t
|
|
//
|
|
// RUN: %clang_cc1 -std=c++20 %t/Private.cppm -emit-module-interface \
|
|
// RUN: -o %t/Private.pcm
|
|
// RUN: %clang_cc1 -std=c++20 -fprebuilt-module-path=%t %t/Use.cpp \
|
|
// RUN: -DTEST_BADINLINE -verify -fsyntax-only
|
|
|
|
//--- Private.cppm
|
|
export module Private;
|
|
#ifdef TEST_BADINLINE
|
|
inline void fn_m(); // expected-error {{un-exported inline function not defined before the private module fragment}}
|
|
// expected-note@Private.cppm:13 {{private module fragment begins here}}
|
|
#endif
|
|
static void fn_s();
|
|
export struct X;
|
|
|
|
export void g(X *x) {
|
|
fn_s(); // OK, call to static function in same translation unit
|
|
#ifdef TEST_BADINLINE
|
|
fn_m(); // fn_m is not OK.
|
|
#endif
|
|
}
|
|
export X *factory(); // OK
|
|
|
|
module :private;
|
|
struct X {}; // definition not reachable from importers of A
|
|
X *factory() {
|
|
return new X();
|
|
}
|
|
void fn_m() {}
|
|
void fn_s() {}
|
|
|
|
//--- Use.cpp
|
|
import Private;
|
|
void foo() {
|
|
X x; // expected-error 1+{{missing '#include'; 'X' must be defined before it is used}}
|
|
// expected-note@Private.cppm:18 1+{{definition here is not reachable}}
|
|
auto _ = factory();
|
|
auto *__ = factory();
|
|
X *___ = factory();
|
|
|
|
g(__);
|
|
g(___);
|
|
g(factory());
|
|
}
|