mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-27 01:56:05 +00:00
7b85e76500
Generally, with PGO enabled the C++20 likelyhood attributes shall be
dropped assuming the profile has a good coverage. However, currently
this is not the case for the following code:
if (always_false()) [[likely]] {
...
}
The patch fixes this and drops the attribute, if the parent context was
executed in the profile. The patch still preserves the attribute, if the
parent context was not executed, e.g. to support the cases when the
profile has insufficient coverage.
Differential Revision: https://reviews.llvm.org/D134456
33 lines
755 B
C++
33 lines
755 B
C++
// Test that clang doesn't emit llvm.expect when the counter is 0
|
|
|
|
// RUN: llvm-profdata merge %S/Inputs/cxx-never-executed-branch.proftext -o %t.profdata
|
|
// RUN: %clang_cc1 -std=c++20 %s -triple %itanium_abi_triple -O2 -o - -emit-llvm -fprofile-instrument-use-path=%t.profdata -disable-llvm-passes | FileCheck %s
|
|
|
|
int rand();
|
|
|
|
// CHECK: define {{.*}}@_Z13is_in_profilev
|
|
// CHECK-NOT: call {{.*}}@llvm.expect
|
|
|
|
int is_in_profile() {
|
|
int rando = rand();
|
|
int x = 0;
|
|
if (rando == 0) [[likely]]
|
|
x = 2;
|
|
else
|
|
x = 3;
|
|
return x;
|
|
}
|
|
|
|
// CHECK: define {{.*}}@_Z17is_not_in_profilev
|
|
// CHECK: call {{.*}}@llvm.expect
|
|
|
|
int is_not_in_profile() {
|
|
int rando = rand();
|
|
int x = 0;
|
|
if (rando == 0) [[likely]]
|
|
x = 2;
|
|
else
|
|
x = 3;
|
|
return x;
|
|
}
|