mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-27 15:56:07 +00:00

Without this patch, clang will not wrap in an ElaboratedType node types written without a keyword and nested name qualifier, which goes against the intent that we should produce an AST which retains enough details to recover how things are written. The lack of this sugar is incompatible with the intent of the type printer default policy, which is to print types as written, but to fall back and print them fully qualified when they are desugared. An ElaboratedTypeLoc without keyword / NNS uses no storage by itself, but still requires pointer alignment due to pre-existing bug in the TypeLoc buffer handling. --- Troubleshooting list to deal with any breakage seen with this patch: 1) The most likely effect one would see by this patch is a change in how a type is printed. The type printer will, by design and default, print types as written. There are customization options there, but not that many, and they mainly apply to how to print a type that we somehow failed to track how it was written. This patch fixes a problem where we failed to distinguish between a type that was written without any elaborated-type qualifiers, such as a 'struct'/'class' tags and name spacifiers such as 'std::', and one that has been stripped of any 'metadata' that identifies such, the so called canonical types. Example: ``` namespace foo { struct A {}; A a; }; ``` If one were to print the type of `foo::a`, prior to this patch, this would result in `foo::A`. This is how the type printer would have, by default, printed the canonical type of A as well. As soon as you add any name qualifiers to A, the type printer would suddenly start accurately printing the type as written. This patch will make it print it accurately even when written without qualifiers, so we will just print `A` for the initial example, as the user did not really write that `foo::` namespace qualifier. 2) This patch could expose a bug in some AST matcher. Matching types is harder to get right when there is sugar involved. For example, if you want to match a type against being a pointer to some type A, then you have to account for getting a type that is sugar for a pointer to A, or being a pointer to sugar to A, or both! Usually you would get the second part wrong, and this would work for a very simple test where you don't use any name qualifiers, but you would discover is broken when you do. The usual fix is to either use the matcher which strips sugar, which is annoying to use as for example if you match an N level pointer, you have to put N+1 such matchers in there, beginning to end and between all those levels. But in a lot of cases, if the property you want to match is present in the canonical type, it's easier and faster to just match on that... This goes with what is said in 1), if you want to match against the name of a type, and you want the name string to be something stable, perhaps matching on the name of the canonical type is the better choice. 3) This patch could expose a bug in how you get the source range of some TypeLoc. For some reason, a lot of code is using getLocalSourceRange(), which only looks at the given TypeLoc node. This patch introduces a new, and more common TypeLoc node which contains no source locations on itself. This is not an inovation here, and some other, more rare TypeLoc nodes could also have this property, but if you use getLocalSourceRange on them, it's not going to return any valid locations, because it doesn't have any. The right fix here is to always use getSourceRange() or getBeginLoc/getEndLoc which will dive into the inner TypeLoc to get the source range if it doesn't find it on the top level one. You can use getLocalSourceRange if you are really into micro-optimizations and you have some outside knowledge that the TypeLocs you are dealing with will always include some source location. 4) Exposed a bug somewhere in the use of the normal clang type class API, where you have some type, you want to see if that type is some particular kind, you try a `dyn_cast` such as `dyn_cast<TypedefType>` and that fails because now you have an ElaboratedType which has a TypeDefType inside of it, which is what you wanted to match. Again, like 2), this would usually have been tested poorly with some simple tests with no qualifications, and would have been broken had there been any other kind of type sugar, be it an ElaboratedType or a TemplateSpecializationType or a SubstTemplateParmType. The usual fix here is to use `getAs` instead of `dyn_cast`, which will look deeper into the type. Or use `getAsAdjusted` when dealing with TypeLocs. For some reason the API is inconsistent there and on TypeLocs getAs behaves like a dyn_cast. 5) It could be a bug in this patch perhaps. Let me know if you need any help! Signed-off-by: Matheus Izvekov <mizvekov@gmail.com> Differential Revision: https://reviews.llvm.org/D112374
354 lines
8.8 KiB
C++
354 lines
8.8 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++11 -Wabstract-vbase-init
|
|
|
|
#ifndef __GXX_EXPERIMENTAL_CXX0X__
|
|
#define __CONCAT(__X, __Y) __CONCAT1(__X, __Y)
|
|
#define __CONCAT1(__X, __Y) __X ## __Y
|
|
|
|
#define static_assert(__b, __m) \
|
|
typedef int __CONCAT(__sa, __LINE__)[__b ? 1 : -1]
|
|
#endif
|
|
|
|
union IncompleteUnion;
|
|
|
|
static_assert(!__is_abstract(IncompleteUnion), "unions are never abstract");
|
|
|
|
class C {
|
|
virtual void f() = 0; // expected-note {{unimplemented pure virtual method 'f'}}
|
|
};
|
|
|
|
static_assert(__is_abstract(C), "C has a pure virtual function");
|
|
|
|
class D : C {
|
|
};
|
|
|
|
static_assert(__is_abstract(D), "D inherits from an abstract class");
|
|
|
|
class E : D {
|
|
virtual void f();
|
|
};
|
|
|
|
static_assert(!__is_abstract(E), "E inherits from an abstract class but implements f");
|
|
|
|
C *d = new C; // expected-error {{allocating an object of abstract class type 'C'}}
|
|
|
|
C c; // expected-error {{variable type 'C' is an abstract class}}
|
|
void t1(C c); // expected-error {{parameter type 'C' is an abstract class}}
|
|
void t2(C); // expected-error {{parameter type 'C' is an abstract class}}
|
|
|
|
struct S {
|
|
C c; // expected-error {{field type 'C' is an abstract class}}
|
|
};
|
|
|
|
void t3(const C&);
|
|
|
|
void f() {
|
|
C(); // expected-error {{allocating an object of abstract class type 'C'}}
|
|
t3(C()); // expected-error {{allocating an object of abstract class type 'C'}}
|
|
}
|
|
|
|
C e1[2]; // expected-error {{array of abstract class type 'C'}}
|
|
C (*e2)[2]; // expected-error {{array of abstract class type 'C'}}
|
|
C (**e3)[2]; // expected-error {{array of abstract class type 'C'}}
|
|
|
|
void t4(C c[2]); // expected-error {{array of abstract class type 'C'}}
|
|
|
|
void t5(void (*)(C)); // expected-error {{parameter type 'C' is an abstract class}}
|
|
|
|
typedef void (*Func)(C); // expected-error {{parameter type 'C' is an abstract class}}
|
|
void t6(Func);
|
|
|
|
class F {
|
|
F a() { while (1) {} } // expected-error {{return type 'F' is an abstract class}}
|
|
|
|
class D {
|
|
void f(F c); // expected-error {{parameter type 'F' is an abstract class}}
|
|
};
|
|
|
|
union U {
|
|
void u(F c); // expected-error {{parameter type 'F' is an abstract class}}
|
|
};
|
|
|
|
virtual void f() = 0; // expected-note {{unimplemented pure virtual method 'f'}}
|
|
};
|
|
|
|
// Diagnosing in these cases is prohibitively expensive. We still
|
|
// diagnose at the function definition, of course.
|
|
|
|
class Abstract;
|
|
|
|
void t7(Abstract a);
|
|
|
|
void t8() {
|
|
void h(Abstract a);
|
|
}
|
|
|
|
namespace N {
|
|
void h(Abstract a);
|
|
}
|
|
|
|
class Abstract {
|
|
virtual void f() = 0;
|
|
};
|
|
|
|
// <rdar://problem/6854087>
|
|
class foo {
|
|
public:
|
|
virtual foo *getFoo() = 0;
|
|
};
|
|
|
|
class bar : public foo {
|
|
public:
|
|
virtual bar *getFoo();
|
|
};
|
|
|
|
bar x;
|
|
|
|
// <rdar://problem/6902298>
|
|
class A {
|
|
public:
|
|
virtual void release() = 0;
|
|
virtual void release(int count) = 0;
|
|
virtual void retain() = 0;
|
|
};
|
|
|
|
class B : public A {
|
|
public:
|
|
virtual void release();
|
|
virtual void release(int count);
|
|
virtual void retain();
|
|
};
|
|
|
|
void foo(void) {
|
|
B b;
|
|
}
|
|
|
|
struct K {
|
|
int f;
|
|
virtual ~K();
|
|
};
|
|
|
|
struct L : public K {
|
|
void f();
|
|
};
|
|
|
|
// PR5222
|
|
namespace PR5222 {
|
|
struct A {
|
|
virtual A *clone() = 0;
|
|
};
|
|
struct B : public A {
|
|
virtual B *clone() = 0;
|
|
};
|
|
struct C : public B {
|
|
virtual C *clone();
|
|
};
|
|
|
|
C c;
|
|
}
|
|
|
|
// PR5550 - instantiating template didn't track overridden methods
|
|
namespace PR5550 {
|
|
struct A {
|
|
virtual void a() = 0;
|
|
virtual void b() = 0;
|
|
};
|
|
template<typename T> struct B : public A {
|
|
virtual void b();
|
|
virtual void c() = 0;
|
|
};
|
|
struct C : public B<int> {
|
|
virtual void a();
|
|
virtual void c();
|
|
};
|
|
C x;
|
|
}
|
|
|
|
namespace PureImplicit {
|
|
// A pure virtual destructor should be implicitly overridden.
|
|
struct A { virtual ~A() = 0; };
|
|
struct B : A {};
|
|
B x;
|
|
|
|
// A pure virtual assignment operator should be implicitly overridden.
|
|
struct D;
|
|
struct C { virtual D& operator=(const D&) = 0; };
|
|
struct D : C {};
|
|
D y;
|
|
}
|
|
|
|
namespace test1 {
|
|
struct A {
|
|
virtual void foo() = 0;
|
|
};
|
|
|
|
struct B : A {
|
|
using A::foo;
|
|
};
|
|
|
|
struct C : B {
|
|
void foo();
|
|
};
|
|
|
|
void test() {
|
|
C c;
|
|
}
|
|
}
|
|
|
|
// rdar://problem/8302168
|
|
namespace test2 {
|
|
struct X1 {
|
|
virtual void xfunc(void) = 0; // expected-note {{unimplemented pure virtual method}}
|
|
void g(X1 parm7); // expected-error {{parameter type 'test2::X1' is an abstract class}}
|
|
void g(X1 parm8[2]); // expected-error {{array of abstract class type 'test2::X1'}}
|
|
};
|
|
|
|
template <int N>
|
|
struct X2 {
|
|
virtual void xfunc(void) = 0; // expected-note {{unimplemented pure virtual method}}
|
|
void g(X2 parm10); // expected-error {{parameter type 'X2<N>' is an abstract class}}
|
|
void g(X2 parm11[2]); // expected-error {{array of abstract class type 'X2<N>'}}
|
|
};
|
|
}
|
|
|
|
namespace test3 {
|
|
struct A { // expected-note {{not complete until}}
|
|
A x; // expected-error {{field has incomplete type}}
|
|
virtual void abstract() = 0;
|
|
};
|
|
|
|
struct B { // expected-note {{not complete until}}
|
|
virtual void abstract() = 0;
|
|
B x; // expected-error {{field has incomplete type}}
|
|
};
|
|
|
|
struct C {
|
|
static C x; // expected-error {{abstract class}}
|
|
virtual void abstract() = 0; // expected-note {{unimplemented pure virtual method}}
|
|
};
|
|
|
|
struct D {
|
|
virtual void abstract() = 0; // expected-note {{unimplemented pure virtual method}}
|
|
static D x; // expected-error {{abstract class}}
|
|
};
|
|
}
|
|
|
|
namespace test4 {
|
|
template <class T> struct A {
|
|
A x; // expected-error {{abstract class}}
|
|
virtual void abstract() = 0; // expected-note {{unimplemented pure virtual method}}
|
|
};
|
|
|
|
template <class T> struct B {
|
|
virtual void abstract() = 0; // expected-note {{unimplemented pure virtual method}}
|
|
B x; // expected-error {{abstract class}}
|
|
};
|
|
|
|
template <class T> struct C {
|
|
static C x; // expected-error {{abstract class}}
|
|
virtual void abstract() = 0; // expected-note {{unimplemented pure virtual method}}
|
|
};
|
|
|
|
template <class T> struct D {
|
|
virtual void abstract() = 0; // expected-note {{unimplemented pure virtual method}}
|
|
static D x; // expected-error {{abstract class}}
|
|
};
|
|
}
|
|
|
|
namespace test5 {
|
|
struct A { A(int); virtual ~A() = 0; }; // expected-note {{pure virtual method}}
|
|
const A &a = 0; // expected-error {{abstract class}}
|
|
void f(const A &a = 0); // expected-error {{abstract class}}
|
|
void g(const A &a);
|
|
void h() { g(0); } // expected-error {{abstract class}}
|
|
}
|
|
|
|
// PR9247: Crash on invalid in clang::Sema::ActOnFinishCXXMemberSpecification
|
|
namespace pr9247 {
|
|
struct A {
|
|
virtual void g(const A& input) = 0;
|
|
struct B {
|
|
C* f(int foo);
|
|
};
|
|
};
|
|
}
|
|
|
|
namespace pr12658 {
|
|
class C {
|
|
public:
|
|
C(int v){}
|
|
virtual void f() = 0; // expected-note {{unimplemented pure virtual method 'f' in 'C'}}
|
|
};
|
|
|
|
void foo(const C& c ) {}
|
|
|
|
void bar( void ) {
|
|
foo(C(99)); // expected-error {{allocating an object of abstract class type 'C'}}
|
|
}
|
|
}
|
|
|
|
namespace pr16659 {
|
|
struct A {
|
|
A(int);
|
|
virtual void x() = 0; // expected-note {{unimplemented pure virtual method 'x' in 'RedundantInit'}}
|
|
};
|
|
struct B : virtual A {};
|
|
struct C : B {
|
|
C() : A(37) {}
|
|
void x() override {}
|
|
};
|
|
|
|
struct X {
|
|
friend class Z;
|
|
private:
|
|
X &operator=(const X&);
|
|
};
|
|
struct Y : virtual X { // expected-note {{class 'X' has an inaccessible copy assignment}}
|
|
virtual ~Y() = 0;
|
|
};
|
|
struct Z : Y {}; // expected-note {{class 'Y' has a deleted copy assignment}}
|
|
void f(Z &a, const Z &b) { a = b; } // expected-error {{copy assignment operator is implicitly deleted}}
|
|
|
|
struct RedundantInit : virtual A {
|
|
RedundantInit() : A(0) {} // expected-warning {{initializer for virtual base class 'A' of abstract class 'RedundantInit' will never be used}}
|
|
};
|
|
}
|
|
|
|
struct inline_var { // expected-note {{until the closing '}'}}
|
|
static inline inline_var v = 0; // expected-error {{incomplete type}} expected-warning {{extension}}
|
|
virtual void f() = 0;
|
|
};
|
|
|
|
struct var_template {
|
|
template<typename T>
|
|
static var_template v; // expected-error {{abstract class}} expected-warning {{extension}}
|
|
virtual void f() = 0; // expected-note {{unimplemented}}
|
|
};
|
|
|
|
struct var_template_def { // expected-note {{until the closing '}'}}
|
|
template<typename T>
|
|
static inline var_template_def v = {}; // expected-error {{incomplete type}} expected-warning 2{{extension}}
|
|
virtual void f() = 0;
|
|
};
|
|
|
|
struct friend_fn {
|
|
friend void g(friend_fn); // expected-error {{abstract class}}
|
|
virtual void f() = 0; // expected-note {{unimplemented}}
|
|
};
|
|
|
|
struct friend_fn_def {
|
|
friend void g(friend_fn_def) {} // expected-error {{abstract class}}
|
|
virtual void f() = 0; // expected-note {{unimplemented}}
|
|
};
|
|
|
|
struct friend_template {
|
|
template<typename T>
|
|
friend void g(friend_template); // expected-error {{abstract class}}
|
|
virtual void f() = 0; // expected-note {{unimplemented}}
|
|
};
|
|
|
|
struct friend_template_def {
|
|
template<typename T>
|
|
friend void g(friend_template_def) {} // expected-error {{abstract class}}
|
|
virtual void f() = 0; // expected-note {{unimplemented}}
|
|
};
|