mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-26 20:56:07 +00:00

Without this patch, clang will not wrap in an ElaboratedType node types written without a keyword and nested name qualifier, which goes against the intent that we should produce an AST which retains enough details to recover how things are written. The lack of this sugar is incompatible with the intent of the type printer default policy, which is to print types as written, but to fall back and print them fully qualified when they are desugared. An ElaboratedTypeLoc without keyword / NNS uses no storage by itself, but still requires pointer alignment due to pre-existing bug in the TypeLoc buffer handling. --- Troubleshooting list to deal with any breakage seen with this patch: 1) The most likely effect one would see by this patch is a change in how a type is printed. The type printer will, by design and default, print types as written. There are customization options there, but not that many, and they mainly apply to how to print a type that we somehow failed to track how it was written. This patch fixes a problem where we failed to distinguish between a type that was written without any elaborated-type qualifiers, such as a 'struct'/'class' tags and name spacifiers such as 'std::', and one that has been stripped of any 'metadata' that identifies such, the so called canonical types. Example: ``` namespace foo { struct A {}; A a; }; ``` If one were to print the type of `foo::a`, prior to this patch, this would result in `foo::A`. This is how the type printer would have, by default, printed the canonical type of A as well. As soon as you add any name qualifiers to A, the type printer would suddenly start accurately printing the type as written. This patch will make it print it accurately even when written without qualifiers, so we will just print `A` for the initial example, as the user did not really write that `foo::` namespace qualifier. 2) This patch could expose a bug in some AST matcher. Matching types is harder to get right when there is sugar involved. For example, if you want to match a type against being a pointer to some type A, then you have to account for getting a type that is sugar for a pointer to A, or being a pointer to sugar to A, or both! Usually you would get the second part wrong, and this would work for a very simple test where you don't use any name qualifiers, but you would discover is broken when you do. The usual fix is to either use the matcher which strips sugar, which is annoying to use as for example if you match an N level pointer, you have to put N+1 such matchers in there, beginning to end and between all those levels. But in a lot of cases, if the property you want to match is present in the canonical type, it's easier and faster to just match on that... This goes with what is said in 1), if you want to match against the name of a type, and you want the name string to be something stable, perhaps matching on the name of the canonical type is the better choice. 3) This patch could expose a bug in how you get the source range of some TypeLoc. For some reason, a lot of code is using getLocalSourceRange(), which only looks at the given TypeLoc node. This patch introduces a new, and more common TypeLoc node which contains no source locations on itself. This is not an inovation here, and some other, more rare TypeLoc nodes could also have this property, but if you use getLocalSourceRange on them, it's not going to return any valid locations, because it doesn't have any. The right fix here is to always use getSourceRange() or getBeginLoc/getEndLoc which will dive into the inner TypeLoc to get the source range if it doesn't find it on the top level one. You can use getLocalSourceRange if you are really into micro-optimizations and you have some outside knowledge that the TypeLocs you are dealing with will always include some source location. 4) Exposed a bug somewhere in the use of the normal clang type class API, where you have some type, you want to see if that type is some particular kind, you try a `dyn_cast` such as `dyn_cast<TypedefType>` and that fails because now you have an ElaboratedType which has a TypeDefType inside of it, which is what you wanted to match. Again, like 2), this would usually have been tested poorly with some simple tests with no qualifications, and would have been broken had there been any other kind of type sugar, be it an ElaboratedType or a TemplateSpecializationType or a SubstTemplateParmType. The usual fix here is to use `getAs` instead of `dyn_cast`, which will look deeper into the type. Or use `getAsAdjusted` when dealing with TypeLocs. For some reason the API is inconsistent there and on TypeLocs getAs behaves like a dyn_cast. 5) It could be a bug in this patch perhaps. Let me know if you need any help! Signed-off-by: Matheus Izvekov <mizvekov@gmail.com> Differential Revision: https://reviews.llvm.org/D112374
292 lines
6.7 KiB
C++
292 lines
6.7 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -triple %itanium_abi_triple -verify %s -std=c++11
|
|
// RUN: %clang_cc1 -fsyntax-only -triple %ms_abi_triple -verify %s -std=c++11
|
|
namespace T1 {
|
|
|
|
class A {
|
|
virtual int f(); // expected-note{{overridden virtual function is here}}
|
|
};
|
|
|
|
class B : A {
|
|
virtual void f(); // expected-error{{virtual function 'f' has a different return type ('void') than the function it overrides (which has return type 'int')}}
|
|
};
|
|
|
|
}
|
|
|
|
namespace T2 {
|
|
|
|
struct a { };
|
|
struct b { };
|
|
|
|
class A {
|
|
virtual a* f(); // expected-note{{overridden virtual function is here}}
|
|
};
|
|
|
|
class B : A {
|
|
virtual b* f(); // expected-error{{return type of virtual function 'f' is not covariant with the return type of the function it overrides ('b *' is not derived from 'a *')}}
|
|
};
|
|
|
|
}
|
|
|
|
namespace T3 {
|
|
|
|
struct a { };
|
|
struct b : private a { }; // expected-note{{declared private here}}
|
|
|
|
class A {
|
|
virtual a* f(); // FIXME: desired-note{{overridden virtual function is here}}
|
|
};
|
|
|
|
class B : A {
|
|
virtual b* f(); // expected-error{{invalid covariant return for virtual function: 'a' is a private base class of 'b'}}
|
|
};
|
|
|
|
}
|
|
|
|
namespace T4 {
|
|
|
|
struct a { };
|
|
struct a1 : a { };
|
|
struct b : a, a1 { }; // expected-warning{{direct base 'a' is inaccessible due to ambiguity:\n struct T4::b -> a\n struct T4::b -> a1 -> a}}
|
|
|
|
class A {
|
|
virtual a* f(); // expected-note{{overridden virtual function is here}}
|
|
};
|
|
|
|
class B : A {
|
|
virtual b* f(); // expected-error{{return type of virtual function 'f' is not covariant with the return type of the function it overrides (ambiguous conversion from derived class 'b' to base class 'a':\n\
|
|
struct T4::b -> a\n\
|
|
struct T4::b -> a1 -> a)}}
|
|
};
|
|
|
|
}
|
|
|
|
namespace T5 {
|
|
|
|
struct a { };
|
|
|
|
class A {
|
|
virtual a* const f();
|
|
virtual a* const g(); // expected-note{{overridden virtual function is here}}
|
|
};
|
|
|
|
class B : A {
|
|
virtual a* const f();
|
|
virtual a* g(); // expected-error{{return type of virtual function 'g' is not covariant with the return type of the function it overrides ('a *' has different qualifiers than 'a *const')}}
|
|
};
|
|
|
|
}
|
|
|
|
namespace T6 {
|
|
|
|
struct a { };
|
|
|
|
class A {
|
|
virtual const a* f();
|
|
virtual a* g(); // expected-note{{overridden virtual function is here}}
|
|
};
|
|
|
|
class B : A {
|
|
virtual a* f();
|
|
virtual const a* g(); // expected-error{{return type of virtual function 'g' is not covariant with the return type of the function it overrides (class type 'const a *' is more qualified than class type 'a *'}}
|
|
};
|
|
|
|
}
|
|
|
|
namespace T7 {
|
|
struct a { };
|
|
struct b { };
|
|
|
|
class A {
|
|
a* f();
|
|
};
|
|
|
|
class B : A {
|
|
virtual b* f();
|
|
};
|
|
}
|
|
|
|
namespace T8 {
|
|
struct a { };
|
|
struct b; // expected-note {{forward declaration of 'T8::b'}}
|
|
|
|
class A {
|
|
virtual a *f();
|
|
};
|
|
|
|
class B : A {
|
|
b* f(); // expected-error {{return type of virtual function 'f' is not covariant with the return type of the function it overrides ('b' is incomplete)}}
|
|
};
|
|
}
|
|
|
|
namespace T9 {
|
|
struct a { };
|
|
|
|
template<typename T> struct b : a {
|
|
int a[sizeof(T) ? -1 : -1]; // expected-error {{array with a negative size}}
|
|
};
|
|
|
|
class A {
|
|
virtual a *f();
|
|
};
|
|
|
|
class B : A {
|
|
virtual b<int> *f(); // expected-note {{in instantiation of template class 'T9::b<int>' requested here}}
|
|
};
|
|
}
|
|
|
|
// PR5656
|
|
class X0 {
|
|
virtual void f0();
|
|
};
|
|
class X1 : public X0 {
|
|
void f0() = 0;
|
|
};
|
|
|
|
template <typename Base>
|
|
struct Foo : Base {
|
|
void f(int) = 0; // expected-error{{not virtual and cannot be declared pure}}
|
|
};
|
|
|
|
struct Base1 { virtual void f(int); };
|
|
struct Base2 { };
|
|
|
|
void test() {
|
|
(void)sizeof(Foo<Base1>);
|
|
(void)sizeof(Foo<Base2>); // expected-note{{instantiation}}
|
|
}
|
|
|
|
template<typename Base>
|
|
struct Foo2 : Base {
|
|
template<typename T> int f(T);
|
|
};
|
|
|
|
void test2() {
|
|
Foo2<Base1> f1;
|
|
Foo2<Base2> f2;
|
|
f1.f(17);
|
|
f2.f(17);
|
|
};
|
|
|
|
struct Foo3 {
|
|
virtual void f(int) = 0; // expected-note{{unimplemented pure virtual method}}
|
|
};
|
|
|
|
template<typename T>
|
|
struct Bar3 : Foo3 {
|
|
void f(T);
|
|
};
|
|
|
|
void test3() {
|
|
Bar3<int> b3i; // okay
|
|
Bar3<float> b3f; // expected-error{{is an abstract class}}
|
|
}
|
|
|
|
// 5920
|
|
namespace PR5920 {
|
|
class Base {};
|
|
|
|
template <typename T>
|
|
class Derived : public Base {};
|
|
|
|
class Foo {
|
|
public:
|
|
virtual Base* Method();
|
|
};
|
|
|
|
class Bar : public Foo {
|
|
public:
|
|
virtual Derived<int>* Method();
|
|
};
|
|
}
|
|
|
|
// Look through template types and typedefs to see whether return types are
|
|
// pointers or references.
|
|
namespace PR6110 {
|
|
class Base {};
|
|
class Derived : public Base {};
|
|
|
|
typedef Base* BaseP;
|
|
typedef Derived* DerivedP;
|
|
|
|
class X { virtual BaseP f(); };
|
|
class X1 : public X { virtual DerivedP f(); };
|
|
|
|
template <typename T> class Y { virtual T f(); };
|
|
template <typename T1, typename T> class Y1 : public Y<T> { virtual T1 f(); };
|
|
Y1<Derived*, Base*> y;
|
|
}
|
|
|
|
// Defer checking for covariance if either return type is dependent.
|
|
namespace type_dependent_covariance {
|
|
struct B {};
|
|
template <int N> struct TD : public B {};
|
|
template <> struct TD<1> {};
|
|
|
|
template <int N> struct TB {};
|
|
struct D : public TB<0> {};
|
|
|
|
template <int N> struct X {
|
|
virtual B* f1(); // expected-note{{overridden virtual function is here}}
|
|
virtual TB<N>* f2(); // expected-note{{overridden virtual function is here}}
|
|
};
|
|
template <int N, int M> struct X1 : X<N> {
|
|
virtual TD<M>* f1(); // expected-error{{return type of virtual function 'f1' is not covariant with the return type of the function it overrides ('TD<1> *'}}
|
|
virtual D* f2(); // expected-error{{return type of virtual function 'f2' is not covariant with the return type of the function it overrides ('D *' is not derived from 'TB<1> *')}}
|
|
};
|
|
|
|
X1<0, 0> good;
|
|
X1<0, 1> bad_derived; // expected-note{{instantiation}}
|
|
X1<1, 0> bad_base; // expected-note{{instantiation}}
|
|
}
|
|
|
|
namespace T10 {
|
|
struct A { };
|
|
struct B : A { };
|
|
|
|
struct C {
|
|
virtual A&& f();
|
|
};
|
|
|
|
struct D : C {
|
|
virtual B&& f();
|
|
};
|
|
};
|
|
|
|
namespace T11 {
|
|
struct A { };
|
|
struct B : A { };
|
|
|
|
struct C {
|
|
virtual A& f(); // expected-note {{overridden virtual function is here}}
|
|
};
|
|
|
|
struct D : C {
|
|
virtual B&& f(); // expected-error {{virtual function 'f' has a different return type ('B &&') than the function it overrides (which has return type 'A &')}}
|
|
};
|
|
};
|
|
|
|
namespace T12 {
|
|
struct A { };
|
|
struct B : A { };
|
|
|
|
struct C {
|
|
virtual A&& f(); // expected-note {{overridden virtual function is here}}
|
|
};
|
|
|
|
struct D : C {
|
|
virtual B& f(); // expected-error {{virtual function 'f' has a different return type ('B &') than the function it overrides (which has return type 'A &&')}}
|
|
};
|
|
};
|
|
|
|
namespace PR8168 {
|
|
class A {
|
|
public:
|
|
virtual void foo() {} // expected-note{{overridden virtual function is here}}
|
|
};
|
|
|
|
class B : public A {
|
|
public:
|
|
static void foo() {} // expected-error{{'static' member function 'foo' overrides a virtual function}}
|
|
};
|
|
}
|