mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-27 08:46:06 +00:00
eb10b065f2
Background: ----------- There are two related argument types which can be sent into a diagnostic to display the name of an entity: DeclarationName (ak_declarationname) or NamedDecl* (ak_nameddecl) (there is also ak_identifierinfo for IdentifierInfo*, but we are not concerned with it here). A DeclarationName in a diagnostic will just be streamed to the output, which will directly result in a call to DeclarationName::print. A NamedDecl* in a diagnostic will also ultimately result in a call to DeclarationName::print, but with two customisation points along the way: The first customisation point is NamedDecl::getNameForDiagnostic which is overloaded by FunctionDecl, ClassTemplateSpecializationDecl and VarTemplateSpecializationDecl to print the template arguments, if any. The second customisation point is NamedDecl::printName. By default it just streams the stored DeclarationName into the output but it can be customised to provide a user-friendly name for an entity. It is currently overloaded by DecompositionDecl and MSGuidDecl. What this patch does: --------------------- For many diagnostics a DeclarationName is used instead of the NamedDecl*. This bypasses the two customisation points mentioned above. This patches fix this for diagnostics in Sema.cpp, SemaCast.cpp, SemaChecking.cpp, SemaDecl.cpp, SemaDeclAttr.cpp, SemaDecl.cpp, SemaOverload.cpp and SemaStmt.cpp. I have only modified diagnostics where I could construct a test-case which demonstrates that the change is appropriate (either with this patch or the next one). Reviewed By: erichkeane, aaron.ballman Differential Revision: https://reviews.llvm.org/D84656
56 lines
1.4 KiB
C++
56 lines
1.4 KiB
C++
// RUN: %clang_cc1 -verify -fsyntax-only -Wlarge-by-value-copy=100 %s
|
|
|
|
// rdar://8548050
|
|
namespace rdar8548050 {
|
|
|
|
struct S100 {
|
|
char x[100];
|
|
};
|
|
|
|
struct S101 {
|
|
char x[101];
|
|
};
|
|
|
|
S100 f100(S100 s) { return s; }
|
|
|
|
S101 f101(S101 s) { return s; } // expected-warning {{return value of 'f101' is a large (101 bytes) pass-by-value object}} \
|
|
// expected-warning {{'s' is a large (101 bytes) pass-by-value argument}}
|
|
|
|
void f101_no_param_name(S101) {} // expected-warning {{'' is a large (101 bytes) pass-by-value argument}}
|
|
|
|
// FIXME: Don't warn when when the return value is subject to (N)RVO.
|
|
|
|
template <typename T> T foo_template(T);
|
|
template <> S101 foo_template(S101) { return S101(); } // expected-warning {{return value of 'foo_template<rdar8548050::S101>' is a large}}
|
|
// expected-warning@-1 {{'' is a large (101 bytes) pass-by-value argument}}
|
|
|
|
typedef int Arr[200];
|
|
void farr(Arr a) { }
|
|
|
|
struct NonPOD {
|
|
char x[200];
|
|
virtual void m();
|
|
};
|
|
|
|
NonPOD fNonPOD(NonPOD s) { return s; }
|
|
|
|
template <unsigned size>
|
|
struct TS {
|
|
char x[size];
|
|
};
|
|
|
|
template <unsigned size>
|
|
void tf(TS<size> ts) {} // expected-warning {{ts' is a large (300 bytes) pass-by-value argument}}
|
|
|
|
void g() {
|
|
TS<300> ts;
|
|
tf<300>(ts); // expected-note {{instantiation}}
|
|
}
|
|
|
|
}
|
|
|
|
template<typename T> class DependentPOD {
|
|
enum b { x };
|
|
b foo() { return x; }
|
|
};
|