mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-24 21:56:04 +00:00
0c8d6df362
The last argument of an FP-classify function was checked for vailidity as an expression, but we never ensured that the usual unary conversions/etc properly resulted in a valid value. Thus, when we got the value, it was null, so we had a null dereference. This patch instead fails out/marks the function call as invalid if the argument is incorrect. I DID consider just allowing it to continue, but the result was an extraneous error about how the last argument wasn't a float (in this case, it was an overload set). Fixes: #107411
22 lines
1.3 KiB
C
22 lines
1.3 KiB
C
// RUN: %clang_cc1 %s -fsyntax-only -verify -pedantic
|
|
void check(int);
|
|
void a(void) {
|
|
check(__builtin_isfinite(1.0f));
|
|
check(__builtin_isinf(1.0));
|
|
check(__builtin_isinf_sign(1.0L));
|
|
check(__builtin_isnan(1.0f));
|
|
check(__builtin_isnormal(1.0f));
|
|
check(__builtin_isfinite(1)); // expected-error{{requires argument of floating point type}}
|
|
check(__builtin_isinf()); // expected-error{{too few arguments}}
|
|
check(__builtin_isnan(1,2)); // expected-error{{too many arguments}}
|
|
check(__builtin_fpclassify(0, 0, 0, 0, 0, 1.0));
|
|
check(__builtin_fpclassify(0, 0, 0, 0, 0, 1)); // expected-error{{requires argument of floating point type}}
|
|
check(__builtin_fpclassify(0, 1, 2, 3, 4.5, 5.0)); // expected-warning{{implicit conversion from 'double' to 'int' changes value from 4.5 to 4}}
|
|
check(__builtin_fpclassify(0, 0, 0, 0, 1)); // expected-error{{too few arguments}}
|
|
check(__builtin_fpclassify(0, 0, 0, 0, 0, 1, 0)); // expected-error{{too many arguments}}
|
|
|
|
check(__builtin_fpclassify(0,0,0,0,0, (invalid))); // expected-error{{use of undeclared identifier 'invalid'}}
|
|
check(__builtin_fpclassify(0,0,0,0,0, (inf))); // expected-error{{use of undeclared identifier 'inf'}}
|
|
// expected-error@-1{{reference to overloaded function could not be resolved}}
|
|
}
|