mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 00:06:05 +00:00
882915df61
Ensures an -Wenum-conversion warning happens when one of the enums is
signed and the other is unsigned. Also adds a test file to verify these
warnings.
This warning would not happen since the -Wsign-conversion would make a
diagnostic then return, never allowing the -Wenum-conversion checks.
For example:
C
enum PE { P = -1 };
enum NE { N };
enum NE conv(enum PE E) { return E; }
Before this would only create a diagnostic with -Wsign-conversion and
never on -Wenum-conversion. Now it will create a diagnostic for both
-Wsign-conversion and -Wenum-conversion.
I could change it to just warn on -Wenum-conversion as that was what I
initially did. Seeing PR35200 (or GitHub Issue 316268), I let both
diagnostics check so that the sign conversion could generate a warning.
26 lines
924 B
C
26 lines
924 B
C
// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -fsyntax-only -Wenum-conversion -verify %s
|
|
// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -fsyntax-only -Wconversion -verify %s
|
|
|
|
// Signed enums
|
|
enum SE1 { N1 = -1 };
|
|
enum SE2 { N2 = -2 };
|
|
// Unsigned unums
|
|
enum UE1 { P1 };
|
|
enum UE2 { P2 };
|
|
|
|
enum UE2 f1(enum UE1 E) {
|
|
return E; // expected-warning {{implicit conversion from enumeration type 'enum UE1' to different enumeration type 'enum UE2'}}
|
|
}
|
|
|
|
enum SE1 f2(enum UE1 E) {
|
|
return E; // expected-warning {{implicit conversion from enumeration type 'enum UE1' to different enumeration type 'enum SE1'}}
|
|
}
|
|
|
|
enum UE1 f3(enum SE1 E) {
|
|
return E; // expected-warning {{implicit conversion from enumeration type 'enum SE1' to different enumeration type 'enum UE1'}}
|
|
}
|
|
|
|
enum SE2 f4(enum SE1 E) {
|
|
return E; // expected-warning {{implicit conversion from enumeration type 'enum SE1' to different enumeration type 'enum SE2'}}
|
|
}
|