mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 05:46:06 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
55 lines
2.2 KiB
C
55 lines
2.2 KiB
C
// RUN: %clang_cc1 %s -fsyntax-only -Wno-unused-value -Wbad-function-cast -ffixed-point -triple x86_64-unknown-unknown -verify
|
|
|
|
void vf(void);
|
|
int if1(void);
|
|
char if2(void);
|
|
long if3(void);
|
|
float rf1(void);
|
|
double rf2(void);
|
|
_Complex double cf(void);
|
|
enum e { E1 } ef(void);
|
|
_Bool bf(void);
|
|
char *pf1(void);
|
|
int *pf2(void);
|
|
_Fract ff1(void);
|
|
|
|
void
|
|
foo(void)
|
|
{
|
|
|
|
/* default, no cast, should always be ok */
|
|
ff1();
|
|
/* Casts to void types are always OK. */
|
|
(void)vf();
|
|
(void)if1();
|
|
(void)cf();
|
|
(const void)bf();
|
|
(void)ff1();
|
|
/* Casts to the same type or similar types are OK. */
|
|
(int)if1();
|
|
(long)if2();
|
|
(char)if3();
|
|
(float)rf1();
|
|
(long double)rf2();
|
|
(_Complex float)cf();
|
|
(enum f { F1 })ef();
|
|
(_Bool)bf();
|
|
(void *)pf1();
|
|
(char *)pf2();
|
|
(_Fract) ff1();
|
|
/* All following casts issue warning */
|
|
(float)if1(); /* expected-warning {{cast from function call of type 'int' to non-matching type 'float'}} */
|
|
(double)if2(); /* expected-warning {{cast from function call of type 'char' to non-matching type 'double'}} */
|
|
(_Bool)if3(); /* expected-warning {{cast from function call of type 'long' to non-matching type '_Bool'}} */
|
|
(int)rf1(); /* expected-warning {{cast from function call of type 'float' to non-matching type 'int'}} */
|
|
(long)rf2(); /* expected-warning {{cast from function call of type 'double' to non-matching type 'long'}} */
|
|
(double)cf(); /* expected-warning {{cast from function call of type '_Complex double' to non-matching type 'double'}} */
|
|
(int)ef(); /* expected-warning {{cast from function call of type 'enum e' to non-matching type 'int'}} */
|
|
(int)bf(); /* expected-warning {{cast from function call of type '_Bool' to non-matching type 'int'}} */
|
|
(__SIZE_TYPE__)pf1(); /* expected-warning {{cast from function call of type 'char *' to non-matching type 'unsigned long'}} */
|
|
(__PTRDIFF_TYPE__)pf2(); /* expected-warning {{cast from function call of type 'int *' to non-matching type 'long'}} */
|
|
(_Fract) if1(); /* expected-warning{{cast from function call of type 'int' to non-matching type '_Fract'}} */
|
|
(int)ff1(); /* expected-warning{{cast from function call of type '_Fract' to non-matching type 'int'}} */
|
|
}
|
|
|