mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 03:46:07 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
100 lines
3.5 KiB
C
100 lines
3.5 KiB
C
// RUN: %clang_cc1 -verify -fsyntax-only -fblocks -Wshadow %s
|
|
|
|
int i; // expected-note 4 {{previous declaration is here}}
|
|
static int s; // expected-note 2 {{previous declaration is here}}
|
|
|
|
void foo(void) {
|
|
int pass1;
|
|
int i; // expected-warning {{declaration shadows a variable in the global scope}} \
|
|
// expected-note {{previous declaration is here}}
|
|
int s; // expected-warning {{declaration shadows a variable in the global scope}} \
|
|
// expected-note {{previous declaration is here}}
|
|
{
|
|
int pass2;
|
|
int i; // expected-warning {{declaration shadows a local variable}} \
|
|
// expected-note {{previous declaration is here}}
|
|
int s; // expected-warning {{declaration shadows a local variable}} \
|
|
// expected-note {{previous declaration is here}}
|
|
{
|
|
int pass3;
|
|
int i; // expected-warning {{declaration shadows a local variable}}
|
|
int s; // expected-warning {{declaration shadows a local variable}}
|
|
}
|
|
}
|
|
|
|
int sin; // okay; 'sin' has not been declared, even though it's a builtin.
|
|
}
|
|
|
|
void (^test1)(int) = ^(int i) { // expected-warning {{declaration shadows a variable in the global scope}} \
|
|
// expected-note{{previous declaration is here}}
|
|
{
|
|
int i; // expected-warning {{declaration shadows a local variable}} \
|
|
// expected-note{{previous declaration is here}}
|
|
|
|
(^(int i) { return i; })(i); //expected-warning {{declaration shadows a local variable}}
|
|
}
|
|
};
|
|
|
|
|
|
struct test2 {
|
|
int i;
|
|
};
|
|
|
|
void test3(void) {
|
|
struct test4 {
|
|
int i;
|
|
};
|
|
}
|
|
|
|
void test4(int i) { // expected-warning {{declaration shadows a variable in the global scope}}
|
|
}
|
|
|
|
// Don't warn about shadowing for function declarations.
|
|
void test5(int i);
|
|
void test6(void (*f)(int i)) {}
|
|
void test7(void *context, void (*callback)(void *context)) {}
|
|
|
|
extern int bob; // expected-note {{previous declaration is here}}
|
|
|
|
void rdar8883302(void) {
|
|
extern int bob; // don't warn for shadowing.
|
|
}
|
|
|
|
void test8(void) {
|
|
int bob; // expected-warning {{declaration shadows a variable in the global scope}}
|
|
}
|
|
|
|
enum PR24718_1{pr24718}; // expected-note {{previous declaration is here}}
|
|
void PR24718(void) {
|
|
enum PR24718_2{pr24718}; // expected-warning {{declaration shadows a variable in the global scope}}
|
|
}
|
|
|
|
struct PR24718_3;
|
|
struct PR24718_4 {
|
|
enum {
|
|
PR24718_3 // Does not shadow a type.
|
|
};
|
|
};
|
|
|
|
void static_locals() {
|
|
static int i; // expected-warning {{declaration shadows a variable in the global scope}}
|
|
// expected-note@-1 {{previous definition is here}}
|
|
// expected-note@-2 {{previous declaration is here}}
|
|
int i; // expected-error {{non-static declaration of 'i' follows static declaration}}
|
|
static int foo; // expected-note {{previous declaration is here}}
|
|
static int hoge; // expected-note {{previous declaration is here}}
|
|
int s; // expected-warning {{declaration shadows a variable in the global scope}}
|
|
{
|
|
static int foo; // expected-warning {{declaration shadows a local variable}}
|
|
// expected-note@-1 {{previous declaration is here}}
|
|
static int i; // expected-warning {{declaration shadows a local variable}}
|
|
// expected-note@-1 {{previous declaration is here}}
|
|
int hoge; // expected-warning {{declaration shadows a local variable}}
|
|
{
|
|
static int foo; // expected-warning {{declaration shadows a local variable}}
|
|
int i; // expected-warning {{declaration shadows a local variable}}
|
|
extern int hoge;
|
|
}
|
|
}
|
|
}
|