mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 00:16:05 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
113 lines
3.7 KiB
C
113 lines
3.7 KiB
C
// RUN: %clang_cc1 -std=c11 -fsyntax-only -verify -Wunused-value -Wunused-label %s
|
|
// RUN: %clang_cc1 -std=c11 -fsyntax-only -verify -Wunused %s
|
|
// RUN: %clang_cc1 -std=c11 -fsyntax-only -verify -Wall %s
|
|
|
|
int i = 0;
|
|
int j = 0;
|
|
|
|
void foo(void);
|
|
|
|
// PR4806
|
|
void pr4806(void) {
|
|
1,foo(); // expected-warning {{left operand of comma operator has no effect}}
|
|
|
|
// other
|
|
foo();
|
|
i; // expected-warning {{expression result unused}}
|
|
|
|
i,foo(); // expected-warning {{left operand of comma operator has no effect}}
|
|
foo(),i; // expected-warning {{expression result unused}}
|
|
|
|
i,j,foo(); // expected-warning 2{{left operand of comma operator has no effect}}
|
|
i,foo(),j; // expected-warning {{left operand of comma operator has no effect}} expected-warning {{expression result unused}}
|
|
foo(),i,j; // expected-warning {{expression result unused}} expected-warning {{left operand of comma operator has no effect}}
|
|
|
|
i++;
|
|
|
|
i++,foo();
|
|
foo(),i++;
|
|
|
|
i++,j,foo(); // expected-warning {{left operand of comma operator has no effect}}
|
|
i++,foo(),j; // expected-warning {{expression result unused}}
|
|
foo(),i++,j; // expected-warning {{expression result unused}}
|
|
|
|
i,j++,foo(); // expected-warning {{left operand of comma operator has no effect}}
|
|
i,foo(),j++; // expected-warning {{left operand of comma operator has no effect}}
|
|
foo(),i,j++; // expected-warning {{left operand of comma operator has no effect}}
|
|
|
|
i++,j++,foo();
|
|
i++,foo(),j++;
|
|
foo(),i++,j++;
|
|
|
|
{};
|
|
({});
|
|
({}),foo();
|
|
foo(),({});
|
|
|
|
(int)1U; // expected-warning {{expression result unused}}
|
|
(void)1U;
|
|
|
|
// pointer to volatile has side effect (thus no warning)
|
|
int* pi = &i;
|
|
volatile int* pj = &j;
|
|
*pi; // expected-warning {{expression result unused}}
|
|
*pj;
|
|
|
|
foo_label: // expected-warning {{unused label}}
|
|
i; // expected-warning {{expression result unused}}
|
|
}
|
|
|
|
// Don't warn about unused '||', '&&' expressions that contain assignments.
|
|
int test_logical_foo1(void);
|
|
int test_logical_foo2(void);
|
|
int test_logical_foo3(void);
|
|
int test_logical_bar(void) {
|
|
int x = 0;
|
|
(x = test_logical_foo1()) || // no-warning
|
|
(x = test_logical_foo2()) || // no-warning
|
|
(x = test_logical_foo3()); // no-warning
|
|
|
|
x || test_logical_foo1(); // no-warning
|
|
|
|
return x;
|
|
}
|
|
|
|
// PR8282
|
|
void conditional_for_control_flow(int cond, int x, int y)
|
|
{
|
|
cond? y++ : x; // no-warning
|
|
cond? y : ++x; // no-warning
|
|
cond? (x |= y) : ++x; // no-warning
|
|
cond? y : x; // expected-warning {{expression result unused}}
|
|
}
|
|
|
|
struct s0 { int f0; };
|
|
|
|
void f0(int a);
|
|
void f1(struct s0 *a) {
|
|
f0((int)(a->f0 + 1, 10)); // expected-warning {{left operand of comma operator has no effect}}
|
|
}
|
|
|
|
void blah(int a);
|
|
#define GenTest(x) _Generic(x, default : blah)(x)
|
|
|
|
void unevaluated_operands(void) {
|
|
int val = 0;
|
|
|
|
(void)sizeof(++val); // expected-warning {{expression with side effects has no effect in an unevaluated context}}
|
|
(void)_Generic(val++, default : 0); // expected-warning {{expression with side effects has no effect in an unevaluated context}}
|
|
(void)_Alignof(val++); // expected-warning {{expression with side effects has no effect in an unevaluated context}} expected-warning {{'_Alignof' applied to an expression is a GNU extension}}
|
|
|
|
// VLAs can have side effects so long as it's part of the type and not an
|
|
// expression, except for sizeof() where it can also have a side effect if
|
|
// the operand is of VLA type.
|
|
(void)sizeof(int[++val]); // Ok
|
|
(void)_Alignof(int[++val]); // Ok
|
|
|
|
int GH48010[val];
|
|
(void)sizeof(*(val = 1, &GH48010)); // Ok
|
|
|
|
// Side effects as part of macro expansion are ok.
|
|
GenTest(val++);
|
|
}
|