mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 06:06:06 +00:00
ca61961380
Implement https://cplusplus.github.io/CWG/issues/2631.html. Immediate calls in default arguments and defaults members are not evaluated. Instead, we evaluate them when constructing a `CXXDefaultArgExpr`/`BuildCXXDefaultInitExpr`. The immediate calls are executed by doing a transform on the initializing expression. Note that lambdas are not considering subexpressions so we do not need to transform them. As a result of this patch, unused default member initializers are not considered odr-used, and errors about members binding to local variables in an outer scope only surface at the point where a constructor is defined. Reviewed By: aaron.ballman, #clang-language-wg, rupprecht Differential Revision: https://reviews.llvm.org/D136554
124 lines
3.9 KiB
C++
124 lines
3.9 KiB
C++
//===- UsedDeclVisitor.h - ODR-used declarations visitor --------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines UsedDeclVisitor, a CRTP class which visits all the
|
|
// declarations that are ODR-used by an expression or statement.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_CLANG_LIB_SEMA_USEDDECLVISITOR_H
|
|
#define LLVM_CLANG_LIB_SEMA_USEDDECLVISITOR_H
|
|
|
|
#include "clang/AST/EvaluatedExprVisitor.h"
|
|
#include "clang/Sema/SemaInternal.h"
|
|
|
|
namespace clang {
|
|
template <class Derived>
|
|
class UsedDeclVisitor : public EvaluatedExprVisitor<Derived> {
|
|
protected:
|
|
Sema &S;
|
|
|
|
public:
|
|
typedef EvaluatedExprVisitor<Derived> Inherited;
|
|
|
|
UsedDeclVisitor(Sema &S) : Inherited(S.Context), S(S) {}
|
|
|
|
Derived &asImpl() { return *static_cast<Derived *>(this); }
|
|
|
|
void VisitDeclRefExpr(DeclRefExpr *E) {
|
|
auto *D = E->getDecl();
|
|
if (isa<FunctionDecl>(D) || isa<VarDecl>(D)) {
|
|
asImpl().visitUsedDecl(E->getLocation(), D);
|
|
}
|
|
}
|
|
|
|
void VisitMemberExpr(MemberExpr *E) {
|
|
auto *D = E->getMemberDecl();
|
|
if (isa<FunctionDecl>(D) || isa<VarDecl>(D)) {
|
|
asImpl().visitUsedDecl(E->getMemberLoc(), D);
|
|
}
|
|
asImpl().Visit(E->getBase());
|
|
}
|
|
|
|
void VisitCapturedStmt(CapturedStmt *Node) {
|
|
asImpl().visitUsedDecl(Node->getBeginLoc(), Node->getCapturedDecl());
|
|
Inherited::VisitCapturedStmt(Node);
|
|
}
|
|
|
|
void VisitCXXBindTemporaryExpr(CXXBindTemporaryExpr *E) {
|
|
asImpl().visitUsedDecl(
|
|
E->getBeginLoc(),
|
|
const_cast<CXXDestructorDecl *>(E->getTemporary()->getDestructor()));
|
|
asImpl().Visit(E->getSubExpr());
|
|
}
|
|
|
|
void VisitCXXNewExpr(CXXNewExpr *E) {
|
|
if (E->getOperatorNew())
|
|
asImpl().visitUsedDecl(E->getBeginLoc(), E->getOperatorNew());
|
|
if (E->getOperatorDelete())
|
|
asImpl().visitUsedDecl(E->getBeginLoc(), E->getOperatorDelete());
|
|
Inherited::VisitCXXNewExpr(E);
|
|
}
|
|
|
|
void VisitCXXDeleteExpr(CXXDeleteExpr *E) {
|
|
if (E->getOperatorDelete())
|
|
asImpl().visitUsedDecl(E->getBeginLoc(), E->getOperatorDelete());
|
|
QualType DestroyedOrNull = E->getDestroyedType();
|
|
if (!DestroyedOrNull.isNull()) {
|
|
QualType Destroyed = S.Context.getBaseElementType(DestroyedOrNull);
|
|
if (const RecordType *DestroyedRec = Destroyed->getAs<RecordType>()) {
|
|
CXXRecordDecl *Record = cast<CXXRecordDecl>(DestroyedRec->getDecl());
|
|
if (Record->getDefinition())
|
|
asImpl().visitUsedDecl(E->getBeginLoc(), S.LookupDestructor(Record));
|
|
}
|
|
}
|
|
|
|
Inherited::VisitCXXDeleteExpr(E);
|
|
}
|
|
|
|
void VisitCXXConstructExpr(CXXConstructExpr *E) {
|
|
asImpl().visitUsedDecl(E->getBeginLoc(), E->getConstructor());
|
|
CXXConstructorDecl *D = E->getConstructor();
|
|
for (const CXXCtorInitializer *Init : D->inits()) {
|
|
if (Init->isInClassMemberInitializer())
|
|
asImpl().Visit(Init->getInit());
|
|
}
|
|
Inherited::VisitCXXConstructExpr(E);
|
|
}
|
|
|
|
void VisitCXXDefaultArgExpr(CXXDefaultArgExpr *E) {
|
|
asImpl().Visit(E->getExpr());
|
|
Inherited::VisitCXXDefaultArgExpr(E);
|
|
}
|
|
|
|
void VisitCXXDefaultInitExpr(CXXDefaultInitExpr *E) {
|
|
asImpl().Visit(E->getExpr());
|
|
Inherited::VisitCXXDefaultInitExpr(E);
|
|
}
|
|
|
|
void VisitInitListExpr(InitListExpr *ILE) {
|
|
if (ILE->hasArrayFiller())
|
|
asImpl().Visit(ILE->getArrayFiller());
|
|
Inherited::VisitInitListExpr(ILE);
|
|
}
|
|
|
|
void visitUsedDecl(SourceLocation Loc, Decl *D) {
|
|
if (auto *CD = dyn_cast<CapturedDecl>(D)) {
|
|
if (auto *S = CD->getBody()) {
|
|
asImpl().Visit(S);
|
|
}
|
|
} else if (auto *CD = dyn_cast<BlockDecl>(D)) {
|
|
if (auto *S = CD->getBody()) {
|
|
asImpl().Visit(S);
|
|
}
|
|
}
|
|
}
|
|
};
|
|
} // end namespace clang
|
|
|
|
#endif // LLVM_CLANG_LIB_SEMA_USEDDECLVISITOR_H
|