mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-30 09:56:07 +00:00
866bec7d3f
## Why
Currently, the following does not work when compiled with clang:
```c++
#include <cmath>
struct ConvertibleToFloat {
operator float();
};
bool test(ConvertibleToFloat x) {
return std::isnormal(x);
}
```
See https://godbolt.org/z/5bos8v67T for differences with respect to
msvc, gcc or icx. It fails for `float`, `double` and `long double` (all
cv-unqualified floating-point types).
## What
Test and provide overloads as expected by the ISO C++ standard. The
classification/comparison function `isnormal` is defined since C++11
until C++23 as
```c++
bool isnormal( float num );
bool isnormal( double num );
bool isnormal( long double num );
```
and since C++23 as
```c++
constexpr bool isnormal( /* floating-point-type */ num );
```
for which "the library provides overloads for all cv-unqualified
floating-point types as the type of the parameter num". See §28.7.1/1 in
the [ISO C++
standard](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/n4950.pdf)
or check
[cppreference](https://en.cppreference.com/w/cpp/numeric/math/isnormal).
85 lines
2.4 KiB
C++
85 lines
2.4 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// bool isfinite(floating-point-type x); // constexpr since C++23
|
|
|
|
// We don't control the implementation on windows
|
|
// UNSUPPORTED: windows
|
|
|
|
#include <cassert>
|
|
#include <cmath>
|
|
#include <limits>
|
|
|
|
#include "test_macros.h"
|
|
#include "type_algorithms.h"
|
|
|
|
struct TestFloat {
|
|
template <class T>
|
|
static TEST_CONSTEXPR_CXX23 bool test() {
|
|
assert(std::isnormal(std::numeric_limits<T>::max()));
|
|
assert(!std::isnormal(std::numeric_limits<T>::infinity()));
|
|
assert(std::isnormal(std::numeric_limits<T>::min()));
|
|
assert(!std::isnormal(std::numeric_limits<T>::denorm_min()));
|
|
assert(std::isnormal(std::numeric_limits<T>::lowest()));
|
|
assert(!std::isnormal(-std::numeric_limits<T>::infinity()));
|
|
assert(!std::isnormal(T(0)));
|
|
assert(!std::isnormal(std::numeric_limits<T>::quiet_NaN()));
|
|
assert(!std::isnormal(std::numeric_limits<T>::signaling_NaN()));
|
|
|
|
return true;
|
|
}
|
|
|
|
template <class T>
|
|
TEST_CONSTEXPR_CXX23 void operator()() {
|
|
test<T>();
|
|
#if TEST_STD_VER >= 23
|
|
static_assert(test<T>());
|
|
#endif
|
|
}
|
|
};
|
|
|
|
struct TestInt {
|
|
template <class T>
|
|
static TEST_CONSTEXPR_CXX23 bool test() {
|
|
assert(std::isnormal(std::numeric_limits<T>::max()));
|
|
assert(std::isnormal(std::numeric_limits<T>::lowest()) == std::is_signed<T>::value);
|
|
assert(!std::isnormal(T(0)));
|
|
|
|
return true;
|
|
}
|
|
|
|
template <class T>
|
|
TEST_CONSTEXPR_CXX23 void operator()() {
|
|
test<T>();
|
|
#if TEST_STD_VER >= 23
|
|
static_assert(test<T>());
|
|
#endif
|
|
}
|
|
};
|
|
|
|
template <typename T>
|
|
struct ConvertibleTo {
|
|
operator T() const { return T(1); }
|
|
};
|
|
|
|
int main(int, char**) {
|
|
types::for_each(types::floating_point_types(), TestFloat());
|
|
types::for_each(types::integral_types(), TestInt());
|
|
|
|
// Make sure we can call `std::isnormal` with convertible types. This checks
|
|
// whether overloads for all cv-unqualified floating-point types are working
|
|
// as expected.
|
|
{
|
|
assert(std::isnormal(ConvertibleTo<float>()));
|
|
assert(std::isnormal(ConvertibleTo<double>()));
|
|
assert(std::isnormal(ConvertibleTo<long double>()));
|
|
}
|
|
|
|
return 0;
|
|
}
|