mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-26 13:36:08 +00:00
16975a638d
When parsing a C++17 binding declaration, we first create the BindingDecls in Sema::ActOnDecompositionDeclarator, and then build the DecompositionDecl in Sema::ActOnVariableDeclarator, so the contained BindingDecls are never null. But when deserializing, we read the DecompositionDecl with all properties before filling in the Bindings. Among other things, reading a declaration reads whether it's invalid, then calling setInvalidDecl which assumes that all bindings of the DecompositionDecl are available, but that isn't the case. Deserialization should just set all properties directly without invoking subsequent functions, so we just set the flag without using the setter. Fixes PR34960. Reviewed By: rsmith Differential Revision: https://reviews.llvm.org/D86207
38 lines
1.0 KiB
C++
38 lines
1.0 KiB
C++
// No PCH:
|
|
// RUN: %clang_cc1 -pedantic -std=c++1z -include %s -verify %s
|
|
//
|
|
// With PCH:
|
|
// RUN: %clang_cc1 -pedantic -std=c++1z -emit-pch -fallow-pch-with-compiler-errors %s -o %t
|
|
// RUN: %clang_cc1 -pedantic -std=c++1z -include-pch %t -fallow-pch-with-compiler-errors -verify %s
|
|
|
|
// RUN: %clang_cc1 -pedantic -std=c++1z -emit-pch -fallow-pch-with-compiler-errors -fpch-instantiate-templates %s -o %t
|
|
// RUN: %clang_cc1 -pedantic -std=c++1z -include-pch %t -fallow-pch-with-compiler-errors -verify %s
|
|
|
|
#ifndef HEADER
|
|
#define HEADER
|
|
|
|
template<typename T> auto decomp(const T &t) {
|
|
auto &[a, b] = t;
|
|
return a + b;
|
|
}
|
|
|
|
struct Q { int a, b; };
|
|
constexpr int foo(Q &&q) {
|
|
auto &[a, b] = q;
|
|
return a * 10 + b;
|
|
}
|
|
|
|
auto [noinit]; // expected-error{{decomposition declaration '[noinit]' requires an initializer}}
|
|
|
|
#else
|
|
|
|
int arr[2];
|
|
int k = decomp(arr);
|
|
|
|
static_assert(foo({1, 2}) == 12);
|
|
|
|
// expected-error@15 {{cannot decompose non-class, non-array type 'const int'}}
|
|
int z = decomp(10); // expected-note {{instantiation of}}
|
|
|
|
#endif
|