mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-27 18:46:04 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
94 lines
2.7 KiB
C
94 lines
2.7 KiB
C
// RUN: %clang_cc1 -fsyntax-only -verify %s
|
|
|
|
int foo(int x) {
|
|
return x == x; // expected-warning {{self-comparison always evaluates to true}}
|
|
}
|
|
|
|
int foo2(int x) {
|
|
return (x) != (((x))); // expected-warning {{self-comparison always evaluates to false}}
|
|
}
|
|
|
|
void foo3(short s, short t) {
|
|
if (s == s) {} // expected-warning {{self-comparison always evaluates to true}}
|
|
if (s == t) {} // no-warning
|
|
}
|
|
|
|
void foo4(void* v, void* w) {
|
|
if (v == v) {} // expected-warning {{self-comparison always evaluates to true}}
|
|
if (v == w) {} // no-warning
|
|
}
|
|
|
|
int qux(int x) {
|
|
return x < x; // expected-warning {{self-comparison}}
|
|
}
|
|
|
|
int qux2(int x) {
|
|
return x > x; // expected-warning {{self-comparison}}
|
|
}
|
|
|
|
int bar(float x) {
|
|
return x == x; // no-warning
|
|
}
|
|
|
|
int bar2(float x) {
|
|
return x != x; // no-warning
|
|
}
|
|
|
|
#define IS_THE_ANSWER(x) (x == 42)
|
|
|
|
int macro_comparison(void) {
|
|
return IS_THE_ANSWER(42);
|
|
}
|
|
|
|
// Don't complain in unevaluated contexts.
|
|
int compare_sizeof(int x) {
|
|
return sizeof(x == x); // no-warning
|
|
}
|
|
|
|
int array_comparisons(void) {
|
|
int array1[2];
|
|
int array2[2];
|
|
|
|
//
|
|
// compare same array
|
|
//
|
|
return array1 == array1; // expected-warning{{self-comparison always evaluates to true}}
|
|
return array1 != array1; // expected-warning{{self-comparison always evaluates to false}}
|
|
return array1 < array1; // expected-warning{{self-comparison always evaluates to false}}
|
|
return array1 <= array1; // expected-warning{{self-comparison always evaluates to true}}
|
|
return array1 > array1; // expected-warning{{self-comparison always evaluates to false}}
|
|
return array1 >= array1; // expected-warning{{self-comparison always evaluates to true}}
|
|
|
|
//
|
|
// compare different arrays
|
|
//
|
|
return array1 == array2; // expected-warning{{array comparison always evaluates to false}}
|
|
return array1 != array2; // expected-warning{{array comparison always evaluates to true}}
|
|
|
|
//
|
|
// we don't know what these are going to be
|
|
//
|
|
return array1 < array2; // expected-warning{{array comparison always evaluates to a constant}}
|
|
return array1 <= array2; // expected-warning{{array comparison always evaluates to a constant}}
|
|
return array1 > array2; // expected-warning{{array comparison always evaluates to a constant}}
|
|
return array1 >= array2; // expected-warning{{array comparison always evaluates to a constant}}
|
|
|
|
}
|
|
|
|
// Don't issue a warning when either the left or right side of the comparison
|
|
// results from a macro expansion.
|
|
#define R8435950_A i
|
|
#define R8435950_B i
|
|
|
|
int R8435950(int i) {
|
|
if (R8435950_A == R8435950_B) // no-warning
|
|
return 0;
|
|
return 1;
|
|
}
|
|
|
|
__attribute__((weak)) int weak_1[3];
|
|
__attribute__((weak)) int weak_2[3];
|
|
_Bool compare_weak(void) {
|
|
return weak_1 == weak_2;
|
|
}
|