mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-26 13:26:08 +00:00

We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
65 lines
1.7 KiB
C
65 lines
1.7 KiB
C
// RUN: %clang_cc1 -fsyntax-only -Wused-but-marked-unused -Wunused-function -Wunneeded-internal-declaration -verify %s
|
|
// RUN: %clang_cc1 -fsyntax-only -verify -Wunused %s
|
|
// RUN: %clang_cc1 -fsyntax-only -verify -Wall -Wno-infinite-recursion %s
|
|
|
|
void foo(void) {}
|
|
static void f2(void) {}
|
|
static void f1(void) {f2();} // expected-warning{{unused}}
|
|
|
|
static int f0(void) { return 17; } // expected-warning{{not needed and will not be emitted}}
|
|
int x = sizeof(f0());
|
|
|
|
static void f3(void);
|
|
extern void f3(void) { } // expected-warning{{unused}}
|
|
|
|
inline static void f4(void);
|
|
void f4(void) { } // expected-warning{{unused}}
|
|
|
|
static void __attribute__((used)) f5(void) {}
|
|
static void f6(void);
|
|
static void __attribute__((used)) f6(void);
|
|
static void f6(void) {};
|
|
|
|
static void f7(void);
|
|
void f8(void(*a0)(void));
|
|
void f9(void) { f8(f7); }
|
|
static void f7(void) {}
|
|
|
|
__attribute__((unused)) static void bar(void);
|
|
void bar(void) { }
|
|
|
|
__attribute__((constructor)) static void bar2(void);
|
|
void bar2(void) { }
|
|
|
|
__attribute__((destructor)) static void bar3(void);
|
|
void bar3(void) { }
|
|
|
|
static void f10(void); // expected-warning{{unused}}
|
|
static void f10(void);
|
|
|
|
static void f11(void);
|
|
static void f11(void) { } // expected-warning{{unused}}
|
|
|
|
static void f12(void) { } // expected-warning{{unused}}
|
|
static void f12(void);
|
|
|
|
// PR7923
|
|
static void unused(void) { unused(); } // expected-warning{{not needed and will not be emitted}}
|
|
|
|
static void cleanupMalloc(char * const * const allocation) { }
|
|
void f13(void) {
|
|
char * const __attribute__((cleanup(cleanupMalloc))) a;
|
|
(void)a;
|
|
}
|
|
|
|
extern void a(void) __attribute__((unused));
|
|
extern void b(void) __attribute__((unused));
|
|
|
|
void b(void)
|
|
{
|
|
}
|
|
void a(void)
|
|
{
|
|
b();
|
|
}
|