mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-26 10:06:05 +00:00
ffe7950ebc
I'm trying to remove unused options from the `Analyses.def` file, then merge the rest of the useful options into the `AnalyzerOptions.def`. Then make sure one can set these by an `-analyzer-config XXX=YYY` style flag. Then surface the `-analyzer-config` to the `clang` frontend; After all of this, we can pursue the tablegen approach described https://discourse.llvm.org/t/rfc-tablegen-clang-static-analyzer-engine-options-for-better-documentation/61488 In this patch, I'm proposing flag deprecations. We should support deprecated analyzer flags for exactly one release. In this case I'm planning to drop this flag in `clang-16`. In the clang frontend, now we won't pass this option to the cc1 frontend, rather emit a warning diagnostic reminding the users about this deprecated flag, which will be turned into error in clang-16. Unfortunately, I had to remove all the tests referring to this flag, causing a mass change. I've also added a test for checking this warning. I've seen that `scan-build` also uses this flag, but I think we should remove that part only after we turn this into a hard error. Reviewed By: martong Differential Revision: https://reviews.llvm.org/D126215
103 lines
2.4 KiB
C
103 lines
2.4 KiB
C
// RUN: %clang_analyze_cc1 -analyzer-checker=core,unix.Malloc -analyzer-max-loop 4 -verify %s
|
|
#include "Inputs/system-header-simulator.h"
|
|
|
|
typedef __typeof(sizeof(int)) size_t;
|
|
void *malloc(size_t);
|
|
|
|
static int another_function(int *y) {
|
|
if (*y > 0)
|
|
return *y;
|
|
return 0;
|
|
}
|
|
|
|
static void function_which_doesnt_give_up(int **x) {
|
|
*x = 0;
|
|
}
|
|
|
|
static void function_which_gives_up(int *x) {
|
|
for (int i = 0; i < 5; ++i)
|
|
(*x)++;
|
|
}
|
|
|
|
static void function_which_gives_up_nested(int *x) {
|
|
function_which_gives_up(x);
|
|
for (int i = 0; i < 5; ++i)
|
|
(*x)++;
|
|
}
|
|
|
|
static void function_which_doesnt_give_up_nested(int *x, int *y) {
|
|
*y = another_function(x);
|
|
function_which_gives_up(x);
|
|
}
|
|
|
|
void coverage1(int *x) {
|
|
function_which_gives_up(x);
|
|
char *m = (char*)malloc(12);
|
|
} // expected-warning {{Potential leak of memory pointed to by 'm'}}
|
|
|
|
void coverage2(int *x) {
|
|
if (x) {
|
|
function_which_gives_up(x);
|
|
char *m = (char*)malloc(12);
|
|
}
|
|
} // expected-warning {{Potential leak of memory pointed to by 'm'}}
|
|
|
|
void coverage3(int *x) {
|
|
x++;
|
|
function_which_gives_up(x);
|
|
char *m = (char*)malloc(12);
|
|
} // expected-warning {{Potential leak of memory pointed to by 'm'}}
|
|
|
|
void coverage4(int *x) {
|
|
*x += another_function(x);
|
|
function_which_gives_up(x);
|
|
char *m = (char*)malloc(12);
|
|
} // expected-warning {{Potential leak of memory pointed to by 'm'}}
|
|
|
|
void coverage5(int *x) {
|
|
for (int i = 0; i<7; ++i)
|
|
function_which_gives_up(x);
|
|
// The root function gives up here.
|
|
char *m = (char*)malloc(12); // no-warning
|
|
}
|
|
|
|
void coverage6(int *x) {
|
|
for (int i = 0; i<3; ++i) {
|
|
function_which_gives_up(x);
|
|
}
|
|
char *m = (char*)malloc(12);
|
|
} // expected-warning {{Potential leak of memory pointed to by 'm'}}
|
|
|
|
int coverage7_inline(int *i) {
|
|
function_which_doesnt_give_up(&i);
|
|
return *i; // expected-warning {{Dereference}}
|
|
}
|
|
|
|
void coverage8(int *x) {
|
|
int y;
|
|
function_which_doesnt_give_up_nested(x, &y);
|
|
y = (*x)/y; // expected-warning {{Division by zero}}
|
|
char *m = (char*)malloc(12);
|
|
} // expected-warning {{Potential leak of memory pointed to by 'm'}}
|
|
|
|
void function_which_gives_up_settonull(int **x) {
|
|
*x = 0;
|
|
int y = 0;
|
|
for (int i = 0; i < 5; ++i)
|
|
y++;
|
|
}
|
|
|
|
void coverage9(int *x) {
|
|
int y = 5;
|
|
function_which_gives_up_settonull(&x);
|
|
y = (*x); // no warning
|
|
}
|
|
|
|
static void empty_function(void){
|
|
}
|
|
int use_empty_function(int x) {
|
|
x = 0;
|
|
empty_function();
|
|
return 5/x; //expected-warning {{Division by zero}}
|
|
}
|