mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-26 18:16:06 +00:00
025541dded
If we see a variable declaration (aka. DeclStmt), and the VarRegion it declared doesn't have Stack memspace, we assumed that it must be a local static variable. However, the declared variable may be an extern declaration of a global. In this patch, let's admit that local extern declarations are a thing. For the sake of completeness, I also added one more test for thread_locals - which are implicitly considered statics btw. (the `isStaticLocal()` correctly also considers thread locals as local statics). Fixes #124975
61 lines
1.9 KiB
C++
61 lines
1.9 KiB
C++
// RUN: %clang_analyze_cc1 -w -x c++ -analyzer-checker=core -analyzer-output=text -verify %s
|
|
|
|
namespace pr34731 {
|
|
int b;
|
|
class c {
|
|
class B {
|
|
public:
|
|
double ***d;
|
|
B();
|
|
};
|
|
void e(double **, int);
|
|
void f(B &, int &);
|
|
};
|
|
|
|
// Properly track the null pointer in the array field back to the default
|
|
// constructor of 'h'.
|
|
void c::f(B &g, int &i) {
|
|
e(g.d[9], i); // expected-warning{{Array access (via field 'd') results in a null pointer dereference}}
|
|
// expected-note@-1{{Array access (via field 'd') results in a null pointer dereference}}
|
|
B h, a; // expected-note{{Value assigned to 'h.d'}}
|
|
a.d == __null; // expected-note{{Assuming the condition is true}}
|
|
a.d != h.d; // expected-note{{Assuming 'a.d' is equal to 'h.d'}}
|
|
f(h, b); // expected-note{{Calling 'c::f'}}
|
|
}
|
|
}
|
|
|
|
namespace GH124975 {
|
|
void no_crash_in_br_visitors(int *p) {
|
|
if (p) {}
|
|
// expected-note@-1 {{Assuming 'p' is null}}
|
|
// expected-note@-2 {{Taking false branch}}
|
|
|
|
extern bool ExternLocalCoin;
|
|
// expected-note@+2 {{Assuming 'ExternLocalCoin' is false}}
|
|
// expected-note@+1 {{Taking false branch}}
|
|
if (ExternLocalCoin)
|
|
return;
|
|
|
|
*p = 4;
|
|
// expected-warning@-1 {{Dereference of null pointer (loaded from variable 'p')}}
|
|
// expected-note@-2 {{Dereference of null pointer (loaded from variable 'p')}}
|
|
}
|
|
|
|
// Thread local variables are implicitly static, so let's test them too.
|
|
void thread_local_alternative(int *p) {
|
|
if (p) {}
|
|
// expected-note@-1 {{Assuming 'p' is null}}
|
|
// expected-note@-2 {{Taking false branch}}
|
|
|
|
thread_local bool ThreadLocalCoin;
|
|
// expected-note@+2 {{'ThreadLocalCoin' is false}}
|
|
// expected-note@+1 {{Taking false branch}}
|
|
if (ThreadLocalCoin)
|
|
return;
|
|
|
|
*p = 4;
|
|
// expected-warning@-1 {{Dereference of null pointer (loaded from variable 'p')}}
|
|
// expected-note@-2 {{Dereference of null pointer (loaded from variable 'p')}}
|
|
}
|
|
} // namespace GH124975
|