mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 13:36:08 +00:00
708c8cd743
Fix since #75481 got reverted.
- Explicitly set BitfieldBits to 0 to avoid uninitialized field member
for the integer checks:
```diff
- llvm::ConstantInt::get(Builder.getInt8Ty(), Check.first)};
+ llvm::ConstantInt::get(Builder.getInt8Ty(), Check.first),
+ llvm::ConstantInt::get(Builder.getInt32Ty(), 0)};
```
- `Value **Previous` was erroneously `Value *Previous` in
`CodeGenFunction::EmitWithOriginalRHSBitfieldAssignment`, fixed now.
- Update following:
```diff
- if (Kind == CK_IntegralCast) {
+ if (Kind == CK_IntegralCast || Kind == CK_LValueToRValue) {
```
CK_LValueToRValue when going from, e.g., char to char, and
CK_IntegralCast otherwise.
- Make sure that `Value *Previous = nullptr;` is initialized (see
1189e87951)
- Add another extensive testcase
`ubsan/TestCases/ImplicitConversion/bitfield-conversion.c`
---------
Co-authored-by: Vitaly Buka <vitalybuka@gmail.com>
140 lines
4.9 KiB
C
140 lines
4.9 KiB
C
// RUN: %clang_cc1 -fsanitize=implicit-unsigned-integer-truncation,implicit-signed-integer-truncation -fsanitize-recover=implicit-unsigned-integer-truncation,implicit-signed-integer-truncation -emit-llvm %s -o - -triple x86_64-linux-gnu | FileCheck %s -implicit-check-not="call void @__ubsan_handle_implicit_conversion" --check-prefixes=CHECK
|
|
|
|
// CHECK-DAG: @[[INT:.*]] = {{.*}} c"'int'\00" }
|
|
// CHECK-DAG: @[[UNSIGNED_SHORT:.*]] = {{.*}} c"'unsigned short'\00" }
|
|
// CHECK-DAG: @[[LINE_100:.*]] = {{.*}}, i32 100, i32 4 }, ptr @[[INT]], ptr @[[UNSIGNED_SHORT]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[LINE_200:.*]] = {{.*}}, i32 200, i32 4 }, ptr @[[INT]], ptr @[[UNSIGNED_SHORT]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[LINE_300:.*]] = {{.*}}, i32 300, i32 3 }, ptr @[[INT]], ptr @[[UNSIGNED_SHORT]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[LINE_400:.*]] = {{.*}}, i32 400, i32 3 }, ptr @[[INT]], ptr @[[UNSIGNED_SHORT]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[SHORT:.*]] = {{.*}} c"'short'\00" }
|
|
// CHECK-DAG: @[[LINE_500:.*]] = {{.*}}, i32 500, i32 4 }, ptr @[[INT]], ptr @[[SHORT]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[LINE_600:.*]] = {{.*}}, i32 600, i32 4 }, ptr @[[INT]], ptr @[[SHORT]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[LINE_700:.*]] = {{.*}}, i32 700, i32 3 }, ptr @[[INT]], ptr @[[SHORT]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[LINE_800:.*]] = {{.*}}, i32 800, i32 3 }, ptr @[[INT]], ptr @[[SHORT]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[UNSIGNED_CHAR:.*]] = {{.*}} c"'unsigned char'\00" }
|
|
// CHECK-DAG: @[[LINE_900:.*]] = {{.*}}, i32 900, i32 4 }, ptr @[[INT]], ptr @[[UNSIGNED_CHAR]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[LINE_1000:.*]] = {{.*}}, i32 1000, i32 4 }, ptr @[[INT]], ptr @[[UNSIGNED_CHAR]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[LINE_1100:.*]] = {{.*}}, i32 1100, i32 3 }, ptr @[[INT]], ptr @[[UNSIGNED_CHAR]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[LINE_1200:.*]] = {{.*}}, i32 1200, i32 3 }, ptr @[[INT]], ptr @[[UNSIGNED_CHAR]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[SIGNED_CHAR:.*]] = {{.*}} c"'signed char'\00" }
|
|
// CHECK-DAG: @[[LINE_1300:.*]] = {{.*}}, i32 1300, i32 4 }, ptr @[[INT]], ptr @[[SIGNED_CHAR]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[LINE_1400:.*]] = {{.*}}, i32 1400, i32 4 }, ptr @[[INT]], ptr @[[SIGNED_CHAR]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[LINE_1500:.*]] = {{.*}}, i32 1500, i32 3 }, ptr @[[INT]], ptr @[[SIGNED_CHAR]], i8 2, i32 0 }
|
|
// CHECK-DAG: @[[LINE_1600:.*]] = {{.*}}, i32 1600, i32 3 }, ptr @[[INT]], ptr @[[SIGNED_CHAR]], i8 2, i32 0 }
|
|
|
|
// CHECK-LABEL: @t0(
|
|
unsigned short t0(unsigned short x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_100]]
|
|
#line 100
|
|
x++;
|
|
return x;
|
|
}
|
|
// CHECK-LABEL: @t1(
|
|
unsigned short t1(unsigned short x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_200]]
|
|
#line 200
|
|
x--;
|
|
return x;
|
|
}
|
|
// CHECK-LABEL: @t2(
|
|
unsigned short t2(unsigned short x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_300]]
|
|
#line 300
|
|
++x;
|
|
return x;
|
|
}
|
|
// CHECK-LABEL: @t3(
|
|
unsigned short t3(unsigned short x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_400]]
|
|
#line 400
|
|
--x;
|
|
return x;
|
|
}
|
|
|
|
// CHECK-LABEL: @t4(
|
|
signed short t4(signed short x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_500]]
|
|
#line 500
|
|
x++;
|
|
return x;
|
|
}
|
|
// CHECK-LABEL: @t5(
|
|
signed short t5(signed short x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_600]]
|
|
#line 600
|
|
x--;
|
|
return x;
|
|
}
|
|
// CHECK-LABEL: @t6(
|
|
signed short t6(signed short x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_700]]
|
|
#line 700
|
|
++x;
|
|
return x;
|
|
}
|
|
// CHECK-LABEL: @t7(
|
|
signed short t7(signed short x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_800]]
|
|
#line 800
|
|
--x;
|
|
return x;
|
|
}
|
|
|
|
// CHECK-LABEL: @t8(
|
|
unsigned char t8(unsigned char x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_900]]
|
|
#line 900
|
|
x++;
|
|
return x;
|
|
}
|
|
// CHECK-LABEL: @t9(
|
|
unsigned char t9(unsigned char x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_1000]]
|
|
#line 1000
|
|
x--;
|
|
return x;
|
|
}
|
|
// CHECK-LABEL: @t10(
|
|
unsigned char t10(unsigned char x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_1100]]
|
|
#line 1100
|
|
++x;
|
|
return x;
|
|
}
|
|
// CHECK-LABEL: @t11(
|
|
unsigned char t11(unsigned char x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_1200]]
|
|
#line 1200
|
|
--x;
|
|
return x;
|
|
}
|
|
|
|
// CHECK-LABEL: @t12(
|
|
signed char t12(signed char x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_1300]]
|
|
#line 1300
|
|
x++;
|
|
return x;
|
|
}
|
|
// CHECK-LABEL: @t13(
|
|
signed char t13(signed char x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_1400]]
|
|
#line 1400
|
|
x--;
|
|
return x;
|
|
}
|
|
// CHECK-LABEL: @t14(
|
|
signed char t14(signed char x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_1500]]
|
|
#line 1500
|
|
++x;
|
|
return x;
|
|
}
|
|
// CHECK-LABEL: @t15(
|
|
signed char t15(signed char x) {
|
|
// CHECK: call void @__ubsan_handle_implicit_conversion(ptr @[[LINE_1600]]
|
|
#line 1600
|
|
--x;
|
|
return x;
|
|
}
|