mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-28 04:46:07 +00:00
842b57b775
Whereas it is UB in terms of the standard to delete an array of objects via pointer whose static type doesn't match its dynamic type, MSVC supports an extension allowing to do it. Aside from array deletion not working correctly in the mentioned case, currently not having this extension implemented causes clang to generate code that is not compatible with the code generated by MSVC, because clang always puts scalar deleting destructor to the vftable. This PR aims to resolve these problems. It was reverted due to link time errors in chromium with sanitizer coverage enabled, which is fixed by https://github.com/llvm/llvm-project/pull/131929 . The second commit of this PR also contains a fix for a runtime failure in chromium reported in https://github.com/llvm/llvm-project/pull/126240#issuecomment-2730216384 . Fixes https://github.com/llvm/llvm-project/issues/19772
95 lines
2.6 KiB
C++
95 lines
2.6 KiB
C++
// RUN: %clang_cc1 %s -fno-rtti -triple=i386-pc-win32 -emit-llvm -o %t.ll -fdump-vtable-layouts >%t
|
|
// RUN: FileCheck %s < %t
|
|
|
|
struct A {
|
|
virtual ~A();
|
|
virtual void z1();
|
|
};
|
|
|
|
struct B {
|
|
virtual ~B();
|
|
};
|
|
|
|
struct C : A, B {
|
|
// CHECK-LABEL: VFTable for 'A' in 'C' (2 entries).
|
|
// CHECK-NEXT: 0 | C::~C() [vector deleting]
|
|
// CHECK-NEXT: 1 | void A::z1()
|
|
|
|
// CHECK-LABEL: VFTable for 'B' in 'C' (1 entry).
|
|
// CHECK-NEXT: 0 | C::~C() [vector deleting]
|
|
// CHECK-NEXT: [this adjustment: -4 non-virtual]
|
|
|
|
// CHECK-LABEL: Thunks for 'C::~C()' (1 entry).
|
|
// CHECK-NEXT: 0 | [this adjustment: -4 non-virtual]
|
|
|
|
// CHECK-LABEL: VFTable indices for 'C' (1 entry).
|
|
// CHECK-NEXT: 0 | C::~C() [vector deleting]
|
|
virtual ~C();
|
|
};
|
|
|
|
void build_vftable(C *obj) { delete obj; }
|
|
|
|
struct D {
|
|
// No virtual destructor here!
|
|
virtual void z4();
|
|
};
|
|
|
|
struct E : D, B {
|
|
// Implicit virtual dtor here!
|
|
|
|
// CHECK-LABEL: VFTable for 'D' in 'E' (1 entry).
|
|
// CHECK-NEXT: 0 | void D::z4()
|
|
|
|
// CHECK-LABEL: VFTable for 'B' in 'E' (1 entry).
|
|
// CHECK-NEXT: 0 | E::~E() [vector deleting]
|
|
// CHECK-NEXT: [this adjustment: -4 non-virtual]
|
|
|
|
// CHECK-LABEL: Thunks for 'E::~E()' (1 entry).
|
|
// CHECK-NEXT: 0 | [this adjustment: -4 non-virtual]
|
|
|
|
// CHECK-LABEL: VFTable indices for 'E' (1 entry).
|
|
// CHECK-NEXT: -- accessible via vfptr at offset 4 --
|
|
// CHECK-NEXT: 0 | E::~E() [vector deleting]
|
|
};
|
|
|
|
void build_vftable(E *obj) { delete obj; }
|
|
|
|
struct F : D, B {
|
|
// Implicit virtual dtor here!
|
|
|
|
// CHECK-LABEL: VFTable for 'D' in 'F' (1 entry).
|
|
// CHECK-NEXT: 0 | void D::z4()
|
|
|
|
// CHECK-LABEL: VFTable for 'B' in 'F' (1 entry).
|
|
// CHECK-NEXT: 0 | F::~F() [vector deleting]
|
|
// CHECK-NEXT: [this adjustment: -4 non-virtual]
|
|
|
|
// CHECK-LABEL: Thunks for 'F::~F()' (1 entry).
|
|
// CHECK-NEXT: 0 | [this adjustment: -4 non-virtual]
|
|
|
|
// CHECK-LABEL: VFTable indices for 'F' (1 entry).
|
|
// CHECK-NEXT: -- accessible via vfptr at offset 4 --
|
|
// CHECK-NEXT: 0 | F::~F() [vector deleting]
|
|
};
|
|
|
|
void build_vftable(F *obj) { delete obj; }
|
|
|
|
struct G : F {
|
|
// CHECK-LABEL: VFTable for 'D' in 'F' in 'G' (1 entry).
|
|
// CHECK-NEXT: 0 | void D::z4()
|
|
|
|
// CHECK-LABEL: VFTable for 'B' in 'F' in 'G' (1 entry).
|
|
// CHECK-NEXT: 0 | G::~G() [vector deleting]
|
|
// CHECK-NEXT: [this adjustment: -4 non-virtual]
|
|
|
|
// CHECK-LABEL: Thunks for 'G::~G()' (1 entry).
|
|
// CHECK-NEXT: 0 | [this adjustment: -4 non-virtual]
|
|
|
|
// CHECK-LABEL: VFTable indices for 'G' (1 entry).
|
|
// CHECK-NEXT: -- accessible via vfptr at offset 4 --
|
|
// CHECK-NEXT: 0 | G::~G() [vector deleting]
|
|
virtual ~G();
|
|
};
|
|
|
|
void build_vftable(G *obj) { delete obj; }
|