mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-26 05:16:06 +00:00
39ec9de7c2
`sret` arguments are always going to reside in the stack/`alloca` address space, which makes the current formulation where their AS is derived from the pointee somewhat quaint. This patch ensures that `sret` ends up pointing to the `alloca` AS in IR function signatures, and also guards agains trying to pass a casted `alloca`d pointer to a `sret` arg, which can happen for most languages, when compiled for targets that have a non-zero `alloca` AS (e.g. AMDGCN) / map `LangAS::default` to a non-zero value (SPIR-V). A target could still choose to do something different here, by e.g. overriding `classifyReturnType` behaviour. In a broader sense, this patch extends non-aliased indirect args to also carry an AS, which leads to changing the `getIndirect()` interface. At the moment we're only using this for (indirect) returns, but it allows for future handling of indirect args themselves. We default to using the AllocaAS as that matches what Clang is currently doing, however if, in the future, a target would opt for e.g. placing indirect returns in some other storage, with another AS, this will require revisiting. --------- Co-authored-by: Matt Arsenault <arsenm2@gmail.com> Co-authored-by: Matt Arsenault <Matthew.Arsenault@amd.com>
69 lines
2.9 KiB
Common Lisp
69 lines
2.9 KiB
Common Lisp
// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5
|
|
// RUN: %clang_cc1 -cl-std=CL2.0 -triple amdgcn-amd-amdhsa -disable-llvm-passes -emit-llvm -o - %s | FileCheck %s
|
|
|
|
// Check there's no assertion when passing a pointer to an address space
|
|
// qualified argument.
|
|
|
|
extern void private_ptr(__private int *);
|
|
extern void local_ptr(__local int *);
|
|
extern void generic_ptr(__generic int *);
|
|
|
|
// CHECK-LABEL: define dso_local void @use_of_private_var(
|
|
// CHECK-SAME: ) #[[ATTR0:[0-9]+]] {
|
|
// CHECK-NEXT: [[ENTRY:.*:]]
|
|
// CHECK-NEXT: [[X:%.*]] = alloca i32, align 4, addrspace(5)
|
|
// CHECK-NEXT: [[X_ASCAST:%.*]] = addrspacecast ptr addrspace(5) [[X]] to ptr
|
|
// CHECK-NEXT: call void @llvm.lifetime.start.p5(i64 4, ptr addrspace(5) [[X]]) #[[ATTR4:[0-9]+]]
|
|
// CHECK-NEXT: store i32 0, ptr [[X_ASCAST]], align 4, !tbaa [[TBAA4:![0-9]+]]
|
|
// CHECK-NEXT: [[TMP0:%.*]] = addrspacecast ptr [[X_ASCAST]] to ptr addrspace(5)
|
|
// CHECK-NEXT: call void @private_ptr(ptr addrspace(5) noundef [[TMP0]]) #[[ATTR5:[0-9]+]]
|
|
// CHECK-NEXT: call void @generic_ptr(ptr noundef [[X_ASCAST]]) #[[ATTR5]]
|
|
// CHECK-NEXT: call void @llvm.lifetime.end.p5(i64 4, ptr addrspace(5) [[X]]) #[[ATTR4]]
|
|
// CHECK-NEXT: ret void
|
|
//
|
|
void use_of_private_var()
|
|
{
|
|
int x = 0 ;
|
|
private_ptr(&x);
|
|
generic_ptr(&x);
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local void @addr_of_arg(
|
|
// CHECK-SAME: i32 noundef [[X:%.*]]) #[[ATTR0]] {
|
|
// CHECK-NEXT: [[ENTRY:.*:]]
|
|
// CHECK-NEXT: [[X_ADDR:%.*]] = alloca i32, align 4, addrspace(5)
|
|
// CHECK-NEXT: [[X_ADDR_ASCAST:%.*]] = addrspacecast ptr addrspace(5) [[X_ADDR]] to ptr
|
|
// CHECK-NEXT: store i32 [[X]], ptr [[X_ADDR_ASCAST]], align 4, !tbaa [[TBAA4]]
|
|
// CHECK-NEXT: [[TMP0:%.*]] = addrspacecast ptr [[X_ADDR_ASCAST]] to ptr addrspace(5)
|
|
// CHECK-NEXT: call void @private_ptr(ptr addrspace(5) noundef [[TMP0]]) #[[ATTR5]]
|
|
// CHECK-NEXT: call void @generic_ptr(ptr noundef [[X_ADDR_ASCAST]]) #[[ATTR5]]
|
|
// CHECK-NEXT: ret void
|
|
//
|
|
void addr_of_arg(int x)
|
|
{
|
|
private_ptr(&x);
|
|
generic_ptr(&x);
|
|
}
|
|
|
|
// CHECK-LABEL: define dso_local amdgpu_kernel void @use_of_local_var(
|
|
// CHECK-SAME: ) #[[ATTR3:[0-9]+]] !kernel_arg_addr_space [[META8:![0-9]+]] !kernel_arg_access_qual [[META8]] !kernel_arg_type [[META8]] !kernel_arg_base_type [[META8]] !kernel_arg_type_qual [[META8]] {
|
|
// CHECK-NEXT: [[ENTRY:.*:]]
|
|
// CHECK-NEXT: call void @local_ptr(ptr addrspace(3) noundef @use_of_local_var.x) #[[ATTR5]]
|
|
// CHECK-NEXT: call void @generic_ptr(ptr noundef addrspacecast (ptr addrspace(3) @use_of_local_var.x to ptr)) #[[ATTR5]]
|
|
// CHECK-NEXT: ret void
|
|
//
|
|
__kernel void use_of_local_var()
|
|
{
|
|
__local int x;
|
|
local_ptr(&x);
|
|
generic_ptr(&x);
|
|
}
|
|
|
|
//.
|
|
// CHECK: [[TBAA4]] = !{[[META5:![0-9]+]], [[META5]], i64 0}
|
|
// CHECK: [[META5]] = !{!"int", [[META6:![0-9]+]], i64 0}
|
|
// CHECK: [[META6]] = !{!"omnipotent char", [[META7:![0-9]+]], i64 0}
|
|
// CHECK: [[META7]] = !{!"Simple C/C++ TBAA"}
|
|
// CHECK: [[META8]] = !{}
|
|
//.
|