mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 10:16:07 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
49 lines
962 B
C
49 lines
962 B
C
// RUN: %clang_cc1 -emit-llvm-only -triple i386-apple-darwin9 %s
|
|
|
|
#define ATTR __attribute__((__ms_struct__))
|
|
|
|
struct _struct_0
|
|
{
|
|
int member_0 : 25 ;
|
|
short member_1 : 6 ;
|
|
char member_2 : 2 ;
|
|
unsigned short member_3 : 1 ;
|
|
unsigned char member_4 : 7 ;
|
|
short member_5 : 16 ;
|
|
int : 0 ;
|
|
char member_7 ;
|
|
|
|
} ATTR;
|
|
|
|
typedef struct _struct_0 struct_0;
|
|
|
|
#define size_struct_0 20
|
|
|
|
struct_0 test_struct_0 = { 18557917, 17, 3, 0, 80, 6487, 93 };
|
|
static int a[(size_struct_0 == sizeof (struct_0)) -1];
|
|
|
|
struct _struct_1 {
|
|
int d;
|
|
unsigned char a;
|
|
unsigned short b:7;
|
|
char c;
|
|
} ATTR;
|
|
|
|
typedef struct _struct_1 struct_1;
|
|
|
|
#define size_struct_1 12
|
|
|
|
struct_1 test_struct_1 = { 18557917, 'a', 3, 'b' };
|
|
|
|
static int a1[(size_struct_1 == sizeof (struct_1)) -1];
|
|
|
|
struct ten {
|
|
long long a:3;
|
|
long long b:3;
|
|
char c;
|
|
} __attribute__ ((ms_struct));
|
|
|
|
#define size_struct_2 16
|
|
|
|
static int a2[(size_struct_2 == sizeof (struct ten)) -1];
|