mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 05:36:05 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
75 lines
2.8 KiB
C
75 lines
2.8 KiB
C
// RUN: %clang_cc1 %s -triple i386-unknown-unknown -fvisibility=default -emit-llvm -o - | FileCheck %s -check-prefix=CHECK-DEFAULT
|
|
// RUN: %clang_cc1 %s -triple i386-unknown-unknown -fvisibility=protected -emit-llvm -o - | FileCheck %s -check-prefix=CHECK-PROTECTED
|
|
// RUN: %clang_cc1 %s -triple i386-unknown-unknown -fvisibility=hidden -emit-llvm -o - | FileCheck %s -check-prefix=CHECK-HIDDEN
|
|
|
|
// CHECK-DEFAULT: @g_def ={{.*}} global i32 0
|
|
// CHECK-DEFAULT: @g_com ={{.*}} global i32 0
|
|
// CHECK-DEFAULT: @g_ext = external global i32
|
|
// CHECK-DEFAULT: @g_deferred = internal global
|
|
// CHECK-PROTECTED: @g_def = protected global i32 0
|
|
// CHECK-PROTECTED: @g_com = protected global i32 0
|
|
// CHECK-PROTECTED: @g_ext = external global i32
|
|
// CHECK-PROTECTED: @g_deferred = internal global
|
|
// CHECK-HIDDEN: @g_def = hidden global i32 0
|
|
// CHECK-HIDDEN: @g_com = hidden global i32 0
|
|
// CHECK-HIDDEN: @g_ext = external global i32
|
|
// CHECK-HIDDEN: @g_deferred = internal global
|
|
int g_com;
|
|
int g_def = 0;
|
|
extern int g_ext;
|
|
static char g_deferred[] = "hello";
|
|
|
|
// CHECK-DEFAULT: @test4 = hidden global i32 10
|
|
// CHECK-PROTECTED: @test4 = hidden global i32 10
|
|
// CHECK-HIDDEN: @test4 = hidden global i32 10
|
|
|
|
// CHECK-DEFAULT-LABEL: define{{.*}} i32 @f_def()
|
|
// CHECK-DEFAULT: declare void @f_ext()
|
|
// CHECK-DEFAULT-LABEL: define internal void @f_deferred()
|
|
// CHECK-PROTECTED-LABEL: define protected i32 @f_def()
|
|
// CHECK-PROTECTED: declare void @f_ext()
|
|
// CHECK-PROTECTED-LABEL: define internal void @f_deferred()
|
|
// CHECK-HIDDEN-LABEL: define hidden i32 @f_def()
|
|
// CHECK-HIDDEN: declare void @f_ext()
|
|
// CHECK-HIDDEN-LABEL: define internal void @f_deferred()
|
|
|
|
extern void f_ext(void);
|
|
|
|
static void f_deferred(void) {
|
|
}
|
|
|
|
int f_def(void) {
|
|
f_ext();
|
|
f_deferred();
|
|
return g_com + g_def + g_ext + g_deferred[0];
|
|
}
|
|
|
|
// PR8457
|
|
// CHECK-DEFAULT-LABEL: define{{.*}} void @test1(
|
|
// CHECK-PROTECTED-LABEL: define{{.*}} void @test1(
|
|
// CHECK-HIDDEN-LABEL: define{{.*}} void @test1(
|
|
struct Test1 { int field; };
|
|
void __attribute__((visibility("default"))) test1(struct Test1 *v) { }
|
|
|
|
// CHECK-DEFAULT-LABEL: define{{.*}} void @test2()
|
|
// CHECK-PROTECTED-LABEL: define{{.*}} void @test2()
|
|
// CHECK-HIDDEN-LABEL: define{{.*}} void @test2()
|
|
void test2(void);
|
|
void __attribute__((visibility("default"))) test2(void) {}
|
|
|
|
// CHECK-DEFAULT-LABEL: define hidden void @test3()
|
|
// CHECK-PROTECTED-LABEL: define hidden void @test3()
|
|
// CHECK-HIDDEN-LABEL: define hidden void @test3()
|
|
extern void test3(void);
|
|
__private_extern__ void test3(void) {}
|
|
|
|
// Top of file.
|
|
extern int test4;
|
|
__private_extern__ int test4 = 10;
|
|
|
|
// CHECK-DEFAULT-LABEL: define hidden void @test5()
|
|
// CHECK-PROTECTED-LABEL: define hidden void @test5()
|
|
// CHECK-HIDDEN-LABEL: define hidden void @test5()
|
|
__attribute__((availability(macosx,introduced=10.5,deprecated=10.6)))
|
|
__private_extern__ void test5(void) {}
|