mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 19:16:05 +00:00
39a2a233f8
This patch moves the parsing of `{Lang,CodeGen}Options` from `parseSimpleArgs` to the original `Parse{Lang,CodeGen}Args` functions.
This ensures all marshalled `LangOptions` are being parsed **after** the call `setLangDefaults`, which in turn enables us to marshall `LangOptions` that somehow depend on the defaults. (In a future patch.)
Now, `CodeGenOptions` need to be parsed **after** `LangOptions`, because `-cl-mad-enable` (a `CodeGenOpt`) depends on the value of `-cl-fast-relaxed-math` and `-cl-unsafe-math-optimizations` (`LangOpts`).
Unfortunately, this removes the nice property that marshalled options get parsed in the exact order they appear in the `.td` file. Now we cannot be sure that a TableGen record referenced in `ImpliedByAnyOf` has already been parsed. This might cause an ordering issues (i.e. reading value of uninitialized variable). I plan to mitigate this by moving each `XxxOpt` group from `parseSimpleArgs` back to their original parsing function. With this setup, if an option from group `A` references option from group `B` in TableGen, the compiler will require us to make the `CompilerInvocation` member for `B` visible in the parsing function for `A`. That's where we notice that `B` didn't get parsed yet.
Reviewed By: Bigcheese
Differential Revision: https://reviews.llvm.org/D94682
13 lines
626 B
C
13 lines
626 B
C
// Make sure a note stays with its associated command-line argument diagnostic.
|
|
// Previously, these diagnostics were grouped by diagnostic level with all
|
|
// notes last.
|
|
//
|
|
// RUN: not %clang_cc1 -O999 -std=bogus -verify=-foo %s 2> %t
|
|
// RUN: FileCheck < %t %s
|
|
//
|
|
// CHECK: error: invalid value '-foo' in '-verify='
|
|
// CHECK-NEXT: note: -verify prefixes must start with a letter and contain only alphanumeric characters, hyphens, and underscores
|
|
// CHECK-NEXT: error: invalid value 'bogus' in '-std=bogus'
|
|
// CHECK-NEXT: note: use {{.*}} for {{.*}} standard
|
|
// CHECK: warning: optimization level '-O999' is not supported
|