mirror of
https://github.com/llvm/llvm-project.git
synced 2025-05-01 05:36:09 +00:00
1beffc1888
SBTarget::AddModule currently handles the UUID parameter in a very weird way: UUIDs with more than 16 bytes are trimmed to 16 bytes. On the other hand, shorter-than-16-bytes UUIDs are completely ignored. In this patch, we change the parsing code to handle UUIDs of arbitrary size. To support arbitrary size UUIDs in SBTarget::AddModule, this patch changes UUID::SetFromStringRef to parse UUIDs of arbitrary length. We subtly change the semantics of SetFromStringRef - SetFromStringRef now only succeeds if the entire input is consumed to prevent some prefix-parsing confusion. This is up for discussion, but I believe this is more consistent - we always return false for invalid UUIDs rather than sometimes truncating to a valid prefix. Also, all the call-sites except the API and interpreter seem to expect to consume the entire input. This also adds tests for adding existing modules 4-, 16-, and 20-byte build-ids. Finally, we took the liberty of testing the minidump scenario we care about - removing placeholder module from minidump and replacing it with the real module. Reviewed By: labath, friss Differential Revision: https://reviews.llvm.org/D80755
86 lines
2.7 KiB
C++
86 lines
2.7 KiB
C++
//===-- OptionValueUUID.cpp -----------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Interpreter/OptionValueUUID.h"
|
|
|
|
#include "lldb/Core/Module.h"
|
|
#include "lldb/Interpreter/CommandInterpreter.h"
|
|
#include "lldb/Utility/Stream.h"
|
|
#include "lldb/Utility/StringList.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
void OptionValueUUID::DumpValue(const ExecutionContext *exe_ctx, Stream &strm,
|
|
uint32_t dump_mask) {
|
|
if (dump_mask & eDumpOptionType)
|
|
strm.Printf("(%s)", GetTypeAsCString());
|
|
if (dump_mask & eDumpOptionValue) {
|
|
if (dump_mask & eDumpOptionType)
|
|
strm.PutCString(" = ");
|
|
m_uuid.Dump(&strm);
|
|
}
|
|
}
|
|
|
|
Status OptionValueUUID::SetValueFromString(llvm::StringRef value,
|
|
VarSetOperationType op) {
|
|
Status error;
|
|
switch (op) {
|
|
case eVarSetOperationClear:
|
|
Clear();
|
|
NotifyValueChanged();
|
|
break;
|
|
|
|
case eVarSetOperationReplace:
|
|
case eVarSetOperationAssign: {
|
|
if (!m_uuid.SetFromStringRef(value))
|
|
error.SetErrorStringWithFormat("invalid uuid string value '%s'",
|
|
value.str().c_str());
|
|
else {
|
|
m_value_was_set = true;
|
|
NotifyValueChanged();
|
|
}
|
|
} break;
|
|
|
|
case eVarSetOperationInsertBefore:
|
|
case eVarSetOperationInsertAfter:
|
|
case eVarSetOperationRemove:
|
|
case eVarSetOperationAppend:
|
|
case eVarSetOperationInvalid:
|
|
error = OptionValue::SetValueFromString(value, op);
|
|
break;
|
|
}
|
|
return error;
|
|
}
|
|
|
|
lldb::OptionValueSP OptionValueUUID::DeepCopy() const {
|
|
return OptionValueSP(new OptionValueUUID(*this));
|
|
}
|
|
|
|
void OptionValueUUID::AutoComplete(CommandInterpreter &interpreter,
|
|
CompletionRequest &request) {
|
|
ExecutionContext exe_ctx(interpreter.GetExecutionContext());
|
|
Target *target = exe_ctx.GetTargetPtr();
|
|
if (!target)
|
|
return;
|
|
auto prefix = request.GetCursorArgumentPrefix();
|
|
llvm::SmallVector<uint8_t, 20> uuid_bytes;
|
|
if (!UUID::DecodeUUIDBytesFromString(prefix, uuid_bytes).empty())
|
|
return;
|
|
const size_t num_modules = target->GetImages().GetSize();
|
|
for (size_t i = 0; i < num_modules; ++i) {
|
|
ModuleSP module_sp(target->GetImages().GetModuleAtIndex(i));
|
|
if (!module_sp)
|
|
continue;
|
|
const UUID &module_uuid = module_sp->GetUUID();
|
|
if (!module_uuid.IsValid())
|
|
continue;
|
|
request.TryCompleteCurrentArg(module_uuid.GetAsString());
|
|
}
|
|
}
|