llvm-project

mirror of https://github.com/llvm/llvm-project.git synced 2025-04-27 04:26:07 +00:00

History

Jan Svoboda bdc3ce9e8f [clang] Make FileEntryRef::getDir() return the as-requested DirectoryEntryRef

For redirected file entries, `FileEntryRef::getDir()` returns the parent directory entry of the target file entry. This differs from `FileEntry::getDir()` that always returns the parent directory that was last used to look up that file.

After switching from `FileEntry` to `FileEntryRef` for umbrella headers in D142113, this discrepancy became observable and caused Clang to emit incorrect diagnostics.

This patch changes Clang so that it always associates `FileEntryRef` with the parent directory that was used to look it up. This brings its behavior closer to `FileEntry`, but without the hacky mutation.

This also ensures that `llvm::sys::path::parent_path(FileRef->getNameAsRequested()) == FileRef->getDir()->getName()`. Previously, `FileRef->getDir()` would fall underneath the redirecting VFS into the world of on-disk paths.

Reviewed By: benlangmuir, rmaz

Differential Revision: https://reviews.llvm.org/D151398

2023-05-25 12:36:57 -07:00

CharInfoTest.cpp

…

CMakeLists.txt

[CMake] Cleanup deps

2023-04-17 00:38:49 +09:00

DarwinSDKInfoTest.cpp

[clang] Use std::optional instead of llvm::Optional (NFC)

2023-01-14 12:31:01 -08:00

DiagnosticTest.cpp

[clang/Diagnostic] Use optional to disambiguate between a StoredDiagMessage that is not set vs set as empty string

2023-03-03 12:48:48 -08:00